From fbdab96b5913c8aa7117e3dbee07efc42eea00c1 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Thu, 4 Apr 2019 10:30:22 +0200 Subject: eel-editable-label: Use 'memmove' instead of 'memcpy' Fixes 'flawfinder' warning: (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data. --- eel/eel-editable-label.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/eel/eel-editable-label.c b/eel/eel-editable-label.c index 7dce4802..0fbdc0c5 100644 --- a/eel/eel-editable-label.c +++ b/eel/eel-editable-label.c @@ -2320,7 +2320,7 @@ eel_editable_label_insert_text (EelEditableLabel *label, g_object_freeze_notify (G_OBJECT (label)); memmove (label->text + *index + new_text_length, label->text + *index, label->n_bytes - *index); - memcpy (label->text + *index, new_text, new_text_length); + memmove (label->text + *index, new_text, new_text_length); label->n_bytes += new_text_length; -- cgit v1.2.1