From 945479ac1a4c37d489bcf70b620e9857ccb3192f Mon Sep 17 00:00:00 2001 From: Colomban Wendling Date: Thu, 11 Jun 2020 14:52:10 +0200 Subject: keyboard-properties-a11y-notifications.ui: Fix a11y warnings Fix a11y warnings by making the widget hierarchy more semantic, as well as making it saner (no more space-filled labels to create margins). --- .../mate-keyboard-properties-a11y-notifications.ui | 653 +++++++-------------- capplets/keyboard/ui-a11y.suppr | 13 - 2 files changed, 201 insertions(+), 465 deletions(-) diff --git a/capplets/keyboard/mate-keyboard-properties-a11y-notifications.ui b/capplets/keyboard/mate-keyboard-properties-a11y-notifications.ui index d092d889..5cee7c50 100644 --- a/capplets/keyboard/mate-keyboard-properties-a11y-notifications.ui +++ b/capplets/keyboard/mate-keyboard-properties-a11y-notifications.ui @@ -1,5 +1,5 @@ - + @@ -10,31 +10,27 @@ a11y-notifications-dialog False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK 5 Keyboard Accessibility Audio Feedback center-on-parent dialog - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK vertical 2 - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK end - + gtk-help True True True - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK True @@ -44,12 +40,11 @@ - + gtk-close True True True - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK True @@ -67,48 +62,34 @@ - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK 5 vertical 18 - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 + 0 + none - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - General - - - - - - False - True - 0 - - - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK + 12 + vertical + 6 - + + Beep when _accessibility features are turned on or off True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - + True + False + start + True + True False @@ -117,46 +98,14 @@ - + + Beep when a _toggle key is pressed True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - Beep when _accessibility features are turned on or off - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 0 - - - - - Beep when a _toggle key is pressed - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 1 - - + True + False + start + True + True False @@ -165,11 +114,17 @@ - - False - True - 1 - + + + + True + False + start + General + + + + @@ -179,40 +134,28 @@ - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - Sticky Keys - - - - - - False - True - 0 - - + 0 + none - + True False GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK + 12 + vertical + 6 - + + Beep when a _modifier key is pressed True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - + True + False + start + True + True False @@ -220,43 +163,18 @@ 0 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - Beep when a _modifier key is pressed - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 0 - - - - - False - True - 1 - - - - False - True - 1 - + + + + True + False + start + Sticky Keys + + + + @@ -266,36 +184,27 @@ - + True False - vertical - 6 - - - True - False - start - Visual cues for sounds - - - - - - False - True - 0 - - + 0 + none - + True False + 12 + vertical + 6 - + + Show _visual feedback for the alert sound True - False - + True + False + start + True + True False @@ -304,19 +213,21 @@ - + True False + 12 vertical 6 - - Show _visual feedback for the alert sound + + Flash _window titlebar True True False start True + True True @@ -326,69 +237,15 @@ - + + Flash entire _screen True - False - - - True - False - - - - False - True - 0 - - - - - True - False - vertical - 6 - - - Flash _window titlebar - True - True - False - start - True - True - True - - - False - True - 0 - - - - - Flash entire _screen - True - True - False - start - True - True - True - visual_bell_titlebar - - - False - True - 1 - - - - - False - True - 1 - - + True + False + start + True + True + visual_bell_titlebar False @@ -404,11 +261,17 @@ - - False - True - 1 - + + + + True + False + start + Visual cues for sounds + + + + @@ -418,40 +281,27 @@ - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - Slow Keys - - - - - - False - True - 0 - - + 0 + none - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK + 12 + vertical + 6 - + + Beep when a key is pr_essed True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - + True + False + start + True + True False @@ -460,63 +310,14 @@ - + + Beep when key is _accepted True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - Beep when a key is pr_essed - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 0 - - - - - Beep when key is _accepted - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 1 - - - - - Beep when key is _rejected - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 2 - - + True + False + start + True + True False @@ -524,12 +325,34 @@ 1 + + + Beep when key is _rejected + True + True + False + start + True + True + + + False + True + 2 + + + + + + + True + False + start + Slow Keys + + + - - False - True - 1 - @@ -539,40 +362,27 @@ - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - Bounce Keys - - - - - - False - True - 0 - - + 0 + none - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK + 12 + vertical + 6 - + + Beep when a key is reje_cted True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - + True + False + start + True + True False @@ -580,43 +390,18 @@ 0 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - Beep when a key is reje_cted - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 0 - - - - - False - True - 1 - - - - False - True - 1 - + + + + True + False + start + Bounce Keys + + + + @@ -626,40 +411,29 @@ - + True False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - Caps Lock - - - - - - False - True - 0 - - + 0 + none - + True False GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK + 12 + vertical + 6 - + + Beep when pressing a key while Caps_Lock is active True - False + True + False GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - + start + True + True False @@ -667,43 +441,18 @@ 0 - - - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - vertical - 6 - - - Beep when pressing a key while Caps_Lock is active - True - True - False - GDK_POINTER_MOTION_MASK | GDK_POINTER_MOTION_HINT_MASK | GDK_BUTTON_PRESS_MASK | GDK_BUTTON_RELEASE_MASK - start - True - True - - - False - True - 0 - - - - - False - True - 1 - - - - False - True - 1 - + + + + True + False + start + Caps Lock + + + + @@ -722,8 +471,8 @@ - button11 - button12 + button1 + button2 diff --git a/capplets/keyboard/ui-a11y.suppr b/capplets/keyboard/ui-a11y.suppr index a0775acd..ef5ed196 100644 --- a/capplets/keyboard/ui-a11y.suppr +++ b/capplets/keyboard/ui-a11y.suppr @@ -1,16 +1,3 @@ -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label1'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label2'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label33'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label40'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label47'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label50'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label500'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label99'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label98'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label51'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label53'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label54'] orphan-label -mate-keyboard-properties-a11y-notifications.ui://GtkLabel[@id='label55'] orphan-label mate-keyboard-properties-dialog.ui://GtkLabel[@id='label1'] orphan-label mate-keyboard-properties-dialog.ui://GtkLabel[@id='label43'] orphan-label mate-keyboard-properties-dialog.ui://GtkLabel[@id='delay_short_label'] orphan-label -- cgit v1.2.1