From 17b87e321bfca409c31ce4b4e0e3326eeef92b88 Mon Sep 17 00:00:00 2001 From: Colomban Wendling Date: Wed, 15 Nov 2023 15:31:27 +0100 Subject: Avoid a redundant NULL check It's probably not necessary to perform the NULL check at all as the only code paths that could make `list` NULL are already pretty dramatically broken, but as we have a NULL check move everything relevant inside it. --- mate-panel/panel-profile.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/mate-panel/panel-profile.c b/mate-panel/panel-profile.c index e2b6841d..437eb0e3 100644 --- a/mate-panel/panel-profile.c +++ b/mate-panel/panel-profile.c @@ -1628,12 +1628,13 @@ panel_profile_load_list (GSettings *settings, list = g_settings_get_strv (settings, key); - for (gint i = 0; list[i]; i++) { - load_handler (list[i]); - } + if (list) { + for (gint i = 0; list[i]; i++) { + load_handler (list[i]); + } - if (list) g_strfreev (list); + } } static void -- cgit v1.2.1