atril/shell/ev-sidebar-thumbnails.c, branch sign

epub: Disable thumbnailing sidebar.

2025-04-24T18:31:55+00:00

A recent update to libwebkitgtk2gtk-4.1 breaks using WebKitWebView
in a GtkOffscreenWindow.

Disable the thumbnail sidebar with epub documents, and disable
updating the GtkWindow thumbnail.

ref:
https://github.com/WebKit/WebKit/commit/8d7385fad3ffb31d0c438e6b6a50dffb4390840c

Fixes: #631.

Use a blank line at most

2021-11-20T17:31:11+00:00

Fix cppcheck [knownConditionTrueFalse] warnings

2020-04-15T15:25:45+00:00

Fixes the warnings:

backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse]

backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse]

properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse]

shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse]

shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]

Revert "Fix memory leak in ev_sidebar_thumbnails_document_changed_cb()"

2020-01-19T13:10:55+00:00

This reverts commit bb8194a94310dae72bcbd745cd7f0f93e8d6fad1.

Commit cases a warning when closing atril window, see
https://github.com/mate-desktop/atril/pull/431#issuecomment-576002680
for more info

Fix memory leak in

2020-01-15T12:55:30+00:00

 ev_sidebar_thumbnails_document_changed_cb()

Clear the loading icon hash table if it already exists.

https://bugzilla.gnome.org/show_bug.cgi?id=770070

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/702c7c6

ev-sidebar-thumbnails: avoid 'g_type_class_add_private'

2019-08-16T20:40:31+00:00

Remove trailing whitespaces

2019-07-01T15:07:40+00:00

sidebar-thumbnails: fix unwanted move to start after fullscreen

2017-08-15T12:09:42+00:00

After activating or deactivating fullscreen mode, the sidebar
window is automatically moved to its start, while scroll bar
stays in its original position.

The sidebar window move is unwanted and unsolicited, and it's
most probably caused by GtkIconView or GtkScrolledWindow bug.

Workaround this by having the sidebar sync its window with the
current scroll position after a fullscreen operation, do that by
just emitting a "value-changed" on the current scroll adjustment.

https://bugzilla.gnome.org/show_bug.cgi?id=783404
origin commit:
https://git.gnome.org/browse/evince/commit/?id=2bfb8fa

sidebar-thumbnails: preload one extra visible range while scrolling

2017-08-15T12:09:42+00:00

Preload both before and after current visible scrolling range,
the same amount of thumbnails in it, to help prevent thumbnail
creation happening in the user's sight.

https://bugzilla.gnome.org/show_bug.cgi?id=342110#c15
origin commit:
https://git.gnome.org/browse/evince/commit/?id=1fc8c68

sidebar-thumbnails: keep thumbnails already rendered

2017-08-15T12:09:42+00:00

Evince renders thumbnails on-the-fly as they get into the
scrolling visible area, but at the same time it will remove
them as they get out of the visible scrolling area, so when
user scrolls back to same position he will notice thumbnails
be recreated.

In pro of a more icing user experience, let's adopt a mixed approach
and keep the thumbnails that the user has already navigated, so
when he scrolls back and forth in the same area no thumbnail
re-generation will be visible. This also matches behaviour with
other pdf readers.

https://bugzilla.gnome.org/show_bug.cgi?id=342110
origin commit:
https://git.gnome.org/browse/evince/commit/?id=121e4d9