<feed xmlns='http://www.w3.org/2005/Atom'>
<title>atril/shell/ev-sidebar-thumbnails.c, branch v1.26.3</title>
<subtitle>MATE document viewer</subtitle>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/'/>
<entry>
<title>Use a blank line at most</title>
<updated>2024-01-09T04:02:46+00:00</updated>
<author>
<name>rbuj</name>
<email>robert.buj@gmail.com</email>
</author>
<published>2021-10-27T15:30:36+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=658fab1f008bff7e1ec147d95baa04bc44c2fbcd'/>
<id>658fab1f008bff7e1ec147d95baa04bc44c2fbcd</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix cppcheck [knownConditionTrueFalse] warnings</title>
<updated>2020-04-15T15:25:45+00:00</updated>
<author>
<name>Pablo Barciela</name>
<email>scow@riseup.net</email>
</author>
<published>2020-04-15T03:33:24+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=1f3566651994ead4813dc3253f65ec8a523ecf35'/>
<id>1f3566651994ead4813dc3253f65ec8a523ecf35</id>
<content type='text'>
Fixes the warnings:

backend/comics/comics-document.c:767:21: style: Condition 'bytes&lt;=0' is always true [knownConditionTrueFalse]

backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse]

properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse]

shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse]

shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Fixes the warnings:

backend/comics/comics-document.c:767:21: style: Condition 'bytes&lt;=0' is always true [knownConditionTrueFalse]

backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse]

properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse]

shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse]

shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse]
</pre>
</div>
</content>
</entry>
<entry>
<title>Revert "Fix memory leak in ev_sidebar_thumbnails_document_changed_cb()"</title>
<updated>2020-01-19T13:10:55+00:00</updated>
<author>
<name>raveit65</name>
<email>mate@raveit.de</email>
</author>
<published>2020-01-19T13:07:19+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=8082bc78d006c7bcb1e45e3f4bb6aae502741e3e'/>
<id>8082bc78d006c7bcb1e45e3f4bb6aae502741e3e</id>
<content type='text'>
This reverts commit bb8194a94310dae72bcbd745cd7f0f93e8d6fad1.

Commit cases a warning when closing atril window, see
https://github.com/mate-desktop/atril/pull/431#issuecomment-576002680
for more info
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
This reverts commit bb8194a94310dae72bcbd745cd7f0f93e8d6fad1.

Commit cases a warning when closing atril window, see
https://github.com/mate-desktop/atril/pull/431#issuecomment-576002680
for more info
</pre>
</div>
</content>
</entry>
<entry>
<title>Fix memory leak in</title>
<updated>2020-01-15T12:55:30+00:00</updated>
<author>
<name>Eric R. Schulz</name>
<email>eric@ers35.com</email>
</author>
<published>2016-09-03T15:54:31+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=bb8194a94310dae72bcbd745cd7f0f93e8d6fad1'/>
<id>bb8194a94310dae72bcbd745cd7f0f93e8d6fad1</id>
<content type='text'>
 ev_sidebar_thumbnails_document_changed_cb()

Clear the loading icon hash table if it already exists.

https://bugzilla.gnome.org/show_bug.cgi?id=770070

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/702c7c6
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
 ev_sidebar_thumbnails_document_changed_cb()

Clear the loading icon hash table if it already exists.

https://bugzilla.gnome.org/show_bug.cgi?id=770070

origin commit:
https://gitlab.gnome.org/GNOME/evince/commit/702c7c6
</pre>
</div>
</content>
</entry>
<entry>
<title>ev-sidebar-thumbnails: avoid 'g_type_class_add_private'</title>
<updated>2019-08-16T20:40:31+00:00</updated>
<author>
<name>Pablo Barciela</name>
<email>scow@riseup.net</email>
</author>
<published>2019-08-09T10:27:08+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=1c9506d7584c1136777842444541ede602a84259'/>
<id>1c9506d7584c1136777842444541ede602a84259</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>Remove trailing whitespaces</title>
<updated>2019-07-01T15:07:40+00:00</updated>
<author>
<name>Laurent Napias</name>
<email>tamplan@free.fr</email>
</author>
<published>2019-06-29T08:43:23+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=aa24676651f8bd3e8b434f72d5aac98e84c0867d'/>
<id>aa24676651f8bd3e8b434f72d5aac98e84c0867d</id>
<content type='text'>
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
</pre>
</div>
</content>
</entry>
<entry>
<title>sidebar-thumbnails: fix unwanted move to start after fullscreen</title>
<updated>2017-08-15T12:09:42+00:00</updated>
<author>
<name>Nelson Benitez Leon</name>
<email>nbenitezl@gmail.com</email>
</author>
<published>2017-06-04T13:08:29+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=4f39960daadb0a89f752d314b81612dcec5a30c0'/>
<id>4f39960daadb0a89f752d314b81612dcec5a30c0</id>
<content type='text'>
After activating or deactivating fullscreen mode, the sidebar
window is automatically moved to its start, while scroll bar
stays in its original position.

The sidebar window move is unwanted and unsolicited, and it's
most probably caused by GtkIconView or GtkScrolledWindow bug.

Workaround this by having the sidebar sync its window with the
current scroll position after a fullscreen operation, do that by
just emitting a "value-changed" on the current scroll adjustment.

https://bugzilla.gnome.org/show_bug.cgi?id=783404
origin commit:
https://git.gnome.org/browse/evince/commit/?id=2bfb8fa
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
After activating or deactivating fullscreen mode, the sidebar
window is automatically moved to its start, while scroll bar
stays in its original position.

The sidebar window move is unwanted and unsolicited, and it's
most probably caused by GtkIconView or GtkScrolledWindow bug.

Workaround this by having the sidebar sync its window with the
current scroll position after a fullscreen operation, do that by
just emitting a "value-changed" on the current scroll adjustment.

https://bugzilla.gnome.org/show_bug.cgi?id=783404
origin commit:
https://git.gnome.org/browse/evince/commit/?id=2bfb8fa
</pre>
</div>
</content>
</entry>
<entry>
<title>sidebar-thumbnails: preload one extra visible range while scrolling</title>
<updated>2017-08-15T12:09:42+00:00</updated>
<author>
<name>Nelson Benitez Leon</name>
<email>nbenitezl@gmail.com</email>
</author>
<published>2017-06-03T14:35:55+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=c3bc9fa16ddeae691b9154024725dd85d56011d7'/>
<id>c3bc9fa16ddeae691b9154024725dd85d56011d7</id>
<content type='text'>
Preload both before and after current visible scrolling range,
the same amount of thumbnails in it, to help prevent thumbnail
creation happening in the user's sight.

https://bugzilla.gnome.org/show_bug.cgi?id=342110#c15
origin commit:
https://git.gnome.org/browse/evince/commit/?id=1fc8c68
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Preload both before and after current visible scrolling range,
the same amount of thumbnails in it, to help prevent thumbnail
creation happening in the user's sight.

https://bugzilla.gnome.org/show_bug.cgi?id=342110#c15
origin commit:
https://git.gnome.org/browse/evince/commit/?id=1fc8c68
</pre>
</div>
</content>
</entry>
<entry>
<title>sidebar-thumbnails: keep thumbnails already rendered</title>
<updated>2017-08-15T12:09:42+00:00</updated>
<author>
<name>Nelson Benitez Leon</name>
<email>nbenitezl@gmail.com</email>
</author>
<published>2017-06-03T10:56:04+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=79a83766f4ce2f3ee29ada760e0a17f48e7be034'/>
<id>79a83766f4ce2f3ee29ada760e0a17f48e7be034</id>
<content type='text'>
Evince renders thumbnails on-the-fly as they get into the
scrolling visible area, but at the same time it will remove
them as they get out of the visible scrolling area, so when
user scrolls back to same position he will notice thumbnails
be recreated.

In pro of a more icing user experience, let's adopt a mixed approach
and keep the thumbnails that the user has already navigated, so
when he scrolls back and forth in the same area no thumbnail
re-generation will be visible. This also matches behaviour with
other pdf readers.

https://bugzilla.gnome.org/show_bug.cgi?id=342110
origin commit:
https://git.gnome.org/browse/evince/commit/?id=121e4d9
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Evince renders thumbnails on-the-fly as they get into the
scrolling visible area, but at the same time it will remove
them as they get out of the visible scrolling area, so when
user scrolls back to same position he will notice thumbnails
be recreated.

In pro of a more icing user experience, let's adopt a mixed approach
and keep the thumbnails that the user has already navigated, so
when he scrolls back and forth in the same area no thumbnail
re-generation will be visible. This also matches behaviour with
other pdf readers.

https://bugzilla.gnome.org/show_bug.cgi?id=342110
origin commit:
https://git.gnome.org/browse/evince/commit/?id=121e4d9
</pre>
</div>
</content>
</entry>
<entry>
<title>sidebar-thumbnails: fix clunky scrolling</title>
<updated>2017-08-15T12:09:42+00:00</updated>
<author>
<name>Nelson Benitez Leon</name>
<email>nbenitezl@gmail.com</email>
</author>
<published>2017-05-28T17:35:05+00:00</published>
<link rel='alternate' type='text/html' href='http://git.mate-desktop.org/atril/commit/?id=744a1c5e8259773b35600944c28189b98879f937'/>
<id>744a1c5e8259773b35600944c28189b98879f937</id>
<content type='text'>
Caused by GtkIconView doing an invalidate and relayout of *all*
items in the view anytime we update model data in any indiviual
item (which happens with all the items that are getting in and out
of the scrolling area while we scroll). This caused GtkIconView to
machine-gunned us with "size-allocate" signals, a signal we were
using to update thumbnails when the sidebar is resized.

Fixed by connecting to the GtkTreeModel "row-changed" signal before
GtkIconView does it, and stop emission from there.

As we don't depend now on "size-allocate" signals to show thumbnails
while we scroll, just queue a draw on the icon view when a
thumbnail finish rendering.

Thanks Jose Aliste for first spotting the problem.

https://bugzilla.gnome.org/show_bug.cgi?id=691448
origin commit:
https://git.gnome.org/browse/evince/commit/?id=6480c70

Fixes https://github.com/mate-desktop/atril/issues/255
</content>
<content type='xhtml'>
<div xmlns='http://www.w3.org/1999/xhtml'>
<pre>
Caused by GtkIconView doing an invalidate and relayout of *all*
items in the view anytime we update model data in any indiviual
item (which happens with all the items that are getting in and out
of the scrolling area while we scroll). This caused GtkIconView to
machine-gunned us with "size-allocate" signals, a signal we were
using to update thumbnails when the sidebar is resized.

Fixed by connecting to the GtkTreeModel "row-changed" signal before
GtkIconView does it, and stop emission from there.

As we don't depend now on "size-allocate" signals to show thumbnails
while we scroll, just queue a draw on the icon view when a
thumbnail finish rendering.

Thanks Jose Aliste for first spotting the problem.

https://bugzilla.gnome.org/show_bug.cgi?id=691448
origin commit:
https://git.gnome.org/browse/evince/commit/?id=6480c70

Fixes https://github.com/mate-desktop/atril/issues/255
</pre>
</div>
</content>
</entry>
</feed>
