Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes https://github.com/mate-desktop/atril/issues/308
|
|
origin commit:
https://github.com/linuxmint/xreader/commit/6ed0ee1
Note: origin commit causes some serious build warnings,
......fixed.
|
|
and require caja >= 1.17.1
|
|
in GTK+3 build as well
|
|
- GTK+2 build: use signals to get notifications about load finish
and errors (instead of polling in idle function)
- GTK+2 build: indicate that job failed when the thumbnail loading
fails - it doesn't seem to change anything though, but gotta
figure out how to do the same in GTK+3 build for consistency
- changed lock/unlock logic so that there's no locking in a function
and unlocking in a callback
|
|
avoids calling the callback twice and crashing in GTK+3 build
(because that callback unlocks the mutex, and glib gets angry
when you unlock a mutex twice)
Closes https://github.com/mate-desktop/atril/pull/128
|
|
Taken from evince commit: ae4835dbed02ae928d96fb6360f7d5c62416044b
From: Carlos Garcia Campos <[email protected]>
|
|
It's safe to call it multiple times, and we still don't emit our
cancelled signal for finished jobs.
Taken from evince commit: 87084fb2aabc726343f6515c09ac6d2bba42afb1
From: Carlos Garcia Campos <[email protected]>
|
|
Getting the page of a named destination requires to take the doc lock,
so it might block the main thread.
Taken from evince commit: b6f2f6c391fa83cb9532e98f561057f022522147
From: Carlos Garcia Campos <[email protected]>
|
|
|
|
|
|
|
|
Added the required preprocessor directives to make building without epub support possible.
|
|
Resolved the issue with epub document where the documents were not getting finalised. My bad, sorry, I fix that with this commit.
Also it seems I had set the wrong permissions on ev-view.[c,h]. Also fixed that.
|
|
I came across a document that didn't have an old style toc, and thus the all accomodating navsheet support.
Also fixed some mistakes here and there.
|
|
Added the function to handle links from the toolbar, also added functions to disconnect all ev-view handlers once it has been replaced by ev-web-view, and vice-versa(to drop all handler associated to ev-web-view).
Also the unref call to job_thumb was causing thumbnail jobs to crash with GTK2, so had to revert that, now we're back to the document folder not getting deleted from disk.
|
|
I added the code to make it possible to build Atril with GTK3 and webkit2. Everything runs fine with both GTK3 and GTK2. The find module for epub was also tested and changed. Now I shall first attempt to fix some Glib errors, and the problem of the temporary directory not getting deleted, that arose when I stabilized the thumbnails.
|
|
No more crashes when searching with the sidebar open, will probably add a pixbuf cache as well to speed it up even further.
The process which I earlier thought was not possible without separate jobs, work just fine as a single job, if I change the run mode of the thumbnail job, and incorporate a trylock() in case of epub.
|
|
I added the capability to search through documents. The search is quite buggy, and we'll be taking care of each bug one at a time.
|
|
..and other fixing other bugs that were present once the webview was added, like the escape key command etc. Will look to refactor the thumbnails into ev-web-view.c.
In the next commit I'll extend this search over the entire document.Also will incorporate document index(table of contents).
|
|
Select all functionality to select all content from the webview.
Cleaned ev-jobs.c, it had a lot of unused code.
|
|
Passes the test with a 71 page epub, I don't think it would have much problems were we to scale it further.
|
|
The loading icons for all thumbnails are displayed, but the program does not segfault. Also realized that the absurd resizing of the window was due to the ephy-zoom action on the webview window. Will fix that in the next commit. Will also think of some workaround for screenshots.
For now committed this code so that this can act as a clean slate if I screw up somewhere.
|
|
Including creation of windows, webviews etc., still get a crash. The one page epub works fine with the thumbnails though.
Also fixing some calls which cause gtk-critical errors when I try to close the window.
|
|
Properties dialog for epub documents, will some basic properties.
Also set toolbar and menu sensitivity for the actions available in epub, will add more(find) once I write the module. Also inverted colors needs to be done with CSS or the like.
|
|
|
|
Now other problems with webkit. After much fidgeting I was able to resolve the previous problems of threads. However, now there is a different webkit error.
|
|
My last commit was supposed to have ev-web-view.c and ev-web-view.h however due to some reason I missed them last time, so here they are now. i am able to achieve thumbnails for my epub however these are of absurdly large size. Still struggling to get the webview done due to thread problems that I am encountering.
|
|
- Modified configure.ac to use both webkit2 and webkit1 based on gtk version
- Modified Automake file in help/reference/shell/Makefile.am to compile with gtk-doc
- Modified ev-document-model to support epub-documents.
- Modified ev-window for epub documents.
- Modified jobs so epub pages are not rendered.
- Modified ev-document, although I'm not sure if this is necessary.
Still need to figure out where the web view load uri has to be called to actually load pages, from there the puzzle would be much simpler. Hope to get this done in the week, and pick up the pace now that only six weeks of coding remain before final evaluation.
|
|
|
|
|