From 1f3566651994ead4813dc3253f65ec8a523ecf35 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Wed, 15 Apr 2020 05:33:24 +0200 Subject: Fix cppcheck [knownConditionTrueFalse] warnings Fixes the warnings: backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse] backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse] properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse] shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse] shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse] --- backend/comics/comics-document.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'backend/comics/comics-document.c') diff --git a/backend/comics/comics-document.c b/backend/comics/comics-document.c index ae37d23a..d799b208 100644 --- a/backend/comics/comics-document.c +++ b/backend/comics/comics-document.c @@ -764,7 +764,7 @@ comics_document_render_pixbuf (EvDocument *document, if (bytes > 0) { gdk_pixbuf_loader_write (loader, buf, bytes, NULL); - } else if (bytes <= 0) { + } else { close (outpipe); gdk_pixbuf_loader_close (loader, NULL); outpipe = -1; -- cgit v1.2.1