From 1f3566651994ead4813dc3253f65ec8a523ecf35 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Wed, 15 Apr 2020 05:33:24 +0200 Subject: Fix cppcheck [knownConditionTrueFalse] warnings Fixes the warnings: backend/comics/comics-document.c:767:21: style: Condition 'bytes<=0' is always true [knownConditionTrueFalse] backend/epub/minizip/unzip.c:603:25: style: Condition 'unz_copyright[0]!=' '' is always false [knownConditionTrueFalse] properties/ev-properties-view.c:197:33: style: Condition 'text' is always true [knownConditionTrueFalse] shell/ev-sidebar-thumbnails.c:598:7: style: Condition '!loading_icon' is always true [knownConditionTrueFalse] shell/main.c:115:6: style: Condition '!error' is always true [knownConditionTrueFalse] --- properties/ev-properties-view.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'properties/ev-properties-view.c') diff --git a/properties/ev-properties-view.c b/properties/ev-properties-view.c index e6d703c7..cc81dab9 100644 --- a/properties/ev-properties-view.c +++ b/properties/ev-properties-view.c @@ -194,7 +194,7 @@ set_property (EvPropertiesView *properties, gtk_label_set_markup (GTK_LABEL (label), markup); g_free (markup); } else { - valid_text = make_valid_utf8 (text ? text : ""); + valid_text = make_valid_utf8 (text); gtk_label_set_text (GTK_LABEL (label), valid_text); g_free (valid_text); } -- cgit v1.2.1