Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
Do not need to extend glib library, since it now incorporates these functions.
Extended date format modifiers are available on glib v2.56.
eel-glib-extensions.h/c:
GDate * eel_g_date_new_tm (struct tm *time_pieces);
char * eel_strdup_strftime (const char *format, struct tm *time_pieces);
gint64 eel_get_system_time (void);
Do not need to test the extensions in eel_self_check_glib_extensions (void).
eel-glib-extensions.c:
static void check_tm_to_g_date (time_t time)
static char * test_strftime (...)
Do not need to check if strftime implements extended date format modifiers on the system (available on glibc v2.27).
configure.ac
|
|
|
|
Fixes 'cppcheck' warnings:
[src/caja-location-dialog.c:229] -> [src/caja-location-dialog.c:237]: (warning) Either the condition 'window' is redundant or there is possible null pointer dereference: window.
[src/caja-location-dialog.c:224]: (style) The scope of the variable 'formatted_location' can be reduced.
Fixes Clang static analyzer warning:
caja-location-dialog.c:237:12: warning: Access to field 'details' results in a dereference of a null pointer (loaded from variable 'window')
slot = window->details->active_pane->active_slot;
^~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warnings:
caja-property-browser.c:1242:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption
CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
caja-property-browser.c:1414:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption
CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~
caja-property-browser.c:1450:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption
CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER(data);
^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
|
|
|
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted
Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
|
|
Fix #1198 "Context menu with menu key broken"
Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
|
|
Fixes Clang static analyzer warning:
caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference
g_object_unref (files[idx]);
^~~~~~~~~~
|
|
Fixes Clang static analyzer warnings:
fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value
if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value
if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
GNOME/nautilus@7af24a8
Replace
GList * eel_g_object_list_copy (GList *list)
with
g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
|
|
Fixes Clang static analyzer warning:
caja-sidebar-title.c:233:49: warning: Dereference of null pointer (loaded from variable 'color')
sidebar_title->details->label_colors[idx] = *color;
^~~~~~
|
|
|
|
Fixes Clang static analyzer warning:
caja-window.c:554:34: warning: The left operand of '<' is a garbage value
MIN (default_width,
^ ~~~~~~~~~~~~~
|
|
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
|
|
|
|
Note that GTK+ sets a default title of _("About %s") on the dialog
window (where %s is replaced by the name of the application, but
in order to ensure proper translation of the title, applications
should set the title property explicitly when constructing a
GtkAboutDialog
https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html
|
|
Merged the authors with the new ones:
git log --pretty="%an <%ae>" --since "2012-01-01" -- . "*.h" "*.c" | sort | uniq
|
|
Update "Documented by" in About Caja dialog
|
|
Fixed make distcheck, see #1129
|
|
Changed CajaInformationPanel, CajaLocationBar and CajaNavigationAction
|
|
|
|
Changed CajaSidePane, CajaSpatialWindow, CajaViewAsAction and CajaXContentBar
|
|
Changed CajaConnectServerOperation, CajaDesktopWindow and CajaImagePropertiesPage
|
|
Remove unused variables, avoid uninitialized variable warnings, and indent code.
|
|
|
|
|
|
Thanks for Leslie Zhai's patch.
|
|
- caja-connect-server-dialog
- caja-navigation-window
- caja-property-browser
- caja-sidebar-title
- caja-trash-bar
- caja-window
- caja-zoom-action
- caja-zoom-control
- fm-desktop-icon-view
- fm-properties-window
|
|
|
|
|
|
Fix crash on starting with env DESKTOP_AUTOSTART_ID=ANY_CHARS caja
|
|
An example of when the MIME type might change: a file is initially created
with 0 bytes of content, but more data is added later. Empty files are always
detected as plain text, but the file might not be empty anymore when the user
opens it.
This commit affects the behavior when double-clicking a file and when right-
clicking on it too.
|
|
The code looked like it was supposed to check whether each file in the
selection could be opened in an external app, but was only checking the
first item in the selection repeatedly.
This bug may have been mostly benign since the subsequent call to
caja_mime_get_default_application_for_files will return NULL anyway if the
files don't all match each other.
|
|
This reverts commit 021ff2ac062f1cfd52726c78e9a3956405001c6e.
Fixes https://github.com/mate-desktop/caja/issues/1101
|
|
Fixes https://github.com/mate-desktop/caja/issues/1099
|
|
|
|
|
|
|
|
Both of these uses are incorrect and if this code is ever run would likely segfault.
Adapted from https://github.com/linuxmint/nemo/commit/4ffea61b26033da1305ab8287058044065a1c101
|
|
Fix https://github.com/mate-desktop/caja/issues/1046
drive_stop_cb should never have used g_drive_poll_for_media_finish which is for
ejectable media in a fixed drive (e.g CD drive) and not for stopping a removable drive
|