From 961af3468a5ac1e17f6af93c490093a7e6e431ae Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Sat, 23 Feb 2019 19:00:46 +0100 Subject: caja-information-panel: Fix use of memory after it is freed to avoid warning with Clang Analyzer --- src/caja-information-panel.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/caja-information-panel.c b/src/caja-information-panel.c index e91ca103..d4a22df4 100644 --- a/src/caja-information-panel.c +++ b/src/caja-information-panel.c @@ -945,6 +945,9 @@ add_buttons_from_metadata (CajaInformationPanel *information_panel, const char * *temp_str = '\0'; if (!g_ascii_strcasecmp (current_term, "button")) { + if (button_name) + g_free (button_name); + button_name = g_strdup (temp_str + 1); } else if (!g_ascii_strcasecmp (current_term, "script")) @@ -958,7 +961,6 @@ add_buttons_from_metadata (CajaInformationPanel *information_panel, const char * 0); information_panel->details->has_buttons = TRUE; command_string = g_strdup (temp_str + 1); - g_free (button_name); g_signal_connect_data (temp_button, "clicked", @@ -975,6 +977,7 @@ add_buttons_from_metadata (CajaInformationPanel *information_panel, const char * } g_free(current_term); } + g_free (button_name); g_strfreev (terms); } -- cgit v1.2.1