From efbfc94e8840a5ef36610356b81a9dd456be0c15 Mon Sep 17 00:00:00 2001 From: lukefromdc Date: Wed, 5 Mar 2025 01:41:11 -0500 Subject: wayland/window closing: avoid a crash on gtk_widget_destroy * Do not attempt to unref or destroy a child of a container *In GTK 3 at least, GtkContainers automatically destroy child widgets when destroyed --- libcaja-private/caja-icon-container.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libcaja-private/caja-icon-container.c b/libcaja-private/caja-icon-container.c index 4c4c084c..d30add27 100644 --- a/libcaja-private/caja-icon-container.c +++ b/libcaja-private/caja-icon-container.c @@ -4416,7 +4416,10 @@ destroy (GtkWidget *object) /* destroy interactive search dialog */ if (container->details->search_window) { - gtk_widget_destroy (container->details->search_window); + /*current GTK docs do not advise calling gtk_widget_destroy on child widgets + *gtk_widget_destroy (container->details->search_window); + *also note that GtkContainer destroys it's child widgets when it is destroyed + */ container->details->search_window = NULL; container->details->search_entry = NULL; if (container->details->typeselect_flush_timeout) -- cgit v1.2.1