From b26eff1f5c823c6eafbc24bb4552c071c41f34b7 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Sun, 3 Mar 2019 02:54:35 +0100 Subject: eel-gdk-pixbuf-extensions: Fix division by zero Fixes Clang static analyzer warning: eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero *dest++ = r / n_pixels; ~~^~~~~~~~~~ --- eel/eel-gdk-pixbuf-extensions.c | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) (limited to 'eel/eel-gdk-pixbuf-extensions.c') diff --git a/eel/eel-gdk-pixbuf-extensions.c b/eel/eel-gdk-pixbuf-extensions.c index 646a5734..b74b1062 100644 --- a/eel/eel-gdk-pixbuf-extensions.c +++ b/eel/eel-gdk-pixbuf-extensions.c @@ -400,9 +400,18 @@ eel_gdk_pixbuf_scale_down (GdkPixbuf *pixbuf, } else { - *dest++ = r / n_pixels; - *dest++ = g / n_pixels; - *dest++ = b / n_pixels; + if (n_pixels != 0) + { + *dest++ = r / n_pixels; + *dest++ = g / n_pixels; + *dest++ = b / n_pixels; + } + else + { + *dest++ = 0; + *dest++ = 0; + *dest++ = 0; + } } s_x1 = s_x2; -- cgit v1.2.1