From 312394dfa42c07a3afa5089c6e3e5b9a1c1001ae Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Sat, 9 Mar 2019 21:45:50 +0100 Subject: eel-string: avoid 'memcpy' with NULL argument Fixes Clang static analyzer warning: eel-string.c:325:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (result_position, replacement, replacement_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ --- eel/eel-string.c | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'eel/eel-string.c') diff --git a/eel/eel-string.c b/eel/eel-string.c index c44706c1..c71aadb7 100644 --- a/eel/eel-string.c +++ b/eel/eel-string.c @@ -292,6 +292,10 @@ eel_str_replace_substring (const char *string, { return NULL; } + else if (replacement == NULL) + { + return (char *) string; + } substring_length = strlen (substring); replacement_length = eel_strlen (replacement); -- cgit v1.2.1