From ed722a990406ce48b353c5eb7499fa8662cdff12 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Thu, 13 Jun 2019 09:01:26 +0200 Subject: caja-open-with-dialog: cppcheck: Redundant condition Fixes cppcheck warning: [libcaja-private/caja-open-with-dialog.c:265]: (style) Redundant condition: !dialog->details->add_mode. 'A || (!A && B)' is equivalent to 'A || B' --- libcaja-private/caja-open-with-dialog.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'libcaja-private/caja-open-with-dialog.c') diff --git a/libcaja-private/caja-open-with-dialog.c b/libcaja-private/caja-open-with-dialog.c index 94ef8d07..bfd51359 100644 --- a/libcaja-private/caja-open-with-dialog.c +++ b/libcaja-private/caja-open-with-dialog.c @@ -263,8 +263,7 @@ add_or_find_application (CajaOpenWithDialog *dialog) } should_set_default = (dialog->details->add_mode) || - (!dialog->details->add_mode && - gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (dialog->details->checkbox))); + gtk_toggle_button_get_active (GTK_TOGGLE_BUTTON (dialog->details->checkbox)); success = TRUE; if (should_set_default) -- cgit v1.2.1