From be2355c8ece8ad7f50ab80185e98b865fa534cf4 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Fri, 22 Mar 2019 12:34:57 +0100 Subject: file-utils: avoid out of bound memory access Fixes Clang static analyzer warning: file-utils.c:453:6: warning: Out of bound memory access (access exceeds upper limit of memory block) if (file_name [last_char] == G_DIR_SEPARATOR) ^~~~~~~~~~~~~~~~~~~~~ --- src/file-utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/file-utils.c b/src/file-utils.c index e3e1fc3..5535566 100644 --- a/src/file-utils.c +++ b/src/file-utils.c @@ -445,7 +445,7 @@ const gchar* file_name_from_path(const gchar *file_name) if (file_name == NULL) return NULL; - if (file_name[0] == '\0') + if ((file_name[0] == '\0') || (strlen (file_name) == 0)) return ""; last_char = strlen (file_name) - 1; -- cgit v1.2.1