From 530440ff8aeeb8bf2cbc807824c74519353d8686 Mon Sep 17 00:00:00 2001 From: rbuj Date: Thu, 5 Sep 2019 17:42:44 +0200 Subject: Remove warning: format not a string literal, argument types not checked ui/tabpopup.c:176:7: warning: format not a string literal, argument types not checked [-Wformat-nonliteral] 176 | tmp = g_markup_printf_escaped (formatter, str); | ^~~ --- src/ui/tabpopup.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/src/ui/tabpopup.c b/src/ui/tabpopup.c index 18ee83d5..0f6e129a 100644 --- a/src/ui/tabpopup.c +++ b/src/ui/tabpopup.c @@ -164,16 +164,10 @@ tab_entry_new (const MetaTabEntry *entry, { gchar *str; gchar *tmp; - gchar *formatter = "%s"; str = meta_g_utf8_strndup (entry->title, 4096); - if (entry->hidden) - { - formatter = "[%s]"; - } - - tmp = g_markup_printf_escaped (formatter, str); + tmp = g_markup_printf_escaped (entry->hidden ? "[%s]" : "%s", str); g_free (str); str = tmp; -- cgit v1.2.1