From a2e5ae7dbeb6f16a9a560b070add4a2e2786989a Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Mon, 22 Apr 2019 17:37:22 +0200 Subject: math-buttons: Fix cppcheck warning: Identical inner 'return' Fixes cppcheck warning: [src/math-buttons.c:513] -> [src/math-buttons.c:514]: (warning) Identical inner 'return' condition is always true. --- src/math-buttons.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/math-buttons.c b/src/math-buttons.c index 1d96b3e..a97d6ee 100644 --- a/src/math-buttons.c +++ b/src/math-buttons.c @@ -511,7 +511,7 @@ load_mode(MathButtons *buttons, ButtonMode mode) } if (*panel) - return *panel; + goto out; builder = *builder_ptr = gtk_builder_new(); // FIXME: Show dialog if failed to load @@ -663,6 +663,7 @@ load_mode(MathButtons *buttons, ButtonMode mode) display_changed_cb(buttons->priv->equation, NULL, buttons); +out: return *panel; } -- cgit v1.2.1