From 2876f1eba73c126cfc6017856345e7eebe6d8d61 Mon Sep 17 00:00:00 2001 From: Jasmine Hassan Date: Mon, 10 Dec 2012 05:32:03 +0200 Subject: [mate-bg] cleanup, refactor, plug possible X client leak(s) Part of the original code (from gnome-desktop) for setting root pixmap seems very similar to, and may have been adapted from common source: http://people.debian.org/~lunar/xwpset.c The original concept all dates back to an Eterm/Esetroot technique that became commonly used (ex. xchat) for window transparency over desktop: http://www.eterm.org/docs/view.php?doc=ref#trans Wisdom can be gained from studying various similar implementations. Examples: https://github.com/derf/feh/blob/master/src/wallpaper.c http://ag.cs.uvic.ca/static/debian5/sources/blackbox_0.70.1/blackbox-0.70.1.orig/util/bsetroot.cc http://files.minuslab.net/SetBG.cc The changes should hopefully help avoid this: https://bugzilla.gnome.org/show_bug.cgi?id=681928 and consequences as these: https://bugzilla.gnome.org/show_bug.cgi?id=680356 https://bugzilla.gnome.org/show_bug.cgi?id=680354 --- libmate-desktop/libmateui/mate-bg.h | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'libmate-desktop/libmateui') diff --git a/libmate-desktop/libmateui/mate-bg.h b/libmate-desktop/libmateui/mate-bg.h index 14f576f..d909ec4 100644 --- a/libmate-desktop/libmateui/mate-bg.h +++ b/libmate-desktop/libmateui/mate-bg.h @@ -1,6 +1,7 @@ /* mate-bg.h - - Copyright 2007, Red Hat, Inc. + Copyright (C) 2007 Red Hat, Inc. + Copyright (C) 2012 Jasmine Hassan This file is part of the Mate Library. @@ -19,7 +20,8 @@ write to the Free Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301, USA. - Author: Soren Sandmann + Authors: Soren Sandmann + Jasmine Hassan */ #ifndef __MATE_BG_H__ -- cgit v1.2.1