From 48df7a0c71a2df4050abae40ec9ca2b35dee7988 Mon Sep 17 00:00:00 2001 From: Monsta Date: Sat, 8 Nov 2014 15:24:59 +0300 Subject: changed checking for NULL a bit the code below clearly assumes that slide should never be NULL, so the check is now done via g_return_if_fail Closes https://github.com/mate-desktop/mate-desktop/pull/143 --- libmate-desktop/mate-bg.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) (limited to 'libmate-desktop') diff --git a/libmate-desktop/mate-bg.c b/libmate-desktop/mate-bg.c index 2ff4e92..692992e 100644 --- a/libmate-desktop/mate-bg.c +++ b/libmate-desktop/mate-bg.c @@ -2855,10 +2855,15 @@ handle_text (GMarkupParseContext *context, GError **err) { SlideShow *parser = user_data; - Slide *slide = parser->slides->tail? parser->slides->tail->data : NULL; FileSize *fs; gint i; + g_return_if_fail (parser != NULL); + g_return_if_fail (parser->slides != NULL); + g_return_if_fail (parser->slides->tail != NULL); + + Slide *slide = parser->slides->tail->data; + if (stack_is (parser, "year", "starttime", "background", NULL)) { parser->start_tm.tm_year = parse_int (text) - 1900; } -- cgit v1.2.1