From c03f19b451aaa4523cacb45f6b37867546f8f1b5 Mon Sep 17 00:00:00 2001 From: monsta Date: Thu, 1 Sep 2016 15:55:29 +0300 Subject: window picker: disconnect some missing signal handlers should prevent crashes in some cases when object is already destroyed and is being accessed from signal handler after that --- mate-window-picker-applet/task-item.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mate-window-picker-applet/task-item.c b/mate-window-picker-applet/task-item.c index 93fae92..7c4c7c8 100644 --- a/mate-window-picker-applet/task-item.c +++ b/mate-window-picker-applet/task-item.c @@ -623,12 +623,13 @@ on_screen_window_closed (WnckScreen *screen, if (priv->window == window) { - g_signal_handlers_disconnect_by_func (screen, G_CALLBACK (on_screen_window_closed), item); + g_signal_handlers_disconnect_by_func (screen, G_CALLBACK (on_screen_active_viewport_changed), item); g_signal_handlers_disconnect_by_func (screen, G_CALLBACK (on_screen_active_window_changed), item); g_signal_handlers_disconnect_by_func (screen, G_CALLBACK (on_screen_active_workspace_changed), item); g_signal_handlers_disconnect_by_func (screen, G_CALLBACK (on_screen_window_closed), item); g_signal_handlers_disconnect_by_func (window, G_CALLBACK (on_window_workspace_changed), item); g_signal_handlers_disconnect_by_func (window, G_CALLBACK (on_window_state_changed), item); + g_signal_handlers_disconnect_by_func (window, G_CALLBACK (on_window_icon_changed), item); g_signal_emit (G_OBJECT (item), task_item_signals[TASK_ITEM_CLOSED_SIGNAL], 0); } -- cgit v1.2.1