From 406e09ec637deeafe6d34361c8896df6bbfef22b Mon Sep 17 00:00:00 2001 From: Colomban Wendling Date: Wed, 15 Nov 2023 15:39:56 +0100 Subject: Reduce scope of more code The computed values are only used in one branch, so compute them there. --- mate-panel/libpanel-util/panel-color.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/mate-panel/libpanel-util/panel-color.c b/mate-panel/libpanel-util/panel-color.c index 661e6fb5..15ebf686 100644 --- a/mate-panel/libpanel-util/panel-color.c +++ b/mate-panel/libpanel-util/panel-color.c @@ -87,25 +87,25 @@ hls_to_rgb (gdouble *h, gdouble *l, gdouble *s) { gdouble lightness; gdouble saturation; - gdouble m1, m2; lightness = *l; saturation = *s; - if (lightness <= 0.5) - m2 = lightness * (1 + saturation); - else - m2 = lightness + saturation - lightness * saturation; - m1 = 2 * lightness - m2; - if (saturation == 0) { *h = lightness; *l = lightness; *s = lightness; } else { gdouble hue; + gdouble m1, m2; gdouble r, g, b; + if (lightness <= 0.5) + m2 = lightness * (1 + saturation); + else + m2 = lightness + saturation - lightness * saturation; + m1 = 2 * lightness - m2; + hue = *h + 120; while (hue > 360) hue -= 360; -- cgit v1.2.1