From 1db7d2a9963e990cc0bf8a7038f74fdb63e0b3b0 Mon Sep 17 00:00:00 2001 From: rbuj Date: Sat, 16 Feb 2019 23:22:06 +0100 Subject: Ensure proper translation of the about dialog title Note that GTK+ sets a default title of _("About %s") on the dialog window (where %s is replaced by the name of the application, but in order to ensure proper translation of the title, applications should set the title property explicitly when constructing a GtkAboutDialog https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html --- applets/clock/clock.c | 1 + applets/fish/fish.c | 1 + applets/notification_area/main.c | 1 + applets/wncklet/showdesktop.c | 1 + applets/wncklet/window-list.c | 1 + applets/wncklet/window-menu.c | 1 + applets/wncklet/workspace-switcher.c | 1 + 7 files changed, 7 insertions(+) (limited to 'applets') diff --git a/applets/clock/clock.c b/applets/clock/clock.c index 8b60341e..b752099a 100644 --- a/applets/clock/clock.c +++ b/applets/clock/clock.c @@ -3293,6 +3293,7 @@ static void display_about_dialog(GtkAction* action, ClockData* cd) gtk_show_about_dialog(NULL, "program-name", _("Clock"), + "title", _("About Clock"), "authors", authors, "comments", _("The Clock displays the current time and date"), "copyright", _("Copyright \xc2\xa9 1998-2004 Free Software Foundation, Inc.\n" diff --git a/applets/fish/fish.c b/applets/fish/fish.c index 922d6ba0..976c3087 100644 --- a/applets/fish/fish.c +++ b/applets/fish/fish.c @@ -556,6 +556,7 @@ static void display_about_dialog(GtkAction* action, FishApplet* fish) gtk_show_about_dialog(NULL, "program-name", _("Fish"), + "title", _("About Fish"), "authors", authors, "comments", descr, "copyright", _("Copyright \xc2\xa9 1998-2002 Free Software Foundation, Inc.\n" diff --git a/applets/notification_area/main.c b/applets/notification_area/main.c index 613a2470..12a1e073 100644 --- a/applets/notification_area/main.c +++ b/applets/notification_area/main.c @@ -274,6 +274,7 @@ static void about_cb(GtkAction* action, NaTrayApplet* applet) gtk_show_about_dialog(NULL, "program-name", _("Notification Area"), + "title", _("About Notification Area"), "authors", authors, //"comments", _(comments), "copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n" diff --git a/applets/wncklet/showdesktop.c b/applets/wncklet/showdesktop.c index 78dd2778..d827f490 100644 --- a/applets/wncklet/showdesktop.c +++ b/applets/wncklet/showdesktop.c @@ -496,6 +496,7 @@ static void display_about_dialog(GtkAction* action, ShowDesktopData* sdd) gtk_show_about_dialog(GTK_WINDOW(sdd->applet), "program-name", _("Show Desktop Button"), + "title", _("About Show Desktop Button"), "authors", authors, "comments", _("This button lets you hide all windows and show the desktop."), "copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n" diff --git a/applets/wncklet/window-list.c b/applets/wncklet/window-list.c index 2a5ea4ba..3cdcd834 100644 --- a/applets/wncklet/window-list.c +++ b/applets/wncklet/window-list.c @@ -559,6 +559,7 @@ static void display_about_dialog(GtkAction* action, TasklistData* tasklist) gtk_show_about_dialog(GTK_WINDOW(tasklist->applet), "program-name", _("Window List"), + "title", _("About Window List"), "authors", authors, "comments", _("The Window List shows a list of all windows in a set of buttons and lets you browse them."), "copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n" diff --git a/applets/wncklet/window-menu.c b/applets/wncklet/window-menu.c index fc10cb2a..83790d47 100644 --- a/applets/wncklet/window-menu.c +++ b/applets/wncklet/window-menu.c @@ -74,6 +74,7 @@ static void window_menu_about(GtkAction* action, WindowMenu* window_menu) gtk_show_about_dialog(GTK_WINDOW(window_menu->applet), "program-name", _("Window Selector"), + "title", _("About Window Selector"), "authors", authors, "comments", _("The Window Selector shows a list of all windows in a menu and lets you browse them."), "copyright", _("Copyright \xc2\xa9 2000 Helix Code, Inc.\n" diff --git a/applets/wncklet/workspace-switcher.c b/applets/wncklet/workspace-switcher.c index d3475e0d..4089c85f 100644 --- a/applets/wncklet/workspace-switcher.c +++ b/applets/wncklet/workspace-switcher.c @@ -632,6 +632,7 @@ static void display_about_dialog(GtkAction* action, PagerData* pager) gtk_show_about_dialog(GTK_WINDOW(pager->applet), "program-name", _("Workspace Switcher"), + "title", _("About Workspace Switcher"), "authors", authors, "comments", _("The Workspace Switcher shows you a small version of your workspaces that lets you manage your windows."), "copyright", _("Copyright \xc2\xa9 2002 Red Hat, Inc.\n" -- cgit v1.2.1