From cf46fb7f03d6ab0e106fa1cbfbf180fbbb9a5b75 Mon Sep 17 00:00:00 2001 From: lukefromdc Date: Fri, 14 Jul 2017 02:36:39 -0400 Subject: libmate-panel-applet: Fix another potential source of applet crashes Properly initialize pattern, GNOME found this stopped applet crashes on bg change(though not the same crashes we just fixed) based on https://github.com/GNOME/gnome-panel/commit/88b9beeb8ab69072fe6912af33c620143d17b0a3 We could return a random value from panel_applet_get_pattern_from_pixmap(), and that was very nasty. --- libmate-panel-applet/mate-panel-applet.c | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libmate-panel-applet') diff --git a/libmate-panel-applet/mate-panel-applet.c b/libmate-panel-applet/mate-panel-applet.c index 3bbaab82..26646091 100644 --- a/libmate-panel-applet/mate-panel-applet.c +++ b/libmate-panel-applet/mate-panel-applet.c @@ -1329,6 +1329,8 @@ mate_panel_applet_get_pattern_from_pixmap (MatePanelApplet *applet, cairo_t *cr; cairo_pattern_t *pattern; + pattern = NULL; /*Properly initialize this, otherwise crashes can occur*/ + g_return_val_if_fail (PANEL_IS_APPLET (applet), NULL); if (!gtk_widget_get_realized (GTK_WIDGET (applet))) -- cgit v1.2.1