From 9d5b257f74d396ad4ed3d144185ab95b318b03b8 Mon Sep 17 00:00:00 2001 From: raveit65 Date: Tue, 24 Sep 2019 19:49:05 +0200 Subject: Use up_client_get_devices2() The previous code would have leaked all the UpDevice objects because no free function was set on the returned GPtrArray. With depending on upower-glib 0.99.8 get_devices() was deprecated and get_devices2() was introduced, we can simply switch to get_devices2() which does set a free function on the returned GPtrArray, stopping the leak. Inspired from: https://gitlab.gnome.org/GNOME/gnome-control-center/commit/c1210c5 see upower upstream: https://gitlab.freedesktop.org/upower/upower/commit/cb1071b --- src/gpm-engine.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'src/gpm-engine.c') diff --git a/src/gpm-engine.c b/src/gpm-engine.c index 4ffce52..248553c 100644 --- a/src/gpm-engine.c +++ b/src/gpm-engine.c @@ -864,7 +864,7 @@ gpm_engine_coldplug_idle_cb (GpmEngine *engine) gpm_engine_recalculate_state (engine); /* add to database */ - array = up_client_get_devices (engine->priv->client); + array = up_client_get_devices2 (engine->priv->client); for (i=0;ilen;i++) { device = g_ptr_array_index (array, i); gpm_engine_device_add (engine, device); -- cgit v1.2.1