From f8a009b91901e5cde98e97efb8469cabd7c7c368 Mon Sep 17 00:00:00 2001 From: Pablo Barciela Date: Wed, 5 Dec 2018 20:05:49 +0100 Subject: pluma-utils: Fix memory leak 'g_strconcat' needs to be freed --- pluma/pluma-utils.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/pluma/pluma-utils.c b/pluma/pluma-utils.c index c6e0a2e7..a7216955 100644 --- a/pluma/pluma-utils.c +++ b/pluma/pluma-utils.c @@ -1669,6 +1669,7 @@ GtkWidget * pluma_image_menu_item_new_from_pixbuf (GdkPixbuf *icon_pixbuf, const gchar *label_name) { + gchar *concat; GtkWidget *icon; GtkWidget *box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 6); @@ -1677,7 +1678,9 @@ pluma_image_menu_item_new_from_pixbuf (GdkPixbuf *icon_pixbuf, else icon = gtk_image_new (); - GtkWidget *label_menu = gtk_label_new (g_strconcat (label_name, " ", NULL)); + concat = g_strconcat (label_name, " ", NULL); + + GtkWidget *label_menu = gtk_label_new (concat); GtkWidget *menuitem = gtk_menu_item_new (); gtk_container_add (GTK_CONTAINER (box), icon); @@ -1686,5 +1689,7 @@ pluma_image_menu_item_new_from_pixbuf (GdkPixbuf *icon_pixbuf, gtk_container_add (GTK_CONTAINER (menuitem), box); gtk_widget_show_all (menuitem); + g_free (concat); + return menuitem; } -- cgit v1.2.1