summaryrefslogtreecommitdiff
path: root/src
AgeCommit message (Collapse)AuthorFilesLines
2024-02-26tabpopup: Stop spamming the ATs with label changes at startupHEADmasterColomban Wendling1-7/+9
2024-02-26tabpopup: Report the window as active to a11y when it's showingColomban Wendling1-1/+69
The switcher windows aren't actually "active" per GTK's meaning because they do not have actual keyboard focus, but they are controlled by the internal grabs so it's effectively the same as if they were active. Reporting them as such helps the ATs understanding what's going on. Fixes #771.
2024-02-16themes/eOS/meson.build: Install missing PNGsBobby Rong1-0/+2
Follow-up of 4a2a5dc092814bfe ("eOS theme: Add single button backgrounds") Without this fix these PNGs are installed when using autotools but not using meson.
2024-02-14workspace: ignore not_this_one if not in current workspaceLars R. Damerow1-2/+3
When the active workspace is changed, marco figures out which window should get focus by calling `focus_ancestor_or_top_window`. In some cases that call might include a window that should not get focus as `not_this_one`. When `not_this_one` refers to a window, the function will check to see if it has a parent, and if it does, it will ignore the new workspace's `mru_list` and will focus that parent window. However, it doesn't check to see if the parent window is actually on the new workspace. If the parent isn't on the new workspace, focusing it will drag it over, including the transient window that was supposed to be ignored. This isn't the result a user would likely expect, and is made more confusing by the parent window being minimized, stuck that way until the user switches to another workspace and back. This change makes `focus_ancestor_or_top_window` ignore the `not_this_one` window if it isn't on the new workspace's `mru_list`. Instead it will just search the new workspace's `mru_list` for a window to focus.
2023-10-19tabpopup: Use more contrasting background when not compositedColomban Wendling1-5/+16
When composited, the tab popup uses an OSD style which typically has a dark background, so we use a light background highlight color. However, when not composited the popup uses a light color and should thus use a dark highlight. This was done for the workspace popup, but not for the window one, leading to the highlight being hardly visible in several themes.
2023-10-14Allow applications to raise windows when raise_on_click is off.ns2-3/+2
This is Metacity commit 50358a95 ("Allow applications to raise windows when raise_on_click is off. Closes #445447.") applied to Marco without modification. It also includes a change to the GSettings key's description to remove the now obsolete warning on the raise-on-click key, & replaces it with an actually useful description. This is copied from the equivalent key in gsettings-desktop-schemas. Fixes: https://github.com/mate-desktop/marco/issues/762
2023-10-05replace deprecated gtk_image_menu_itemraveit651-2/+4
2023-08-17ui/tabpopup: likewise only enable compositing code if available.Mihai Moldovan3-2/+11
2023-08-17ui/frames: check that compositing is not only requested, but also available.Mihai Moldovan5-22/+33
Enabling code that is supposed to be used in compositing conditions is harmful if compositing is not actually available. Just checking the preference is not enough to make sure that compositing is available - the X server might be missing crucial extensions for compositing to work, which in turn correctly disables the internal compositor. The end result is graphical issues like black borders around windows in such situations. Make sure that compositing is both requested AND available to fix this bug.
2023-07-19Fix losing title of windows with a 3 or 4 bytes first characterColomban Wendling1-1/+1
Fixes #757.
2023-02-10Show correct window title when owned by superuser. Issue #749insaner1-1/+1
2023-01-18Add setting to raise windows on alt+tab popupsparkida5-3/+41
2023-01-14Test if XResQueryClientIds() is available before using it.Joakim Tjernlund1-0/+2
Needed for X2Go as it does not have XRES 1.2 extension.
2023-01-14Test Xres 1.2 is presentJoakim Tjernlund2-2/+13
Before using any Xres extension one must call XResQueryExtension() Also make sure Xres 1.2 is available as marco need XResQueryClientIds()
2023-01-14test return value from XResQueryClientIds()Joakim Tjernlund1-5/+6
2022-11-07replace _NET_WM_PID with XResGetClientPid (#741)Jan Novotný1-0/+46
window-props: use XResQueryClientIds to get pid _NET_WM_PID is unreliable! It can be faked or pid might be from different namespace. Ignore _NET_WM_PID and use XResQueryClientIds to get pid. https://gitlab.gnome.org/GNOME/metacity/-/commit/bcbe966511362a8eb8c8c64035ab160086c931f8
2022-11-07Always bring into foreground the previous window after closing oneBalazs Endresz1-1/+1
When opening and then closing certain applications the focus was correctly regained by the previous window but it wasn't brought into the foreground. To fix this we call meta_workspace_focus_default_window() for both NotifyDetailNone and NotifyPointerRoot. These two are always mentioned together in the X docs: https://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html Some programs will have NotifyDetailNone when closed, while others end up with NotifyPointerRoot.
2022-10-15window: do not disable fullscreen for dialogsAlberts Muktupāvels1-1/+2
fixes https://github.com/mate-desktop/marco/issues/735
2022-08-15ui: avoid 'g_object_unref (NULL)'rbuj1-3/+5
2022-04-07marco: Add cmdline option --no-keybindings for disabling all key bindings ↵Mike Gabriel1-0/+11
directly on WM startup. The marco WM is used in Arctica Greeter [1]. There recently has a security issue been detected where people could open applications via marco keybindings inside the greeter (display manager) session. . A work-around could be evoking marco-message after marco startup and disable all keybindings then. However, a more preferred fix is provided by this patch: start-up marco with keybindings disabled from the beginning.
2022-03-11boxes: fix build warning -Wstring-conversionrbuj1-28/+27
2022-03-11Fix some -Wfloat-conversion warningsrbuj9-66/+73
2022-02-19keybindings: fix build warning -Wbad-function-castrbuj1-11/+7
2022-02-13Remove TRUE, FALSE from if statementrbuj5-28/+22
2022-01-30theme-viewer: use GTK_STYLE_PROPERTY_FONTrbuj1-2/+6
2022-01-30theme: fix memory leakrbuj1-1/+0
2022-01-27Fix implicit conversion changes signedness: 'gboolean' to 'guint'rbuj7-29/+30
2022-01-27compositor-xrender: remove unrequired g_free because of g_new0rbuj1-5/+0
2022-01-27compositor-xrender: fix memory leakrbuj1-19/+33
2022-01-27build: fix meson buildrbuj1-1/+1
2022-01-26prefs: fix memory leakrbuj1-21/+27
2021-12-30main: Add short name for version optionrbuj1-1/+1
2021-12-11Remove whitespaces before #define, #ifdef, and #endifrbuj2-4/+4
2021-10-26fix code-formatting issue of previous commitraveit651-1/+1
- drop white spaces
2021-10-23Safeguard against calling gdk_x11_window_get_xid with a NULL GdkWindowrcaridade1451-2/+5
2021-07-09tabpopup: fix cairo surface leakFaidon Liambotis1-1/+7
Commit 6b05da5e49996a2101edfd703dd3f5d91011d726 introduced a Cairo surface leak, by calling gdk_cairo_surface_create_from_pixbuf() but then never freeing those surfaces with cairo_surface_destroy(). This manifested in leaking resources when switching between virtual desktops, as observed using xrestop ("Pxms" column), which made the desktop slow and ultimately unusable after a few weeks of uptime. Fixes #685
2021-06-07window: add support for _GNOME_WM_STRUT_AREAraveit657-13/+129
In addition to existing properties use also new _GNOME_WM_STRUT_AREA property that allows creating struts between monitors. https://mail.gnome.org/archives/wm-spec-list/2018-December/msg00000.html https://gitlab.freedesktop.org/xdg/xdg-specs/merge_requests/22 origin commit: https://gitlab.gnome.org/GNOME/metacity/commit/922de13
2021-06-07screen: add support for _GTK_WORKAREAS_Dnraveit652-0/+45
In addition to existing _NET_WORKAREA property set also new _GTK_WORKAREAS_Dn property where n is desktop number (between 0 and _NET_NUMBER_OF_DESKTOPS - 1). https://mail.gnome.org/archives/wm-spec-list/2018-December/msg00000.html https://gitlab.freedesktop.org/xdg/xdg-specs/merge_requests/22 origin commit: https://gitlab.gnome.org/GNOME/metacity/-/commit/3d8b03d
2021-06-04window: Do not render shadows on left/right tiled windowsMartin Wimpress3-0/+27
This pull request prevents shadows being rendered for left and right side titled windows. This behaviour is consistent with maximised windows, which also do not render shadows. The rationale for this change is so that when two windows are titled along side each other, it prevents central shadows bleeding into the touching points of the windows. metacity-theme-x.xml has provision to style left/right titled windows. This patch makes it possible to to create window themes that present clean side-by-side tiled windows.
2021-06-04iconcache: Use GDesktopAppInfo to find correct application iconsVictor Kareh5-7/+94
Some files do not report their application icons correctly in the window properties. This patch allows the marco UI to search for the corresponding .desktop file and render the icon in the desktop info on both the alt-tab popup and the window mini-icon.
2021-05-28window: Track window rectangle before corner tilingVictor Kareh1-4/+16
When corner-tiling a maximized window, we should keep track of the saved rectangle so that tiling does not reset our window size. Otherwise, untiling the previously maximized window will end up with an unmaximized full-size window, rather than the original window size.
2021-05-26window: Track window rectangle before tilingVictor Kareh1-1/+5
When tiling a maximized window, we should keep track of the saved rectangle so that tiling does not reset our window size. Otherwise, untiling the previously maximized window will end up with an unmaximized full-size window, rather than the original window size.
2021-04-30window: Only unmaximize when the window is already maximized.Zhiyi Zhang1-60/+64
When handling a ClientMessage event that removes _NET_WM_STATE_MAXIMIZED_HORZ or _NET_WM_STATE_MAXIMIZED_VERT from _NET_WM_STATE, marco always restore the window rectangle to the saved rectangle. So if an application window is already unmaximized and the application sends such a ClientMessage event, marco will reset the window rectangle regardless. EWMH doesn't specify what must be done when handling such events. It seems best to avoid restoring window rectangles like other window managers in this case. Fix a related bug: https://bugs.winehq.org/show_bug.cgi?id=50381 This revert a change introduced by 6219f8e8bcaeefb9185a3c3f5f20de4e2fa8f18f. Signed-off-by: Zhiyi Zhang <[email protected]>
2021-04-02window-props: g_memdup is dreprecated from glib 2.68rbuj1-2/+8
2021-03-29warning: declaration of a variable shadows a previous localrbuj3-9/+8
2021-03-18testasyncgetprop: Mismatching the argument type 'unsigned long'rbuj1-2/+2
and conversion specifier 'ld', reported by Apache NetBeans IDE
2021-03-18bell: Unused static function 'bell_flash_screen'rbuj1-0/+2
2021-03-13frames: Unused static functions 'get_client_region', 'get_frame_region'rbuj1-0/+2
2021-03-08compositor-xrender.c: Make sure tooltips are visible when the sourceMichael Webster1-0/+89
widget is close to the edge of the work area. See inline comments - as of 3.24 tooltip positioning is handled differently, and under certain conditions in hidpi, tooltips for the bottom panel applets can end up off the bottom of the work area. To reproduce, in hidpi, set the bottom panel to approximately 30px tall and try to activate a tooltip for an applet on that panel.
2021-03-08bell: missing include guardrbuj1-0/+5
generated by cgit v1.2.1 (git 2.18.0) at 2024-05-21 15:04:19 +0000