diff options
| author | Pablo Barciela <[email protected]> | 2019-03-17 02:24:41 +0100 |
|---|---|---|
| committer | Pablo Barciela <[email protected]> | 2019-03-17 16:26:00 +0100 |
| commit | 137fd477b4ac9b2ff1e7773fbe10675685b572a5 (patch) | |
| tree | a0764bb10390ed727d016b3432160c1a90a590c7 | |
| parent | 3233410b3a2c23ac6d05e9603787fce5b530e364 (diff) | |
| download | mate-desktop-137fd477b4ac9b2ff1e7773fbe10675685b572a5.tar.bz2 mate-desktop-137fd477b4ac9b2ff1e7773fbe10675685b572a5.tar.xz | |
[Security] Use 'g_strlcpy' instead of 'strcpy'
Fixes Clang static analyzer warnings:
mate-rr-config.c:549:3: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy (output->priv->vendor, "???");
^~~~~~
mate-desktop-item.c:2118:2: warning: Call to function 'strcpy' is insecure as it does not provide bounding of the memory buffer. Replace unbounded copy functions with analogous functions that support length arguments such as 'strlcpy'. CWE-119
strcpy (the_exec, exec);
^~~~~~
| -rw-r--r-- | libmate-desktop/mate-desktop-item.c | 2 | ||||
| -rw-r--r-- | libmate-desktop/mate-rr-config.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/libmate-desktop/mate-desktop-item.c b/libmate-desktop/mate-desktop-item.c index 7b96385..f7b1154 100644 --- a/libmate-desktop/mate-desktop-item.c +++ b/libmate-desktop/mate-desktop-item.c @@ -2115,7 +2115,7 @@ mate_desktop_item_launch_on_screen_with_env ( /* make a new copy and get rid of spaces */ the_exec = g_alloca (strlen (exec) + 1); - strcpy (the_exec, exec); + g_strlcpy (the_exec, exec, strlen (exec) + 1); if ( ! strip_the_amp (the_exec)) { g_set_error (error, diff --git a/libmate-desktop/mate-rr-config.c b/libmate-desktop/mate-rr-config.c index 6048db0..09d2b8f 100644 --- a/libmate-desktop/mate-rr-config.c +++ b/libmate-desktop/mate-rr-config.c @@ -546,7 +546,7 @@ mate_rr_config_load_current (MateRRConfig *config, GError **error) } else { - strcpy (output->priv->vendor, "???"); + g_strlcpy (output->priv->vendor, "???", sizeof (output->priv->vendor)); output->priv->product = 0; output->priv->serial = 0; } |