diff options
| author | Colomban Wendling <[email protected]> | 2024-02-28 22:21:06 +0100 |
|---|---|---|
| committer | raveit65 <[email protected]> | 2024-02-29 13:15:24 +0100 |
| commit | 44f5c03bd177e5eec9c4c31104c1ee358e9b3a33 (patch) | |
| tree | 1d749e903a7d314e7df819d8ef8bd9e842aef9d9 | |
| parent | bdbeed74419708dc35e23ceecc10f166abfddb78 (diff) | |
| download | mate-desktop-44f5c03bd177e5eec9c4c31104c1ee358e9b3a33.tar.bz2 mate-desktop-44f5c03bd177e5eec9c4c31104c1ee358e9b3a33.tar.xz | |
MateImageMenuItem: Remove unnecessary label field
This was used in GtkImageMenuItem to support stock items, but this is a
deprecated feature that didn't make it to MateImageMenuItem. Now, this
is entirely unused, and just leads to glue code maintaining an unused
local copy of the label, effectively wasting a little bit of memory and
adding complexity.
Just drop all references to it, without any functional difference.
| -rw-r--r-- | libmate-desktop/mate-image-menu-item.c | 39 |
1 files changed, 0 insertions, 39 deletions
diff --git a/libmate-desktop/mate-image-menu-item.c b/libmate-desktop/mate-image-menu-item.c index 85bc2f3..27708e6 100644 --- a/libmate-desktop/mate-image-menu-item.c +++ b/libmate-desktop/mate-image-menu-item.c @@ -26,7 +26,6 @@ struct _MateImageMenuItem { GtkMenuItem menu_item; GtkWidget *image; - gchar *label; }; enum { @@ -323,40 +322,6 @@ mate_image_menu_item_toggle_size_request (GtkMenuItem *menu_item, } static void -mate_image_menu_item_set_label (GtkMenuItem *menu_item, - const gchar *label) -{ - MateImageMenuItem *image_menu_item = MATE_IMAGE_MENU_ITEM (menu_item); - - if (image_menu_item->label != label) - { - g_free (image_menu_item->label); - image_menu_item->label = g_strdup (label); - GTK_MENU_ITEM_CLASS (mate_image_menu_item_parent_class)->set_label (menu_item, label); - g_object_notify (G_OBJECT (menu_item), "label"); - } -} - -static const gchar * -mate_image_menu_item_get_label (GtkMenuItem *menu_item) -{ - MateImageMenuItem *image_menu_item = MATE_IMAGE_MENU_ITEM (menu_item); - - return image_menu_item->label; -} - -static void -mate_image_menu_item_finalize (GObject *object) -{ - MateImageMenuItem *image_menu_item = MATE_IMAGE_MENU_ITEM (object); - - g_free (image_menu_item->label); - image_menu_item->label = NULL; - - G_OBJECT_CLASS (mate_image_menu_item_parent_class)->finalize (object); -} - -static void mate_image_menu_item_set_property (GObject *object, guint prop_id, const GValue *value, @@ -414,10 +379,7 @@ mate_image_menu_item_class_init (MateImageMenuItemClass *class) container_class->remove = mate_image_menu_item_remove; menu_item_class->toggle_size_request = mate_image_menu_item_toggle_size_request; - menu_item_class->set_label = mate_image_menu_item_set_label; - menu_item_class->get_label = mate_image_menu_item_get_label; - gobject_class->finalize = mate_image_menu_item_finalize; gobject_class->set_property = mate_image_menu_item_set_property; gobject_class->get_property = mate_image_menu_item_get_property; @@ -440,7 +402,6 @@ static void mate_image_menu_item_init (MateImageMenuItem *image_menu_item) { image_menu_item->image = NULL; - image_menu_item->label = NULL; } /** |