summaryrefslogtreecommitdiff
path: root/backend/pdf
diff options
context:
space:
mode:
authorColomban Wendling <[email protected]>2018-09-04 14:22:04 +0200
committerraveit65 <[email protected]>2018-10-20 18:06:52 +0200
commita7d0b8dfb7993a7f8938c4a89c1df68001bfd456 (patch)
tree9efa6e822c0739b6f46e724b1164003fbfd15446 /backend/pdf
parentf4a771536e9454c876c1cd27be2bbf90495ac6f0 (diff)
downloadatril-a7d0b8dfb7993a7f8938c4a89c1df68001bfd456.tar.bz2
atril-a7d0b8dfb7993a7f8938c4a89c1df68001bfd456.tar.xz
EvView: Fix cursor movement when logical and visual line order differs
Make sure not to move the caret in the wrong direction when restoring the visual line X offset, in case the visual and logical order is slightly different. The algorithm used to move the cursor on the next line and restore the X position across lines works as follows: 1. Move `cursor_offset` to the next line by incrementing it until reaching a line break; 2. Find the Y coordinate corresponding to the new cursor_offset; 3. Find the text closest to the new Y coordinate and the previous X coordinate. 4. Move cursor_offset to the text at this new (X, Y) location. The issue lies in step 3, which can find a position on a different line than expected in case several lines have a nearly the same Y position. Evince references: * https://gitlab.gnome.org/GNOME/evince/issues/889 * https://gitlab.gnome.org/GNOME/evince/merge_requests/81 * https://gitlab.gnome.org/GNOME/evince/commit/dddd98b4c7922e2906bba6a31afa07837ae6c39c
Diffstat (limited to 'backend/pdf')
0 files changed, 0 insertions, 0 deletions