summaryrefslogtreecommitdiff
path: root/libview
diff options
context:
space:
mode:
authorGermán Poo-Caamaño <[email protected]>2016-02-18 16:44:40 -0800
committerraveit65 <[email protected]>2018-03-16 16:18:47 +0100
commit005d88500dc47f285d83fc5451cd5cea0e8c14a3 (patch)
tree7bdf897e3dddb511e685ed22ce7bdf4d7fac21e0 /libview
parent83efd99baaf6e77d12b85010972c33d450e82014 (diff)
downloadatril-005d88500dc47f285d83fc5451cd5cea0e8c14a3.tar.bz2
atril-005d88500dc47f285d83fc5451cd5cea0e8c14a3.tar.xz
Check legal boundaries of accessible pages
Fixes https://github.com/mate-desktop/atril/issues/302 Keep the accessible view end page under the limits of the document. Sometimes when a document is reloaded, it may have less pages making the end page higher than the actual number of pages. Fix end_page reset after reload a page When a document is reloaded, and the accessible end_page is higher than the number of pages, it must be re-initialized to the number of pages minus one because it refers to elements in an array. Fix https://bugzilla.gnome.org/show_bug.cgi?id=735744 origin commits: https://git.gnome.org/browse/evince/commit/?id=feff531 https://git.gnome.org/browse/evince/commit/?id=e6e0d29
Diffstat (limited to 'libview')
-rw-r--r--libview/ev-view-accessible.c7
1 files changed, 7 insertions, 0 deletions
diff --git a/libview/ev-view-accessible.c b/libview/ev-view-accessible.c
index d48c97c7..8274aced 100644
--- a/libview/ev-view-accessible.c
+++ b/libview/ev-view-accessible.c
@@ -380,6 +380,13 @@ initialize_children (EvViewAccessible *self)
child = ev_page_accessible_new (self, i);
g_ptr_array_add (self->priv->children, child);
}
+ /* When a document is reloaded, it may have less pages.
+ * We need to update the end page accordingly to avoid
+ * invalid access to self->priv->children
+ * See https://bugzilla.gnome.org/show_bug.cgi?id=735744
+ */
+ if (self->priv->end_page >= n_pages)
+ self->priv->end_page = n_pages - 1;
}
static void