| Age | Commit message (Collapse) | Author | Files | Lines |
|---|
|
Once epub support has been implemented, atril crashes with all epubs.
Backtrace for 1.10.2+repack1-1 (Debian Stretch):
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd26d2700 (LWP 22276)]
0x0000000000000000 in ?? ()
(gdb) bt
#0 0x0000000000000000 in ()
#1 0x00007ffff755914e in ev_job_page_data_run (job=0x9e3850 [EvJobPageData]) at ev-jobs.c:762
#2 0x00007ffff755a85a in ev_job_thread_proxy (job=0x9e3850 [EvJobPageData]) at ev-job-scheduler.c:184
#3 0x00007ffff755a85a in ev_job_thread_proxy (data=<optimized out>) at ev-job-scheduler.c:217
#4 0x00007ffff14e1955 in g_thread_proxy (data=0x7fff84002280) at /build/glib2.0-VKSJTv/glib2.0-2.46.1/./glib/gthread.c:778
#5 0x00007ffff08690a4 in start_thread (arg=0x7fffd26d2700) at pthread_create.c:309
#6 0x00007ffff059e06d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)
It turns out it couldn't really work since one function pointer is
uninitialized. But nobody complained. Thus I investigated it further,
why it fails only for me. First, I tried a gtk3 version. And it works
properly, but the broken code is not hit at all. Due to the threaded
design, it was harder to figure out, why. Here is the code path:
-->
ev_window_load_job_cb (shell/ev-window.c) -->
ev_document_model_set_document (libview/ev-document-model.c) -->
ev_view_document_changed_cb (libview/ev-view.c) -->
setup_caches (libview/ev-view.c) -->
if (ev_view_is_a11y_enabled (view)) {
ev_page_cache_set_flags();
}
ev_page_cache_set_flags (libview/ev-page-cache.c) -->
ev_page_cache_set_page_range (libview/ev-page-cache.c) -->
data->job = ev_job_page_data_new (cache->document, i, flags);
...
ev_job_scheduler_push_job (data->job, EV_JOB_PRIORITY_NONE);
...
-->
ev_job_thread_proxy (libview/ev-job-scheduler.c) -->
ev_job_page_data_run (libview/ev-jobs.c) -->
ev_document_links_get_links (libdocument/ev-document-links.c) -->
EvDocumentLinksInterface *iface = EV_DOCUMENT_LINKS_GET_IFACE (document_links);
return iface->get_links (document_links, page);
(get_links == NULL) --> crash
As one can see it depends on the accessibility. And it is enabled on my
box.
It can be reproduced with
gsettings set org.mate.interface accessibility true
(mate logout and login)
Why the enabled accessibility is not discovered by the gtk3 version is
another story. My question [1] was motivated by this.
[1] https://github.com/mate-desktop/atril/issues/171
|
|
|
|
|
|
dvi: fix crash due to regression
|
|
fixes https://github.com/mate-desktop/atril/issues/164
regression has been introduced in https://github.com/mate-desktop/atril/commit/94dcb761b95ee54ef1f1512d59721932d75ffb7f
|
|
|
|
|
|
|
|
|
|
The dependency is not really needed; depending on GTK+ should be enough
to guarantee the presence of a spec-compliant icon theme.
Atril ships all needed icons as a fallback if another theme is used.
|
|
|
|
|
|
epub: drop embedded MathJax in favor of using distro-packaged one
|
|
closes https://github.com/mate-desktop/atril/issues/158
|
|
intltool 0.5.1 has support for gsettings schemas.
|
|
|
|
some minor cleanup (mostly from upstream)
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It's been a no-op for a long time.
See https://mail.gnome.org/archives/commits-list/2011-December/msg00681.html for example.
|
|
Thanks to @monsta for reporting the problem.
|
|
that logic error was completely ridiculous
|
|
partially taken from
https://git.gnome.org/browse/evince/commit/?id=26c0109e67aa02fb0e58b2580a6df41363c78bd5
|
|
from
https://git.gnome.org/browse/evince/commit/?id=a11159d1b8ea994271b26b5c60083c0b07c1722d
|
|
from
https://git.gnome.org/browse/evince/commit/?id=79b9e1e0d6efa05a875e0db5407c9b760f3939d4
|
|
from
https://git.gnome.org/browse/evince/commit/?id=1c1fe3110118254e3e6ab4661517697d91e99ff8
|
|
|
|
Fixes bug #628378.
|
|
|
|
require libgxps >= 0.2.0
|
|
code changes from https://github.com/GNOME/evince/commit/740263e84f812e069c25d32e6fbf40bec4c061e2
are already in, but the version bump isn't. fixed that.
|
|
|
|
|
|
|
|
|
|
We relided on default values to store settings in metadata, so that
settings that don't change are not saved in metdata. Now that default
settings can change, that approach doesn't work, so we need o save all
settings in metadata.
evince commit: 720eebf9f0dd2e6a2765f6117f3bce9d7c74fcfa
evince bug: https://bugzilla.gnome.org/show_bug.cgi?id=639003
|
|
|
|
|
|
fixes https://github.com/mate-desktop/atril/issues/136
|
|
A lot of distro's are dropping webkit2gtk-3.0 and 4.0 works
just as well.
Also use have_webkit variable in the PKG_CONFIG checks.
|
|
"thanks" to debian guys for removing 3.0 from testing repo
|
|
|
|
|
|
|
|
|
|
|
