Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Once epub support has been implemented, atril crashes with all epubs.
Backtrace for 1.10.2+repack1-1 (Debian Stretch):
Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fffd26d2700 (LWP 22276)]
0x0000000000000000 in ?? ()
(gdb) bt
#0 0x0000000000000000 in ()
#1 0x00007ffff755914e in ev_job_page_data_run (job=0x9e3850 [EvJobPageData]) at ev-jobs.c:762
#2 0x00007ffff755a85a in ev_job_thread_proxy (job=0x9e3850 [EvJobPageData]) at ev-job-scheduler.c:184
#3 0x00007ffff755a85a in ev_job_thread_proxy (data=<optimized out>) at ev-job-scheduler.c:217
#4 0x00007ffff14e1955 in g_thread_proxy (data=0x7fff84002280) at /build/glib2.0-VKSJTv/glib2.0-2.46.1/./glib/gthread.c:778
#5 0x00007ffff08690a4 in start_thread (arg=0x7fffd26d2700) at pthread_create.c:309
#6 0x00007ffff059e06d in clone () at ../sysdeps/unix/sysv/linux/x86_64/clone.S:111
(gdb)
It turns out it couldn't really work since one function pointer is
uninitialized. But nobody complained. Thus I investigated it further,
why it fails only for me. First, I tried a gtk3 version. And it works
properly, but the broken code is not hit at all. Due to the threaded
design, it was harder to figure out, why. Here is the code path:
-->
ev_window_load_job_cb (shell/ev-window.c) -->
ev_document_model_set_document (libview/ev-document-model.c) -->
ev_view_document_changed_cb (libview/ev-view.c) -->
setup_caches (libview/ev-view.c) -->
if (ev_view_is_a11y_enabled (view)) {
ev_page_cache_set_flags();
}
ev_page_cache_set_flags (libview/ev-page-cache.c) -->
ev_page_cache_set_page_range (libview/ev-page-cache.c) -->
data->job = ev_job_page_data_new (cache->document, i, flags);
...
ev_job_scheduler_push_job (data->job, EV_JOB_PRIORITY_NONE);
...
-->
ev_job_thread_proxy (libview/ev-job-scheduler.c) -->
ev_job_page_data_run (libview/ev-jobs.c) -->
ev_document_links_get_links (libdocument/ev-document-links.c) -->
EvDocumentLinksInterface *iface = EV_DOCUMENT_LINKS_GET_IFACE (document_links);
return iface->get_links (document_links, page);
(get_links == NULL) --> crash
As one can see it depends on the accessibility. And it is enabled on my
box.
It can be reproduced with
gsettings set org.mate.interface accessibility true
(mate logout and login)
Why the enabled accessibility is not discovered by the gtk3 version is
another story. My question [1] was motivated by this.
[1] https://github.com/mate-desktop/atril/issues/171
|
|
fixes https://github.com/mate-desktop/atril/issues/164
regression has been introduced in https://github.com/mate-desktop/atril/commit/94dcb761b95ee54ef1f1512d59721932d75ffb7f
|
|
closes https://github.com/mate-desktop/atril/issues/158
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Fixes bug #628378.
|
|
Closes https://github.com/mate-desktop/atril/pull/132
|
|
because backends manager frees that var already.
actually, adding ev_backends_manager_get_backends_dir to the public
API was still careless. backends manager and epub document jobs seem
to be in the different threads, and there's no mutex seen anywhere
around. luckily, what we have here is just a reading of a variable
that has been assigned only once (in backends_dir function), so it's
not as catastrophic as it would be if it was e.g. concurrent writing
without a mutex.
Closes https://github.com/mate-desktop/atril/pull/124
|
|
bsdtar is able to extract all supported comics archive format.
|
|
Thanks to tibbi <[email protected]> for spotting them.
|
|
|
|
This allows overlooking errors and processing malformed tiff files.
Taken from evince commit: 2f2b0dbbf86b3b0def86c78e27f7e530e4041308
From: Juanjo Marín <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=644806
|
|
Taken from evince commit: efadec4ffcdde3373f6f4ca0eaac98dc963c4fd5
From: Scott Reeves <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=643882
|
|
Taken from evince commit: 019c902c1e873aa465e877ae700f36eb94d04c45
From: Hib Eris <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=644928
|
|
Taken from evince commit: 439c5070022eab6cef7266aab47f978058012c72
From: Vincent Untz <[email protected]>
Gnome bug: https://bugzilla.gnome.org/show_bug.cgi?id=640923
|
|
Taken from evince commit: 0a6e8aabcc46d47b5d84e5414cd0e07d57ef171b
From: José Aliste <[email protected]>
|
|
And remove all unneeded #ifdefs
Based on evince commit: e214c8e963fc4224c5ee54b8b9f0d23cb07019d7
From: Carlos Garcia Campos <[email protected]>
|
|
Taken from evince commit: d9458f7a82b916efcc7bebf576388ef9bf2e8e45
From: danigm <[email protected]>
|
|
See CVE-2010-2640, CVE-2010-2641, CVE-2010-2642 and CVE-2010-2643.
Taken from evince commit: d4139205b010ed06310d14284e63114e88ec6de2
From: José Aliste <[email protected]>
|
|
Taken from evince commit: d68a55580d2e63c0587b11580dfde219d5ef56fb
From: Christian Persch <[email protected]>
|
|
We can use cairo_image_surface_create() and let cairo/pixman handle the
memory.
Taken from evince commit: cb697193fec59edfcefe503c390592851a79dd6b
From: Carlos Garcia Campos <[email protected]>
|
|
Taken from evince commit: 0891eb8e130103c2abe4b48b7f2b5fa42d0fdaa0
From: Carlos Rendon <[email protected]>
|
|
This way we can mark the surface dirty when all pixels have been
modified.
Taken from evince commit: c565f15e696db4b4cf983cdddf1e1ab273d547dc
From: Carlos Garcia Campos <[email protected]>
|
|
Taken from evince commit: 4f13859ce0aa0918a5c6a0a24686d97ffd7d2ee2
From: Carlos Garcia Campos <[email protected]>
|
|
Taken from evince commit: 42fdab936eef083c81a9e6798ffea2c4bfab3842
From: Carlos Garcia Campos <[email protected]>
|
|
Taken from evince commit: c4923eca28c74fad47acdd1ebaafff206107f721
From: Carlos Garcia Campos <[email protected]>
|
|
Linearized PopplerDocument property is now boolean rather than string.
Based on evince commit: f77e6cf4fd7fef49ac91d8c62b6a9a993529adb8
From: Carlos Garcia Campos <[email protected]>
|
|
Based on evince commit: e39bde3f3b8ce3c111c27f7aa6b384c7a5f98672
From: Carlos Garcia Campos <[email protected]>
|
|
se g_object_set_data instead, to attach the backend object to the
evince layer.
Based on evince commit: 08993c59369086fa8916236f580438d656ccb8f7
From: Carlos Garcia Campos <[email protected]>
|
|
|
|
|
|
|
|
I always thought all ePub documents had either a traditional ncx or an epub3 nav. Now as it turns out,
sometimes neither of these are present. Fixed.
|
|
Toc may include links with strings escaped for URI format. We needed to un-escape them.
|
|
|
|
Closes https://github.com/mate-desktop/atril/pull/99
|
|
|
|
|
|
Closes https://github.com/mate-desktop/atril/issues/30
|
|
Based on evince commit by Carlos Garcia Campos <[email protected]>
Url: https://git.gnome.org/browse/evince/commit/?id=bf90f90e0af99bbfdd20e6d21fd228c05cffae51
Url: https://git.gnome.org/browse/evince/commit/?id=76151be92239ed5f491cb26c87a2328b670e9f64
|
|
The Mathjax files will be installed to $(backenddir)/epub/MathJax
This was as small as the install got.
|
|
I came across a document that didn't have an old style toc, and thus the all accomodating navsheet support.
Also fixed some mistakes here and there.
|
|
Tweaked the way we handle inverted colors so that documents with no "day" class tag fr their primary stylesheets can revert back to these stylesheets when prompted, the inverted colors run into problems on document reload, this needs to be fixed.
Other than that I removed the webkit flags and libs from shell/Makefile.am , they were there because at a very early stage of the project I had decided to use a webkit_web_view directly, then I ended up extending and using it in libview.
|
|
Added the capability to view and epub document with inverted colors, yet to test for documents where we write the stylesheet, although the code is there.
|