summaryrefslogtreecommitdiff
path: root/libcaja-private
diff options
context:
space:
mode:
authorPablo Barciela <[email protected]>2019-03-28 04:44:36 +0100
committerZenWalker <[email protected]>2019-04-03 12:42:41 +0200
commitcdd9cd5056fd9281f6e5f83cab40e92c29479f0a (patch)
tree66a5e024f904309af52cf79d89d8d39c255201ba /libcaja-private
parentd98150680d446e641b5c9ba285b51e5ece45703b (diff)
downloadcaja-cdd9cd5056fd9281f6e5f83cab40e92c29479f0a.tar.bz2
caja-cdd9cd5056fd9281f6e5f83cab40e92c29479f0a.tar.xz
caja-open-with-dialog: make sure there is error before showing it
Fixes Clang static analyzer warning: caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message); ^~~~~~~~~~~~~~
Diffstat (limited to 'libcaja-private')
-rw-r--r--libcaja-private/caja-open-with-dialog.c7
1 files changed, 5 insertions, 2 deletions
diff --git a/libcaja-private/caja-open-with-dialog.c b/libcaja-private/caja-open-with-dialog.c
index 45996fdf..e42a8fbd 100644
--- a/libcaja-private/caja-open-with-dialog.c
+++ b/libcaja-private/caja-open-with-dialog.c
@@ -249,12 +249,15 @@ add_or_find_application (CajaOpenWithDialog *dialog)
if (app == NULL)
{
- message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message);
+ message = g_strdup_printf (_("Could not add application to the application database: %s"), error ? error->message : _("Unknown error"));
eel_show_error_dialog (_("Could not add application"),
message,
GTK_WINDOW (dialog));
g_free (message);
- g_error_free (error);
+
+ if (error)
+ g_error_free (error);
+
return NULL;
}