summaryrefslogtreecommitdiff
path: root/src/caja-freedesktop-dbus.c
diff options
context:
space:
mode:
authorBoris Egorov <[email protected]>2014-09-24 13:05:49 +0700
committerStefano Karapetsas <[email protected]>2014-09-30 07:56:47 +0200
commit96fb1c780e7cebaf9fe6c4f48c8ddc5127d297d4 (patch)
tree1d57259f425dd71d75eb66ccdfa2ffef3211d433 /src/caja-freedesktop-dbus.c
parent95eb87d34c69dc7d2596e2a4344898630e63c5bb (diff)
downloadcaja-96fb1c780e7cebaf9fe6c4f48c8ddc5127d297d4.tar.bz2
caja-96fb1c780e7cebaf9fe6c4f48c8ddc5127d297d4.tar.xz
libcaja-private: fix always-false expressions
CppCheck detected a few 'always false' expressions in caja. First two definitely appeareed due to copy-paste (mime-types comparison). It would be nice to move x_content_type's and corresponding greetings to some table (array of structs), wouldn't it? The last one looks like copy-paste problem too. There were two identical blocks of code in move_file_prepare() checking conflict type. BTW, there is exactly the same code in the same file inside copy_move_file(). According to DRY, it would be nice to move this code to its own function.
Diffstat (limited to 'src/caja-freedesktop-dbus.c')
0 files changed, 0 insertions, 0 deletions