Age | Commit message (Collapse) | Author | Files | Lines |
|
Fix the gsignal warnings on window-close
based on https://github.com/mate-desktop/atril/commit/fda33fbeedc0aab64d9479850047d0817d0b38be
"Check if handler_id is connected before disconnect" from Atril
Also Fix "Source ID XXX was not found..." warnings on closing Caja
These three gsources are already gone when Caja exits, their ID's still exist but they cannot be found to remove. The warnings indicate double removal so this code block is just a source of errors. Leave it in place but commented out for now.
|
|
|
|
Apply https://github.com/itzexor/nemo/commit/2c60a3edaef10e9ef331740d55d3c45dd366c5db
window: remove custom get_preferred_width/height implementation
We already take care of the default size when we create the window, and these only break assumptions of the default GtkWindow's handlers.
in turn from
https://github.com/GNOME/nautilus/commit/da06dfc438e578405d616c48e8e3809d37c908bb
Nautilus commit is from Feb 17, 2014 prior to release of GTK 3.14. Could not build against GTK 3.14 over GTK 3.22 system due to mate-desktop errors but should work as Nautilus used it with 3.14. Test builds with GTK 3.16 and 3.22 worked fine, no issues with saved or command line geometry
|
|
|
|
|
|
|
|
|
|
|
|
Replace size request code with padding code borrowed from Nemo. For some reason gtk_widget_set_margin_start(or end) does not throw GTK warnings when called on GTK_WIDGET(button_date->label) while gtk_widget_set_size_request does throw warnings. Neither generates a build warning.
|
|
Stop the "allocating size of GtkButton <xxxx> without calling gtk_widget get preferred width/height()" warnings from caja-pathbar's slider buttons
|
|
Fix gtk_widget_create_pango_layout: assertion 'GTK_IS_WIDGET (widget)' failed warning and those descending from it. This does NOT fix the gtk_widget_set_size_request: assertion 'GTK_IS_WIDGET (widget)' failed, which occurs because recent GTK3 versions warn that button_data is not a GtkWidget but still succeed in setting the size. Since GTK 3.22 will be the LAST version of GTK3 this won't break until GTK4 if ever.
Taking this out caused the pathbar buttons to jump on bold text so it had to be retained
|
|
The button underallocation warnings came from pathbar sliders picking up padding from themes, then being forced to render to a smaller size in the code.
The GTK_ICON_LOOKUP_GENERIC_FALLBACK warnings came from the sidebar icons, this flag is now a source of errors. Unfortunately NULL does not work, so set GTK_ICON_LOOKUP_FORCE_SIZE, which does not create errors and ensures the icon size we actually want in the sidebar is used anyway.
Stops all but two of the warnings listed in
https://github.com/mate-desktop/caja/issues/561
|
|
Duplicate define of "CAJA_ACTION_UP_ACCEL" removed.
|
|
|
|
|
|
docs are still far from perfect, but most build warnings are gone
|
|
|
|
taken from:
https://git.gnome.org/browse/nautilus/commit/?id=050d031250970b55bbb0e4a58dfaded84c89b354
https://git.gnome.org/browse/nautilus/commit/?id=b2ee410dc353a871992eebcbdbb4399daa59d57b
|
|
|
|
|
|
|
|
|
|
|
|
Apply https://gist.github.com/raveit65/51b40a20f8836562369fc155a828edc4 to add a "finalize" function to the desktop window and stop background-change crashes after turning icons off-or off and back on.
Also match tab styling to that in rest of file, the one difference here from the patchfile.
|
|
Composited case still requires desktop, desktop window to be set transparent. Changes in last commit only affected noncomposited case
|
|
This reverts commit 8d658fa4f3790972c38e04df23eaa7b88b5066d8.
No need of this after latest commit.
|
|
Apply Alberts Muktupāvels' https://bugzilla.gnome.org/attachment.cgi?id=332444&action=diff to Caja, it just plain works.
Remove previous fallback background code.
Add GTK 3.21 selectors missed in caja_desktop_window_class_init, clean up a couple tabs
|
|
|
|
|
|
The selectors to hold the desktop transparent in GTK 3.21 or later builds seem to be ignored in GTK 3.20 or older builds where Caja draws the desktop. Ideally some makefile work and two raw files would apply this only in GTK 3.21 and later builds
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Stop the properties window from ballooning to full screen height when built and run with GTK 3.21/22. In GTK 3.21 the "emblems" tab's scrolled window will expand to the entire height of the screen attempting to accomodate all icons unless this is explicitly limited using the new command gtk_scrolled_window_set_max_content_height().
Unfortunately that command is GTK 3.21 and later only, so this forces GTK 3.21 builds to be run only with Gtk 3.21 and later. Thus this is put behind a GTK 3.21 selector and packages built from it must depend on GTK 3.21 and later. Fortunately no distro is going to ship any file manager built with newer GTK 3 than they ship. A GTK 3.21 build of this will actually open in 3.20 but hit the undefined symbol and crash if you select "properties" on any item, exactly as I would expect it to so.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
taken from:
https://git.gnome.org/browse/nautilus/commit/src?id=6f6bfde
|
|
taken from:
https://git.gnome.org/browse/nautilus/commit/src?id=00257f2
|
|
taken from:
https://git.gnome.org/browse/nautilus/patch/src?id=4b2753d
|
|
This will give it more horizontal spacing, like we do for text buttons
in main toolbars.
taken from:
https://git.gnome.org/browse/nautilus/commit/src?id=fe45b63
|
|
We want the down slider button to be linked visually to the rest of the
pathbar.
https://bugzilla.gnome.org/show_bug.cgi?id=680916
inspired from:
https://git.gnome.org/browse/nautilus/commit/src?id=71db3de
|
|
use instead a symbolic icon
taken from:
https://git.gnome.org/browse/nautilus/commit/src?id=25c898b
|