summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-07-23preferences: Render media icons as cairo_surfaceVictor Kareh1-8/+9
2019-07-23Replace gdkpixbuf with cairo_surfaces in a few more placesVictor Kareh6-63/+35
2019-07-23sidebar: Render info icon as vectorVictor Kareh1-16/+17
2019-07-23caja-location-dialog: Fix 'cppcheck' and 'clang' warningsPablo Barciela1-5/+5
Fixes 'cppcheck' warnings: [src/caja-location-dialog.c:229] -> [src/caja-location-dialog.c:237]: (warning) Either the condition 'window' is redundant or there is possible null pointer dereference: window. [src/caja-location-dialog.c:224]: (style) The scope of the variable 'formatted_location' can be reduced. Fixes Clang static analyzer warning: caja-location-dialog.c:237:12: warning: Access to field 'details' results in a dereference of a null pointer (loaded from variable 'window') slot = window->details->active_pane->active_slot; ^~~~~~~~~~~~~~~
2019-07-23eel-editable-label: Use 'memmove' instead of 'memcpy'Pablo Barciela1-1/+1
Fixes 'flawfinder' warning: (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
2019-07-23caja-file: avoid shifting signed 32-bit value by 31 bitsPablo Barciela1-1/+1
Fixes cppcheck warnings: [libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
2019-07-23caja-icon-canvas-item: initialize variable 'scale'Pablo Barciela1-1/+1
Fixes cppcheck warning: [libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
2019-07-23caja-application: avoid NULL inside 'g_object_unref'Pablo Barciela1-3/+4
Fixes Clang static analyzer warning: caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference g_object_unref (files[idx]); ^~~~~~~~~~
2019-07-23fm-desktop-icon-view: remove dead codePablo Barciela1-11/+1
Fixes Clang static analyzer warnings: fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-23caja-file-operations: make sure 'error' isn't NULLPablo Barciela1-2/+2
Fixes Clang static analyzer warnings: caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error') if (error->code != G_IO_ERROR_FAILED_HANDLED) { ^~~~~~~~~~~ caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') details = error->message; ^~~~~~~~~~~~~~
2019-07-23caja-open-with-dialog: make sure there is error before showing itPablo Barciela1-2/+5
Fixes Clang static analyzer warning: caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message); ^~~~~~~~~~~~~~
2019-07-23caja-sidebar-title: avoid 'NULL' inside 'setup_gc_with_fg'Pablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-sidebar-title.c:233:49: warning: Dereference of null pointer (loaded from variable 'color') sidebar_title->details->label_colors[idx] = *color; ^~~~~~
2019-07-23caja-autorun: avoid NULL in 'memcpy'Pablo Barciela1-1/+4
Fixes Clang static analyzer warning: caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (r, v, len * sizeof (char *)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-23eel-editable-label: call argument with initialized valuePablo Barciela1-2/+2
Fixes Clang static analyzer warning: eel-editable-label.c:2624:9: warning: 2nd function call argument is an uninitialized value if (pango_layout_line_x_to_index (line, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-07-23configure.ac: fix portability issue with testDavid H. Gutteridge1-1/+1
"test ... ==" isn't a portable expression, change to POSIX "=".
2019-07-23eel-canvas: Fix warning: Undefined or garbage value returned to callerPablo Barciela1-1/+1
Fixes Clang static analyzer warning: eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller return item; ^~~~~~~~~~~
2019-07-23caja-window: Fix garbage valuePablo Barciela1-1/+2
Fixes Clang static analyzer warning: caja-window.c:554:34: warning: The left operand of '<' is a garbage value MIN (default_width, ^ ~~~~~~~~~~~~~
2019-07-23Fix attempt to free released memoryrbuj1-1/+0
2019-07-22tx: Fix POT path in configClement Lefebvre1-1/+1
2019-07-22Revert "tx: sync with transifex"Clement Lefebvre117-4115/+4133
This reverts commit a1fda5f4cca0d5019428a81799bfce4c235e9ec4. That commit deleted all ngettext translations (for some reasons these must have been missing in Transifex).
2019-07-10Render file-conflict icons as cairo_surface vectorsVictor Kareh3-42/+68
2019-07-10file-conflict-dialog: don't scale icons twice on hidpi monitorslukefromdc1-4/+4
Hardcode scale factor to 1 in caja_file_get_icon_pixbuf functions in caja-file-conflict as these icons are already getting scaled elsewhere. Otherwise they get scaled twice and the whole dialog is ballooned oversize on hidpi *Based on similar change made in Nautilus as a small part of fd01842f996b7d07baf2aafb0f68308fc5ed2055 "file-conflict-dialog: separate file logic from UI management " which was a more general refactoring of the file conflict dialog and split out the frontend and backend code.
2019-07-10desktop icon view: disconnect callback from correct GSettings instancemonsta1-1/+1
taken from: https://github.com/linuxmint/nemo/commit/89090ac192638d75359876d917b6d3ce106196af
2019-07-01hidpi: ensure all icons are properly scaledlukefromdc1-2/+2
2019-05-22travis: use fedora-30 and ubuntu-19.04 for buildingraveit651-2/+2
2019-04-22release 1.22.1v1.22.1raveit652-1/+18
2019-04-22tx: sync with transifexraveit65117-4133/+4115
2019-04-22tx: update resource fileraveit651-110/+106
2019-04-22caja-progress-info: make sure argument is initializedPablo Barciela1-3/+3
Fixes Clang static analyzer warning: caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value g_notification_set_body (notification, _("Process completed")); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-09Fix invocation with --geometry from the command linelukefromdc1-7/+14
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
2019-04-08Pass "NULL" for keyboard eventlukefromdc2-2/+10
Fix #1198 "Context menu with menu key broken" Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
2019-03-26github release for stable branchraveit651-0/+19
2019-03-24caja-file: Fix incomplete file replacement dialogPablo Barciela1-9/+5
Fixes https://github.com/mate-desktop/caja/issues/1183
2019-03-11tx: update transifex configraveit651-1/+1
2019-03-06eel-gdk-pixbuf-extensions: Fix division by zeroPablo Barciela1-3/+12
Fixes Clang static analyzer warning: eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero *dest++ = r / n_pixels; ~~^~~~~~~~~~
2019-03-06caja-file: Fix use of memory after it is freedPablo Barciela1-7/+13
to avoid warning with Clang Analyzer
2019-03-05caja-icon-container: Fix use of memory after it is freedPablo Barciela1-2/+2
to avoid warning with Clang Analyzer
2019-03-05fm-tree-model: Fix use of memory after it is freedPablo Barciela1-2/+6
to avoid warning with Clang Analyzer
2019-03-05caja-information-panel: Fix use of memory after it is freedPablo Barciela1-1/+4
to avoid warning with Clang Analyzer
2019-03-05fm-directory-view: Fix use of memory after it is freedPablo Barciela1-1/+1
to avoid warning with Clang Analyzer
2019-03-05caja-tree-view-drag-dest: Fix memory leakPablo Barciela1-0/+1
to avoid warning with Clang Analyzer
2019-03-05[Security] eel-string: Use 'g_strlcat' instead of 'strcat'Pablo Barciela1-2/+2
to avoid warnings with Clang Analyzer
2019-03-05[Security] Use 'g_strlcpy' instead of 'strcpy'Pablo Barciela2-4/+4
to avoid warnings with Clang Analyzer
2019-02-24release 1.22.0v1.22.0raveit652-1/+11
2019-02-24tx: sync with transifexraveit65118-48381/+68125
2019-02-19Add update-authors.pl script which helps to update caja.aboutrbuj1-0/+72
2019-02-18Read authors and documenters fom caja.about filerbuj3-109/+37
2019-02-17Ensure proper translation of the about dialog titlerbuj2-54/+59
Note that GTK+ sets a default title of _("About %s") on the dialog window (where %s is replaced by the name of the application, but in order to ensure proper translation of the title, applications should set the title property explicitly when constructing a GtkAboutDialog https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html
2019-02-16Prepare for docker-build 0.1.1 merge into masterWu Xiaotian1-0/+3
Please see mate-desktop/mate-dev-scripts#13
2019-02-14Update authorsrbuj1-4/+59
Merged the authors with the new ones: git log --pretty="%an <%ae>" --since "2012-01-01" -- . "*.h" "*.c" | sort | uniq