Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
Fixes 'cppcheck' warnings:
[src/caja-location-dialog.c:229] -> [src/caja-location-dialog.c:237]: (warning) Either the condition 'window' is redundant or there is possible null pointer dereference: window.
[src/caja-location-dialog.c:224]: (style) The scope of the variable 'formatted_location' can be reduced.
Fixes Clang static analyzer warning:
caja-location-dialog.c:237:12: warning: Access to field 'details' results in a dereference of a null pointer (loaded from variable 'window')
slot = window->details->active_pane->active_slot;
^~~~~~~~~~~~~~~
|
|
Fixes 'flawfinder' warning:
(buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
|
|
Fixes cppcheck warnings:
[libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
|
|
Fixes cppcheck warning:
[libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
|
|
Fixes Clang static analyzer warning:
caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference
g_object_unref (files[idx]);
^~~~~~~~~~
|
|
Fixes Clang static analyzer warnings:
fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value
if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value
if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warnings:
caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error')
if (error->code != G_IO_ERROR_FAILED_HANDLED) {
^~~~~~~~~~~
caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
details = error->message;
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message);
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-sidebar-title.c:233:49: warning: Dereference of null pointer (loaded from variable 'color')
sidebar_title->details->label_colors[idx] = *color;
^~~~~~
|
|
Fixes Clang static analyzer warning:
caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcpy (r, v, len * sizeof (char *));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
eel-editable-label.c:2624:9: warning: 2nd function call argument is an uninitialized value
if (pango_layout_line_x_to_index (line,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
"test ... ==" isn't a portable expression, change to POSIX "=".
|
|
Fixes Clang static analyzer warning:
eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller
return item;
^~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-window.c:554:34: warning: The left operand of '<' is a garbage value
MIN (default_width,
^ ~~~~~~~~~~~~~
|
|
|
|
|
|
This reverts commit a1fda5f4cca0d5019428a81799bfce4c235e9ec4.
That commit deleted all ngettext translations (for some reasons
these must have been missing in Transifex).
|
|
|
|
Hardcode scale factor to 1 in caja_file_get_icon_pixbuf functions in caja-file-conflict as these icons are already getting scaled elsewhere. Otherwise they get scaled twice and the whole dialog is ballooned oversize on hidpi
*Based on similar change made in Nautilus as a small part of fd01842f996b7d07baf2aafb0f68308fc5ed2055 "file-conflict-dialog: separate file logic from UI management " which was a more general refactoring of the file conflict dialog and split out the frontend and backend code.
|
|
taken from:
https://github.com/linuxmint/nemo/commit/89090ac192638d75359876d917b6d3ce106196af
|
|
|
|
|
|
|
|
|
|
|
|
Fixes Clang static analyzer warning:
caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value
g_notification_set_body (notification, _("Process completed"));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted
Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
|
|
Fix #1198 "Context menu with menu key broken"
Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
|
|
|
|
Fixes https://github.com/mate-desktop/caja/issues/1183
|
|
|
|
Fixes Clang static analyzer warning:
eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero
*dest++ = r / n_pixels;
~~^~~~~~~~~~
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
|
|
|
|
|
|
|
|
Note that GTK+ sets a default title of _("About %s") on the dialog
window (where %s is replaced by the name of the application, but
in order to ensure proper translation of the title, applications
should set the title property explicitly when constructing a
GtkAboutDialog
https://developer.gnome.org/gtk3/stable/GtkAboutDialog.html
|
|
Please see mate-desktop/mate-dev-scripts#13
|
|
Merged the authors with the new ones:
git log --pretty="%an <%ae>" --since "2012-01-01" -- . "*.h" "*.c" | sort | uniq
|
|
Update "Documented by" in About Caja dialog
|