Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
fixes this warning:
caja-undostack-manager.c: In function 'retrieve_files_to_restore':
caja-undostack-manager.c:1967:38: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
if (!(g_hash_table_size (trashed)) > 0) {
^
caja-undostack-manager.c:1967:7: note: add parentheses around left hand side expression to silence this warning
if (!(g_hash_table_size (trashed)) > 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
( )
|
|
|
|
|
|
|
|
|
|
When the icon container is repopulated (e.g. when using back/forward)
finish_adding_new_icons is called leading to an accessible children-
changed event flood. We can distinguish these unwanted notifications
from desired notifications by comparing the number of new icons to add
with the size of the container's icon set.
|
|
Accessible children-changed events should only be emitted when a user-
triggered action (creation of file, copying an item) causes an item to
be added.
Set container->details->is_loading (which does not seem to be used
anywhere) in caja_icon_container_request_update_all because if the
entire container is being updated, children-changed events should not
be emitted for each updated icon.
|
|
caja_icon_canvas_item_set_property was emitting accessible-name-change
signals whenever the PROP_EDITABLE_TEXT was being set for an icon. This
method is called by caja_icon_container_request_update_all when the icon
view is first loaded. Thus irrelevant events are being emitted (the name
of each icon didn't change, as far as the user is concerned). Furthermore,
this floods assistive technologies any time the user opens a folder with
a large number of files.
Moving the notification out of caja_icon_canvas_item_set_property and
into end_renaming_mode (where ICON_TEXT_CHANGED is also emitted) solves
the problem of floods of irrelevant notifications while still emitting
the signal when the name actually changes.
|
|
"gio open" from libglib2.0-bin.
|
|
|
|
|
|
Adapt and apply these four relevent Nautilus commits, which remove the code responsible for the segfaults:
*https://github.com/GNOME/nautilus/commit/e1ad3c05a6cd08c8cbf18ae53701dd742249d5fd#diff-f896071d07d34e87af94a18de95e4ea2
"pathbar: add a path-event signal"
*https://github.com/GNOME/nautilus/commit/875efc324f8e91f2d157c7532fe5570c1de421c7#diff-f896071d07d34e87af94a18de95e4ea2
"pathbar: remove unused code"
*https://github.com/GNOME/nautilus/commit/cfa51e6702ade6a8ca9045791773e6e10560262f
"window-pane: use the path-event signal from NautilusPathBar" (now CajaPathBar)
*https://github.com/GNOME/nautilus/commit/2759def4968f89c1a2370ca5b2b91af84dc4afd3
"pathbar: add a return value from path-event signal"
|
|
This was introduced in commit b28445b3d2c42a7d2dbac97983d007e4ab58684d
but has never been added to some parts of the UI.
|
|
|
|
|
|
The basenames of files are split by dots and then starting from the end
each segment is compared to find a sort order. Example:
bar.tar.bz2
foo.tar.bz2
a.bar.gz
x.tar.gz
z.tar.gz
test.tex
A heuristic determines what extension segments are part of the
extension. There is probably no perfect solution but there are much
less false positives. As a result the sorting is more intuitive and the
displayed column in the list view is better readable and displays
extensions more accurately.
In addition a bug related to the default sort criteria in the
preferences has been fixed.
|
|
|
|
avoid deprecated:
gtk_image_menu_item_set_always_show_image
gtk_image_menu_item_new_with_label
gtk_image_menu_item_set_image
|
|
*caja-pathbar: fix warning,and in the process maybe fix occasional segfaults on opening mounted volumes from the desktop
*caja-icon-info: Stop gdk_cairo_surface_create_from_pixbuf: assertion 'GDK_IS_PIXBUF (pixbuf)' failed warning by handling NULL return from function finding the pixbuf
caja-icon-canvas-item-c: do not use g_object_unref where it does not work Stop the g_object_unref: assertion 'G_IS_OBJECT (object)' failed warnings on closing icon views
|
|
|
|
This allows icons in most places to scale up properly for HiDPI
displays.
|
|
As it is deprecated, instead of using gdk_screen_get_monitor_scale_factor
use gdk_monitor_get_scale_factor().
https://bugzilla.gnome.org/show_bug.cgi?id=779774
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/273e6efc
|
|
As we now store surfaces in the GtkListStore, we have to change the
drag method to use it instead of a pixbuf.
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/18a380af
|
|
|
|
Otherwise we might pick up an icon at an invalid size for a given scale.
https://bugzilla.gnome.org/show_bug.cgi?id=776896
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/53cee1de
|
|
This was missing from the last commit.
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/b3b4bea5
|
|
This was missing from the last commit.
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/3a6053f1
|
|
Port the rendering of icons to cairo surfaces, so that we can apply the
GDK scale factor when rendering icons.
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/0d4555d7
|
|
This is one of the condition that needs to trigger an invalidation to
recompute layout at the correct size.
https://bugzilla.gnome.org/show_bug.cgi?id=776896
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/b257699e
|
|
So to get HiDpi support.
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/31059f33
|
|
The problem is that in the function canvas_container_set_workarea the screen width
and height are in "application pixels" while the workarea ones are in "device
pixels" so when the scaling is > 1, the margins are not properly setted.
We need to scale-down the workarea geometries to "application pixels".
https://bugzilla.gnome.org/show_bug.cgi?id=769302
origin commit:
https://gitlab.gnome.org/GNOME/nautilus/commit/315a55df
|
|
|
|
avoid deprecated:
gtk_image_menu_item_new_with_label
gtk_image_menu_item_set_image
|
|
avoid deprecated:
gtk_image_menu_item_new_with_mnemonic
gtk_image_menu_item_set_image
|
|
Fixes https://github.com/mate-desktop/caja/pull/965#issuecomment-377716724
|
|
avoid deprecated 'gtk_image_menu_item_set_always_show_image'
|
|
avoid deprecated:
gtk_image_menu_item_new_with_label
gtk_image_menu_item_set_image
|
|
avoid deprecated:
gtk_image_menu_item_new_with_mnemonic
gtk_image_menu_item_new_with_label
gtk_image_menu_item_set_image
|
|
avoid deprecated:
gtk_image_menu_item_new_with_label
gtk_image_menu_item_set_image
gtk_image_menu_item_new_from_stock
|
|
Fixes https://github.com/mate-desktop/caja/pull/956#issuecomment-377222055
|
|
|
|
avoid deprecated:
gtk_image_menu_item_new_from_stock
gtk_image_menu_item_new_with_mnemonic
gtk_image_menu_item_set_image
|
|
|
|
|
|
|
|
|
|
Fixes https://github.com/mate-desktop/caja/pull/950#issuecomment-375567705
|
|
|
|
|