summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-06-29fm-list-view: suppress GtkAction warningsraveit651-0/+2
2019-06-29fm-icon-view: suppress GtkAction warningsraveit651-0/+16
2019-06-29fm-directory-view: change G_GNUC_END_IGNORE_DEPRECATIONS placePablo Barciela1-2/+2
Fixes cppcheck warnings: [src/file-manager/fm-directory-view.c:1007]: (style) Statements following return, break, continue, goto or throw will never be executed. [src/file-manager/fm-directory-view.c:1080]: (style) Statements following return, break, continue, goto or throw will never be executed.
2019-06-28Fix cppcheck warningsPablo Barciela4-132/+132
appeared since the silence of deprecated gtkaction warnings
2019-06-27Revert "fm-directory-view: free var action_name"raveit651-2/+0
This reverts commit f13416d256ede64396c3c6bb26fadb9b5e527bd3. This was wrong.
2019-06-27fm-directory-view: free var action_nameraveit651-0/+2
2019-06-27fm-directory-view: fix previous GtkAction commitraveit651-9/+12
2019-06-25fm-directory-view: suppress GtkAction warningsraveit651-3/+107
2019-06-25fm-desktop-icon-view: suppress GtkAction warningsraveit651-0/+9
2019-06-25caja-ui-utilities: suppress GtkAction warningsraveit651-0/+12
2019-06-25caja-clipboard: suppress GtkAction warningsraveit651-0/+10
2019-06-24tx: sync with fixed translations from transifexraveit6514-906/+8814
2019-06-18Remove trailing whitespacesrbuj46-223/+223
find . -regextype posix-extended -regex '.*\.(c|h|ac|txt|xml)' -exec sed --in-place 's/[[:space:]]\+$//' {} \+
2019-06-17src: reduce the scope of some variablesPablo Barciela32-208/+331
2019-06-15caja-open-with-dialog: cppcheck: Redundant conditionPablo Barciela1-2/+1
Fixes cppcheck warning: [libcaja-private/caja-open-with-dialog.c:265]: (style) Redundant condition: !dialog->details->add_mode. 'A || (!A && B)' is equivalent to 'A || B'
2019-06-15eel-canvas: cppcheck: Local variable 'allocation' shadows outer variablePablo Barciela1-1/+0
Fixes cppcheck warning: [eel/eel-canvas.c:3261] -> [eel/eel-canvas.c:3297]: (style) Local variable allocation shadows outer variable
2019-06-11Change URL prefixes from http to httpsrbuj15-52/+52
2019-06-10Change url projet's websiteLaurent Napias3-3/+3
2019-06-09caja-progress-info: add tooltips to file transfer dialogPablo Barciela1-0/+4
Fixes https://github.com/mate-desktop/caja/issues/845
2019-06-09Add accessible names for buttons in file transfer operations dialogLuke Yelavich1-0/+4
2019-05-31Create FUNDING.ymlMartin Wimpress1-0/+9
2019-05-22travis: use fedora-30 and ubuntu-19.10 for buildingraveit651-6/+7
2019-05-09libegg: reduce the scope of some variablesPablo Barciela3-9/+22
Fixes 'cppcheck' warnings: [libegg/eggdesktopfile.c:483]: (style) The scope of the variable 'try_exec' can be reduced. [libegg/eggdesktopfile.c:483]: (style) The scope of the variable 'found_program' can be reduced. [libegg/eggdesktopfile.c:484]: (style) The scope of the variable 'only_show_in' can be reduced. [libegg/eggdesktopfile.c:484]: (style) The scope of the variable 'not_show_in' can be reduced. [libegg/eggdesktopfile.c:486]: (style) The scope of the variable 'i' can be reduced. [libegg/eggdesktopfile.c:608]: (style) The scope of the variable 'p' can be reduced. [libegg/eggsmclient-xsmp.c:227]: (style) The scope of the variable 'cmdline' can be reduced. [libegg/eggsmclient-xsmp.c:773]: (style) The scope of the variable 'fd' can be reduced. [libegg/eggsmclient-xsmp.c:808]: (style) The scope of the variable 'keys' can be reduced. [libegg/eggtreemultidnd.c:305]: (style) The scope of the variable 'context' can be reduced.
2019-05-07[ci] Add cppcheck html reportPablo Barciela1-1/+4
2019-05-06libcaja-private: reduce the scope of some variablesPablo Barciela44-476/+794
2019-05-04eel: remove date & time functionsrbuj11-363/+39
Do not need to extend glib library, since it now incorporates these functions. Extended date format modifiers are available on glib v2.56. eel-glib-extensions.h/c: GDate * eel_g_date_new_tm (struct tm *time_pieces); char * eel_strdup_strftime (const char *format, struct tm *time_pieces); gint64 eel_get_system_time (void); Do not need to test the extensions in eel_self_check_glib_extensions (void). eel-glib-extensions.c: static void check_tm_to_g_date (time_t time) static char * test_strftime (...) Do not need to check if strftime implements extended date format modifiers on the system (available on glibc v2.27). configure.ac
2019-04-30caja-spatial-window: Unused variable irbuj1-1/+0
2019-04-18eel: reduce the scope of some variablesPablo Barciela15-48/+80
Fixes 'cppcheck' warnings: [eel/eel-background.c:163]: (style) The scope of the variable 'intensity' can be reduced. [eel/eel-background.c:163]: (style) The scope of the variable 'saturation' can be reduced. [eel/eel-background.c:196]: (style) The scope of the variable 'end_color' can be reduced. [eel/eel-canvas-rect-ellipse.c:600]: (style) The scope of the variable 'tmp' can be reduced. [eel/eel-canvas-rect-ellipse.c:705]: (style) The scope of the variable 'width_pixels' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_lt' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_rb' can be reduced. [eel/eel-canvas.c:1420]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:1493]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1518]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1545]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1599]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cx' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cy' can be reduced. [eel/eel-debug.c:80]: (style) The scope of the variable 'f' can be reduced. [eel/eel-editable-label.c:1493]: (style) The scope of the variable 'clip' can be reduced. [eel/eel-editable-label.c:1571]: (style) The scope of the variable 'text' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'anchor' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'end' can be reduced. [eel/eel-editable-label.c:3054]: (style) The scope of the variable 'menuitem' can be reduced. [eel/eel-editable-label.c:3400]: (style) The scope of the variable 'index' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:85]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_x1' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_y2' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:284]: (style) The scope of the variable 's_xfrac' can be reduced. [eel/eel-glib-extensions.c:439]: (style) The scope of the variable 'compare_result' can be reduced. [eel/eel-glib-extensions.c:561]: (style) The scope of the variable 'hash_table_to_free' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:195]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:196]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:245]: (style) The scope of the variable 'slab_width' can be reduced. [eel/eel-graphic-effects.c:262]: (style) The scope of the variable 'slab_height' can be reduced. [eel/eel-graphic-effects.c:282]: (style) The scope of the variable 'y' can be reduced. [eel/eel-gtk-extensions.c:165]: (style) The scope of the variable 'screen' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_width' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_height' can be reduced. [eel/eel-gtk-extensions.c:168]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-labeled-image.c:1051]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1052]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-labeled-image.c:1100]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1101]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-mate-extensions.c:73]: (style) The scope of the variable 'quoted' can be reduced. [eel/eel-stock-dialogs.c:409]: (style) The scope of the variable 'button_title' can be reduced. [eel/eel-string.c:415]: (style) The scope of the variable 'i' can be reduced. [eel/eel-string.c:542]: (style) The scope of the variable 'type' can be reduced. [eel/eel-vfs-extensions.c:65]: (style) The scope of the variable 'valid_bytes' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'hadj' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'vadj' can be reduced.
2019-04-17travis: enable cppcheck only in debian and disable it in other distrosPablo Barciela1-4/+3
2019-04-16caja-location-dialog: Fix 'cppcheck' and 'clang' warningsPablo Barciela1-5/+5
Fixes 'cppcheck' warnings: [src/caja-location-dialog.c:229] -> [src/caja-location-dialog.c:237]: (warning) Either the condition 'window' is redundant or there is possible null pointer dereference: window. [src/caja-location-dialog.c:224]: (style) The scope of the variable 'formatted_location' can be reduced. Fixes Clang static analyzer warning: caja-location-dialog.c:237:12: warning: Access to field 'details' results in a dereference of a null pointer (loaded from variable 'window') slot = window->details->active_pane->active_slot; ^~~~~~~~~~~~~~~
2019-04-16release 1.23.0v1.23.0raveit651-0/+50
2019-04-16sync with transifexraveit6527-451/+530
2019-04-14caja-property-browser: Fix cast from non-struct type to struct typePablo Barciela1-4/+4
Fixes Clang static analyzer warnings: caja-property-browser.c:1242:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1414:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1450:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER(data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-14eggsmclient-xsmp: Fix cast from non-struct type to struct typePablo Barciela1-2/+2
Fixes Clang static analyzer warning: eggsmclient-xsmp.c:1156:18: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption prop->vals = (SmPropValue *)vals->data; ^~~~~~~~~~~~~~~~~~~~~~~~~ eggsmclient-xsmp.c:1189:18: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption prop->vals = (SmPropValue *)vals->data; ^~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-14caja-file-utilities: Fix cast from non-struct type to struct typePablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-file-utilities.c:283:12: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption return (XdgDirEntry *)g_array_free (array, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-12local #include files who are libraries inside <> instead ""Pablo Barciela147-725/+727
2019-04-12eel-string: Use 'va_copy' instead of 'G_VA_COPY'Pablo Barciela1-3/+3
Fixes cppcheck warnings: [eel-string.c:681]: (error) va_list 'va' used before va_start() was called. [eel-string.c:682]: (error) va_list 'va' used before va_start() was called. [eel-string.c:683]: (error) va_list 'va' used before va_start() was called. [eel-string.c:684]: (error) va_list 'va' used before va_start() was called. [eel-string.c:697]: (error) va_list 'va' used before va_start() was called. [eel-string.c:698]: (error) va_list 'va' used before va_start() was called. [eel-string.c:699]: (error) va_list 'va' used before va_start() was called. [eel-string.c:700]: (error) va_list 'va' used before va_start() was called. [eel-string.c:709]: (error) va_list 'va' used before va_start() was called. [eel-string.c:710]: (error) va_list 'va' used before va_start() was called. [eel-string.c:714]: (error) va_list 'va' used before va_start() was called. [eel-string.c:720]: (error) va_list 'va' used before va_start() was called. [eel-string.c:722]: (error) va_list 'va' used before va_start() was called.
2019-04-12eel-editable-label: Use 'memmove' instead of 'memcpy'Pablo Barciela1-1/+1
Fixes 'flawfinder' warning: (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
2019-04-12eel: remove eel_g_object_list_refrbuj3-17/+1
2019-04-10drop functions defined but not usedPablo Barciela8-511/+0
2019-04-10local #include files inside "" instead <>Pablo Barciela189-1202/+1427
2019-04-10caja-icon-canvas-item: avoid 'cppcheck' warningPablo Barciela1-14/+13
Fixes 'cppcheck' warning: [libcaja-private/caja-icon-canvas-item.c:850]: (error) Uninitialized variable: real_text_height
2019-04-10caja-file: avoid shifting signed 32-bit value by 31 bitsPablo Barciela1-1/+1
Fixes cppcheck warnings: [libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
2019-04-09Fix invocation with --geometry from the command linelukefromdc1-7/+14
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
2019-04-08caja-icon-canvas-item: initialize variable 'scale'Pablo Barciela1-1/+1
Fixes cppcheck warning: [libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
2019-04-08Pass "NULL" for keyboard eventlukefromdc2-2/+10
Fix #1198 "Context menu with menu key broken" Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
2019-04-08pre-bump versionraveit652-1/+3
2019-04-07caja-application: avoid NULL inside 'g_object_unref'Pablo Barciela1-3/+4
Fixes Clang static analyzer warning: caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference g_object_unref (files[idx]); ^~~~~~~~~~
2019-04-07travis: enable 'cppcheck'Pablo Barciela1-0/+5
2019-04-05fm-desktop-icon-view: remove dead codePablo Barciela1-11/+1
Fixes Clang static analyzer warnings: fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~