summaryrefslogtreecommitdiff
AgeCommit message (Collapse)AuthorFilesLines
2019-04-14caja-property-browser: Fix cast from non-struct type to struct typePablo Barciela1-4/+4
Fixes Clang static analyzer warnings: caja-property-browser.c:1242:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1414:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER (data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~ caja-property-browser.c:1450:45: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption CajaPropertyBrowser *property_browser = CAJA_PROPERTY_BROWSER(data); ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-14eggsmclient-xsmp: Fix cast from non-struct type to struct typePablo Barciela1-2/+2
Fixes Clang static analyzer warning: eggsmclient-xsmp.c:1156:18: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption prop->vals = (SmPropValue *)vals->data; ^~~~~~~~~~~~~~~~~~~~~~~~~ eggsmclient-xsmp.c:1189:18: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption prop->vals = (SmPropValue *)vals->data; ^~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-14caja-file-utilities: Fix cast from non-struct type to struct typePablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-file-utilities.c:283:12: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption return (XdgDirEntry *)g_array_free (array, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-12local #include files who are libraries inside <> instead ""Pablo Barciela147-725/+727
2019-04-12eel-string: Use 'va_copy' instead of 'G_VA_COPY'Pablo Barciela1-3/+3
Fixes cppcheck warnings: [eel-string.c:681]: (error) va_list 'va' used before va_start() was called. [eel-string.c:682]: (error) va_list 'va' used before va_start() was called. [eel-string.c:683]: (error) va_list 'va' used before va_start() was called. [eel-string.c:684]: (error) va_list 'va' used before va_start() was called. [eel-string.c:697]: (error) va_list 'va' used before va_start() was called. [eel-string.c:698]: (error) va_list 'va' used before va_start() was called. [eel-string.c:699]: (error) va_list 'va' used before va_start() was called. [eel-string.c:700]: (error) va_list 'va' used before va_start() was called. [eel-string.c:709]: (error) va_list 'va' used before va_start() was called. [eel-string.c:710]: (error) va_list 'va' used before va_start() was called. [eel-string.c:714]: (error) va_list 'va' used before va_start() was called. [eel-string.c:720]: (error) va_list 'va' used before va_start() was called. [eel-string.c:722]: (error) va_list 'va' used before va_start() was called.
2019-04-12eel-editable-label: Use 'memmove' instead of 'memcpy'Pablo Barciela1-1/+1
Fixes 'flawfinder' warning: (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
2019-04-12eel: remove eel_g_object_list_refrbuj3-17/+1
2019-04-10drop functions defined but not usedPablo Barciela8-511/+0
2019-04-10local #include files inside "" instead <>Pablo Barciela189-1202/+1427
2019-04-10caja-icon-canvas-item: avoid 'cppcheck' warningPablo Barciela1-14/+13
Fixes 'cppcheck' warning: [libcaja-private/caja-icon-canvas-item.c:850]: (error) Uninitialized variable: real_text_height
2019-04-10caja-file: avoid shifting signed 32-bit value by 31 bitsPablo Barciela1-1/+1
Fixes cppcheck warnings: [libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
2019-04-09Fix invocation with --geometry from the command linelukefromdc1-7/+14
Due to changes somewhere else windows called with --geometry must now be opened before splitedOptions is freed or the geometry passed to later functions gets corrrupted Note that setting a width smaller than 654 px will generate GTK warnings (negative content width and similar) but will still mostly work.
2019-04-08caja-icon-canvas-item: initialize variable 'scale'Pablo Barciela1-1/+1
Fixes cppcheck warning: [libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
2019-04-08Pass "NULL" for keyboard eventlukefromdc2-2/+10
Fix #1198 "Context menu with menu key broken" Pass "NULL" for event which is passed ultimately to gtk_menu_popup_at_pointer as an invalid event was being passed when the menu key was used to open the icon views context menu
2019-04-08pre-bump versionraveit652-1/+3
2019-04-07caja-application: avoid NULL inside 'g_object_unref'Pablo Barciela1-3/+4
Fixes Clang static analyzer warning: caja-application.c:2221:25: warning: Array access (from variable 'files') results in a null pointer dereference g_object_unref (files[idx]); ^~~~~~~~~~
2019-04-07travis: enable 'cppcheck'Pablo Barciela1-0/+5
2019-04-05fm-desktop-icon-view: remove dead codePablo Barciela1-11/+1
Fixes Clang static analyzer warnings: fm-desktop-icon-view.c:331:33: warning: 1st function call argument is an uninitialized value if (pointer == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_MOUSE)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~ fm-desktop-icon-view.c:335:34: warning: 1st function call argument is an uninitialized value if (keyboard == NULL && (gdk_device_get_source (cur) == GDK_SOURCE_KEYBOARD)) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-05caja-file-operations: make sure 'error' isn't NULLPablo Barciela1-2/+2
Fixes Clang static analyzer warnings: caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error') if (error->code != G_IO_ERROR_FAILED_HANDLED) { ^~~~~~~~~~~ caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') details = error->message; ^~~~~~~~~~~~~~
2019-04-03caja-open-with-dialog: make sure there is error before showing itPablo Barciela1-2/+5
Fixes Clang static analyzer warning: caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message); ^~~~~~~~~~~~~~
2019-04-03eel-string: Fix: 'memcpy' overflows destination bufferPablo Barciela1-2/+3
Fixes Clang static analyzer warning: eel-string.c:319:13: warning: Memory copy function overflows destination buffer memcpy (result_position, p, remaining_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-03eel-string: avoid 'memcpy' with NULL argumentPablo Barciela1-0/+4
Fixes Clang static analyzer warning: eel-string.c:325:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (result_position, replacement, replacement_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-30caja-progress-info: make sure argument is initializedPablo Barciela1-3/+3
Fixes Clang static analyzer warning: caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value g_notification_set_body (notification, _("Process completed")); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-29eel: replace eel_ref_str with GRefStringrbuj8-218/+94
GNOME/nautilus@b4d200f https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
2019-03-29eel: remove g_object_list_copyrbuj7-23/+10
GNOME/nautilus@7af24a8 Replace GList * eel_g_object_list_copy (GList *list) with g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
2019-03-28caja-sidebar-title: avoid 'NULL' inside 'setup_gc_with_fg'Pablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-sidebar-title.c:233:49: warning: Dereference of null pointer (loaded from variable 'color') sidebar_title->details->label_colors[idx] = *color; ^~~~~~
2019-03-26github releaseraveit651-10/+27
2019-03-24caja-file: Fix incomplete file replacement dialogPablo Barciela1-9/+5
Fixes https://github.com/mate-desktop/caja/issues/1183
2019-03-24caja-autorun: avoid NULL in 'memcpy'Pablo Barciela1-1/+4
Fixes Clang static analyzer warning: caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (r, v, len * sizeof (char *)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-22eel-editable-label: call argument with initialized valuePablo Barciela1-2/+2
Fixes Clang static analyzer warning: eel-editable-label.c:2624:9: warning: 2nd function call argument is an uninitialized value if (pango_layout_line_x_to_index (line, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-22caja-file: Fix: true and false branches are identicalPablo Barciela1-2/+0
Fixes Clang static analyzer warning: caja-file.c:4858:9: warning: true and false branches are identical } else if (file_date_age < 7) { ^
2019-03-22caja-file-operations: add comment with false positive warning:Pablo Barciela1-0/+8
False positive warning with Clang static analyzer: caja-file-operations.c:958:11: warning: Cast a region whose size is not a multiple of the destination type size common = g_malloc0 (job_size); ^~~~~~~~~~~~~~~~~~~~
2019-03-08[ci] switch to use build scripts on master branchWu Xiaotian1-3/+3
2019-03-08[ci] If possible, compile with make -jNWu Xiaotian1-1/+5
2019-03-08[ci] Use status notificationWu Xiaotian1-3/+8
2019-03-08[ci] use clang analyzerWu Xiaotian1-11/+64
2019-03-07configure.ac: fix portability issue with testDavid H. Gutteridge1-1/+1
"test ... ==" isn't a portable expression, change to POSIX "=".
2019-03-07eel: remove g_str_list_copyrbuj5-28/+7
GNOME/nautilus@61e2aff Replace eel_g_str_list_copy(Glist *list) with g_list_copy_deep (list, (GCopyFunc) g_strdup, NULL)
2019-03-07Remove USE_MATE2_MACROS from autogen.sh (legacy)rbuj1-1/+0
2019-03-07eel: remove g_list_free_deep_customrbuj2-20/+1
2019-03-07avoid variables set but not usedPablo Barciela16-65/+9
2019-03-06eel-canvas: Fix warning: Undefined or garbage value returned to callerPablo Barciela1-1/+1
Fixes Clang static analyzer warning: eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller return item; ^~~~~~~~~~~
2019-03-06caja-window: Fix garbage valuePablo Barciela1-1/+2
Fixes Clang static analyzer warning: caja-window.c:554:34: warning: The left operand of '<' is a garbage value MIN (default_width, ^ ~~~~~~~~~~~~~
2019-03-06eel-gdk-pixbuf-extensions: Fix division by zeroPablo Barciela1-3/+12
Fixes Clang static analyzer warning: eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero *dest++ = r / n_pixels; ~~^~~~~~~~~~
2019-03-06caja-file: Fix use of memory after it is freedPablo Barciela1-7/+13
to avoid warning with Clang Analyzer
2019-03-05caja-icon-container: Fix use of memory after it is freedPablo Barciela1-2/+2
to avoid warning with Clang Analyzer
2019-03-05Fix attempt to free released memoryrbuj1-1/+0
2019-03-04fm-tree-model: Fix use of memory after it is freedPablo Barciela1-2/+6
to avoid warning with Clang Analyzer
2019-03-04caja-information-panel: Fix use of memory after it is freedPablo Barciela1-1/+4
to avoid warning with Clang Analyzer
2019-03-04fm-directory-view: Fix use of memory after it is freedPablo Barciela1-1/+1
to avoid warning with Clang Analyzer
generated by cgit v1.2.1 (git 2.18.0) at 2024-11-24 13:23:39 +0000