summaryrefslogtreecommitdiff
path: root/eel/eel-canvas.c
AgeCommit message (Collapse)AuthorFilesLines
2022-07-20eel-canvas: cppcheck: Local variable 'allocation' shadows outer variablePablo Barciela1-1/+0
Fixes cppcheck warning: [eel/eel-canvas.c:3261] -> [eel/eel-canvas.c:3297]: (style) Local variable allocation shadows outer variable
2022-07-19eel: reduce the scope of some variablesPablo Barciela1-8/+9
Fixes 'cppcheck' warnings: [eel/eel-background.c:163]: (style) The scope of the variable 'intensity' can be reduced. [eel/eel-background.c:163]: (style) The scope of the variable 'saturation' can be reduced. [eel/eel-background.c:196]: (style) The scope of the variable 'end_color' can be reduced. [eel/eel-canvas-rect-ellipse.c:600]: (style) The scope of the variable 'tmp' can be reduced. [eel/eel-canvas-rect-ellipse.c:705]: (style) The scope of the variable 'width_pixels' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_lt' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_rb' can be reduced. [eel/eel-canvas.c:1420]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:1493]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1518]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1545]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1599]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cx' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cy' can be reduced. [eel/eel-debug.c:80]: (style) The scope of the variable 'f' can be reduced. [eel/eel-editable-label.c:1493]: (style) The scope of the variable 'clip' can be reduced. [eel/eel-editable-label.c:1571]: (style) The scope of the variable 'text' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'anchor' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'end' can be reduced. [eel/eel-editable-label.c:3054]: (style) The scope of the variable 'menuitem' can be reduced. [eel/eel-editable-label.c:3400]: (style) The scope of the variable 'index' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:85]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_x1' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_y2' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:284]: (style) The scope of the variable 's_xfrac' can be reduced. [eel/eel-glib-extensions.c:439]: (style) The scope of the variable 'compare_result' can be reduced. [eel/eel-glib-extensions.c:561]: (style) The scope of the variable 'hash_table_to_free' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:195]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:196]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:245]: (style) The scope of the variable 'slab_width' can be reduced. [eel/eel-graphic-effects.c:262]: (style) The scope of the variable 'slab_height' can be reduced. [eel/eel-graphic-effects.c:282]: (style) The scope of the variable 'y' can be reduced. [eel/eel-gtk-extensions.c:165]: (style) The scope of the variable 'screen' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_width' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_height' can be reduced. [eel/eel-gtk-extensions.c:168]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-labeled-image.c:1051]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1052]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-labeled-image.c:1100]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1101]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-mate-extensions.c:73]: (style) The scope of the variable 'quoted' can be reduced. [eel/eel-stock-dialogs.c:409]: (style) The scope of the variable 'button_title' can be reduced. [eel/eel-string.c:415]: (style) The scope of the variable 'i' can be reduced. [eel/eel-string.c:542]: (style) The scope of the variable 'type' can be reduced. [eel/eel-vfs-extensions.c:65]: (style) The scope of the variable 'valid_bytes' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'hadj' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'vadj' can be reduced.
2019-03-06eel-canvas: Fix warning: Undefined or garbage value returned to callerPablo Barciela1-1/+1
Fixes Clang static analyzer warning: eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller return item; ^~~~~~~~~~~
2018-05-05avoid deprecated 'gtk_style_context_get_background_color'Pablo Barciela1-1/+8
2018-01-31require GTK+ 3.22 and GLib 2.50monsta1-100/+0
2017-04-17show correct right-click menu after making selectionmonsta1-0/+1
taken from: https://git.gnome.org/browse/nautilus/commit/?id=fabea8532911c2e38d91aa6230136cff5e52f095 upstream bug with detailed description: https://bugzilla.gnome.org/704289
2017-04-13eel: Queue resizes on the canvas as elements change visibilityraveit651-1/+18
Not queueing resizes may play oddly with the size request caches in GTK+, resulting in gtk_widget_get_preferred_width/height returning 0 even after the canvas was populated. https://bugzilla.gnome.org/show_bug.cgi?id=667831 Taken from: https://git.gnome.org/browse/nautilus/commit/?id=8c77821
2017-01-07a11y: fix accessibility implementation for CajaIconCanvasItemAccessibleColomban Wendling1-15/+0
Fix CajaIconCanvasItemAccessible inheritance to properly inherit from EelCanvasItemAccessible. This fixes the ATK state machinery in CajaIconCanvasItemAccessible, and adds AtkComponent support which provides several useful features. Part of https://github.com/mate-desktop/caja/issues/245 Based off https://git.gnome.org/browse/nautilus/commit/?id=6c5baeb7626eda6629fc6642c9eb513ef8bc5c8e See https://bugzilla.gnome.org/show_bug.cgi?id=677509
2016-12-31Single click navigation: keep hand cursor when opening folder...lukefromdc1-1/+3
and it comes to rest on a new folder displayed in the same icon position. Note that this is only in single click navigation, as double clicking always reverts the cursor to the arrow Same as GNOME/nautilus commit https://git.gnome.org/browse/nautilus/commit/?id=d486af277f491ff5cfcfa254ebce618cd41a3edb
2016-12-29fix indent and spacing a bitmonsta1-10/+10
2016-11-22move to GTK+3 (>= 3.14), drop libunique, GTK+2 code, and --with-gtk build ↵lukefromdc1-401/+4
option *Remove GTK_VERSION_CHECK (3, 0, 0) and libunique selectors *Remove GTK2 and libunique specific code. *Leaves selector for specific GTK3 versions. *Remove #DEFINES for vbox/hbox previously required for GTK2 compatability *Keep vbox in caja-spatial-window.c, it is necessary for the desktop to work *spatial-window vbox issue at https://github.com/mate-desktop/caja/issues/591
2016-10-16support back and forward mouse buttons to navigateMartin Matuska1-0/+6
Fixes https://github.com/mate-desktop/caja/issues/78 Co-Authored-By: Oliver Joos <[email protected]> Co-Authored-By: Nelson Benitez Leon <[email protected]>
2016-10-11Fix accessible object inherritance when used with GTK 3Luke Yelavich1-3/+81
Also disable eel accessibility code that is not needed. Fixes https://github.com/mate-desktop/caja/issues/590
2016-07-04Gtk+-3.20 eel-canvas: use GdkSeat operationsraveit651-6/+107
Some GdkDisplay operations have been deprecated in GDK 3.20. This commit replaces the deprecated code in eel_canvas_item_grab() and eel_canvas_item_ungrab() functions with new GdkSeat operations. https://bugzilla.gnome.org/show_bug.cgi?id=762235 taken from: https://git.gnome.org/browse/nautilus/commit/?id=225f2cf
2016-01-18GTK3 canvas: don't use deprecated GDK grab APIWolfgang Ulbrich1-1/+55
taken from: https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-2&id=2ff006d
2016-01-15GTK3: don't use deprecated gdk_threads_{enter/leave} ()Wolfgang Ulbrich1-0/+4
Since we don't ever call gdk_threads_init()
2016-01-13Gtk3 eel-canvas: port to GtkStyleContextWolfgang Ulbrich1-1/+5
2015-12-24eel: remove unused functionMonsta1-36/+0
2015-06-19[GTK+3] eel: fix bad positioning of rename window in certain casesMonsta1-4/+15
adapted from https://github.com/linuxmint/nemo/commit/d5377cfd53034b6ab5588376322126f48782ec59 (thanks to @mtwebster and nautilus developer who did the original commit) fixes https://github.com/mate-desktop/caja/issues/376
2014-12-10zero-init all signals arraysMonsta1-2/+2
2013-07-23eel: depth argument is removed from gdk_window_get_geometry in GTK3Stefano Karapetsas1-0/+4
2012-12-22[all] silence warnings from GCC 4.6Jasmine Hassan1-5/+0
GCC 4.6 introduced a new warning about variables declared and initialized, but not really used in the function body. Remove all of these occurrences to build cleanly. http://git.gnome.org/browse/nautilus/commit/?id=d4230de8667764e02dbb966b5d806ff78ced2fd5
2012-12-22[eel] remove commented out canvas codeJasmine Hassan1-5/+0
2012-11-16[general] use new GtkScrollable interfaceJasmine Hassan1-23/+31
http://git.gnome.org/browse/nautilus/commit/?id=d811553a4e74106efdf8bf6c91c6d29944ed6df7 canvas: use GTK_LAYOUT casts instead of going through the parent struct http://git.gnome.org/browse/nautilus/commit/?id=2260005986d8c620669e56c4b9f2fba12e8e0625
2012-11-16[eel-canvas] Port the eel canvas to rendering-cleanup-nextJasmine Hassan1-22/+151
http://git.gnome.org/browse/nautilus/commit/?id=58832e54b6a4e596693527d577e4f8fa2f3e4ccf
2012-11-16[eel-canvas] don't use GtkObject (GTK3)Jasmine Hassan1-34/+57
the ::destroy signal of GtkObject has only been moved to GtkWidget in GTK3 (after GtkObject removal): http://developer.gnome.org/gtk3/3.0/ch25s02.html So, we conditionals in this case, to keep working with GTK2 Nautilus commit message: This implies adding a 'destroy' signal to EelCanvasItem, with similar semantics to gtk_object_destroy() http://git.gnome.org/browse/nautilus/commit/?id=1f615321613751a5dbc84d5ef7f20edd104b8dc4
2012-11-14[eel] use glib's i18n API instead of eel'sJasmine Hassan1-1/+1
http://git.gnome.org/browse/nautilus/commit/?id=8447fd3670021530b6340829f27f1d689b633d3a
2012-11-13[eel] port EelCanvas to cairo drawingJasmine Hassan1-68/+9
http://git.gnome.org/browse/nautilus/commit/?id=759f3401bee333caf6d0ae6ae9820cdadda440e4
2012-11-02[eel] Use GdkRegion on GTK2, cairo_region_t on GTK3Jasmine Hassan1-1/+7
http://git.gnome.org/browse/nautilus/commit/?id=3b671558f1d8ac1ee72e8af13d4ede6ab549a400
2012-08-12Fixed incorrect fsf addresses. Closes #28.Steve Zesch1-2/+2
2011-12-01moving from https://github.com/perberos/mate-desktop-environmentPerberos1-0/+4213