summaryrefslogtreecommitdiff
path: root/eel
AgeCommit message (Collapse)AuthorFilesLines
2019-04-18eel: reduce the scope of some variablesPablo Barciela15-48/+80
Fixes 'cppcheck' warnings: [eel/eel-background.c:163]: (style) The scope of the variable 'intensity' can be reduced. [eel/eel-background.c:163]: (style) The scope of the variable 'saturation' can be reduced. [eel/eel-background.c:196]: (style) The scope of the variable 'end_color' can be reduced. [eel/eel-canvas-rect-ellipse.c:600]: (style) The scope of the variable 'tmp' can be reduced. [eel/eel-canvas-rect-ellipse.c:705]: (style) The scope of the variable 'width_pixels' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_lt' can be reduced. [eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_rb' can be reduced. [eel/eel-canvas.c:1420]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:1493]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1518]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1545]: (style) The scope of the variable 'i' can be reduced. [eel/eel-canvas.c:1599]: (style) The scope of the variable 'child' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cx' can be reduced. [eel/eel-canvas.c:2598]: (style) The scope of the variable 'cy' can be reduced. [eel/eel-debug.c:80]: (style) The scope of the variable 'f' can be reduced. [eel/eel-editable-label.c:1493]: (style) The scope of the variable 'clip' can be reduced. [eel/eel-editable-label.c:1571]: (style) The scope of the variable 'text' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'anchor' can be reduced. [eel/eel-editable-label.c:2270]: (style) The scope of the variable 'end' can be reduced. [eel/eel-editable-label.c:3054]: (style) The scope of the variable 'menuitem' can be reduced. [eel/eel-editable-label.c:3400]: (style) The scope of the variable 'index' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:85]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_x1' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_y2' can be reduced. [eel/eel-gdk-pixbuf-extensions.c:284]: (style) The scope of the variable 's_xfrac' can be reduced. [eel/eel-glib-extensions.c:439]: (style) The scope of the variable 'compare_result' can be reduced. [eel/eel-glib-extensions.c:561]: (style) The scope of the variable 'hash_table_to_free' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:195]: (style) The scope of the variable 'pixsrc' can be reduced. [eel/eel-graphic-effects.c:196]: (style) The scope of the variable 'pixdest' can be reduced. [eel/eel-graphic-effects.c:245]: (style) The scope of the variable 'slab_width' can be reduced. [eel/eel-graphic-effects.c:262]: (style) The scope of the variable 'slab_height' can be reduced. [eel/eel-graphic-effects.c:282]: (style) The scope of the variable 'y' can be reduced. [eel/eel-gtk-extensions.c:165]: (style) The scope of the variable 'screen' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_width' can be reduced. [eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_height' can be reduced. [eel/eel-gtk-extensions.c:168]: (style) The scope of the variable 'scale' can be reduced. [eel/eel-labeled-image.c:1051]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1052]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-labeled-image.c:1100]: (style) The scope of the variable 'x_alignment' can be reduced. [eel/eel-labeled-image.c:1101]: (style) The scope of the variable 'y_alignment' can be reduced. [eel/eel-mate-extensions.c:73]: (style) The scope of the variable 'quoted' can be reduced. [eel/eel-stock-dialogs.c:409]: (style) The scope of the variable 'button_title' can be reduced. [eel/eel-string.c:415]: (style) The scope of the variable 'i' can be reduced. [eel/eel-string.c:542]: (style) The scope of the variable 'type' can be reduced. [eel/eel-vfs-extensions.c:65]: (style) The scope of the variable 'valid_bytes' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'hadj' can be reduced. [eel/eel-wrap-table.c:766]: (style) The scope of the variable 'vadj' can be reduced.
2019-04-12local #include files who are libraries inside <> instead ""Pablo Barciela2-6/+6
2019-04-12eel-string: Use 'va_copy' instead of 'G_VA_COPY'Pablo Barciela1-3/+3
Fixes cppcheck warnings: [eel-string.c:681]: (error) va_list 'va' used before va_start() was called. [eel-string.c:682]: (error) va_list 'va' used before va_start() was called. [eel-string.c:683]: (error) va_list 'va' used before va_start() was called. [eel-string.c:684]: (error) va_list 'va' used before va_start() was called. [eel-string.c:697]: (error) va_list 'va' used before va_start() was called. [eel-string.c:698]: (error) va_list 'va' used before va_start() was called. [eel-string.c:699]: (error) va_list 'va' used before va_start() was called. [eel-string.c:700]: (error) va_list 'va' used before va_start() was called. [eel-string.c:709]: (error) va_list 'va' used before va_start() was called. [eel-string.c:710]: (error) va_list 'va' used before va_start() was called. [eel-string.c:714]: (error) va_list 'va' used before va_start() was called. [eel-string.c:720]: (error) va_list 'va' used before va_start() was called. [eel-string.c:722]: (error) va_list 'va' used before va_start() was called.
2019-04-12eel-editable-label: Use 'memmove' instead of 'memcpy'Pablo Barciela1-1/+1
Fixes 'flawfinder' warning: (buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
2019-04-12eel: remove eel_g_object_list_refrbuj2-16/+0
2019-04-10drop functions defined but not usedPablo Barciela1-39/+0
2019-04-10local #include files inside "" instead <>Pablo Barciela11-39/+42
2019-04-03eel-string: Fix: 'memcpy' overflows destination bufferPablo Barciela1-2/+3
Fixes Clang static analyzer warning: eel-string.c:319:13: warning: Memory copy function overflows destination buffer memcpy (result_position, p, remaining_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-03eel-string: avoid 'memcpy' with NULL argumentPablo Barciela1-0/+4
Fixes Clang static analyzer warning: eel-string.c:325:9: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (result_position, replacement, replacement_length); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-29eel: replace eel_ref_str with GRefStringrbuj2-122/+0
GNOME/nautilus@b4d200f https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
2019-03-29eel: remove g_object_list_copyrbuj2-13/+0
GNOME/nautilus@7af24a8 Replace GList * eel_g_object_list_copy (GList *list) with g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
2019-03-22eel-editable-label: call argument with initialized valuePablo Barciela1-2/+2
Fixes Clang static analyzer warning: eel-editable-label.c:2624:9: warning: 2nd function call argument is an uninitialized value if (pango_layout_line_x_to_index (line, ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-07eel: remove g_str_list_copyrbuj2-21/+0
GNOME/nautilus@61e2aff Replace eel_g_str_list_copy(Glist *list) with g_list_copy_deep (list, (GCopyFunc) g_strdup, NULL)
2019-03-07eel: remove g_list_free_deep_customrbuj2-20/+1
2019-03-07avoid variables set but not usedPablo Barciela2-6/+0
2019-03-06eel-canvas: Fix warning: Undefined or garbage value returned to callerPablo Barciela1-1/+1
Fixes Clang static analyzer warning: eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller return item; ^~~~~~~~~~~
2019-03-06eel-gdk-pixbuf-extensions: Fix division by zeroPablo Barciela1-3/+12
Fixes Clang static analyzer warning: eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero *dest++ = r / n_pixels; ~~^~~~~~~~~~
2019-03-04[Security] eel-string: Use 'g_strlcat' instead of 'strcat'Pablo Barciela1-2/+2
to avoid warnings with Clang Analyzer
2019-03-04drop unused variablesPablo Barciela1-2/+0
2019-01-22[eel][libegg] Use G_DEFINE_TYPE_WITH_PRIVATE macroWu Xiaotian4-8/+4
Replace G_DEFINE_TYPE_WITH_CODE with G_DEFINE_TYPE_WITH_PRIVATE macro
2019-01-12[eel] Avoid deprecated g_type_class_add_privateWu Xiaotian8-35/+25
With minimal changes to avoid deprecated g_type_class_add_private
2018-12-01eel-gtk-extensions: Fix memory leaksPablo Barciela1-2/+9
'g_strconcat' needs to be freed
2018-06-21eel-gtk-extensions: show icons in right-click menus only if ↵lukefromdc1-2/+9
"menus-have-icons" set
2018-06-05avoid deprecated 'gtk_widget_override_font'Pablo Barciela1-1/+5
2018-05-16Pathbar button: fix poor response to right-clicklukefromdc1-1/+1
Fix https://github.com/mate-desktop/caja/issues/996
2018-05-16editable-label: avoid deprecated 'gtk_im_multicontext_append_menuitems'Pablo Barciela1-15/+1
drop "Input Methods"
2018-05-14eel-editable-label.c: avoid deprecated 'gdk_keymap_get_default'Pablo Barciela1-5/+5
2018-05-13eel-editable-label: avoid deprecated gtk_style_context_set_backgroundPablo Barciela1-15/+0
2018-05-10eel-gtk-extensions: replace deprecated gtk_menu_popup functionraveit652-37/+2
2018-05-07Replace deprecated gtk_menu_popupraveit651-37/+2
Replace deprecated gtk_menu_popup in eel-editable-label,caja-dnd, emblem-sidebar,caja-side-pane, fm-tree-view, caja-navigation-window-pane, and caja-zoom-control
2018-05-05avoid deprecated 'gtk_style_context_get_background_color'Pablo Barciela3-8/+37
2018-04-07caja-spatial-window.c: avoid deprecated GtkImageMenuItemPablo Barciela2-0/+27
avoid deprecated: gtk_image_menu_item_set_always_show_image gtk_image_menu_item_new_with_label gtk_image_menu_item_set_image
2018-04-04HiDPI: Convert Pixbufs to Cairo SurfacesVictor Kareh2-0/+17
This allows icons in most places to scale up properly for HiDPI displays.
2018-04-04Scale screen dimensionsVictor Kareh3-11/+30
2018-03-27rename 'mate_image_menu_item...' to 'eel_image_menu_item_new_from_icon'Pablo Barciela3-31/+36
2018-03-26eel-editable-label.c: avoid 'append_action_signal' with stock idsPablo Barciela1-3/+3
2018-03-23avoid 'gtk_file_chooser_dialog_new' with stock idsPablo Barciela2-0/+62
2018-03-12avoid gtk_dialog_add_buttons with stock idsPablo Barciela2-2/+4
2018-03-03rename mate_dialog_add_button to eel_dialog_add_buttonPablo Barciela2-12/+16
2018-03-01avoid eel_create_question_dialog with stock idsPablo Barciela1-1/+13
2018-02-27avoid eel_run_simple_dialog with stock idsPablo Barciela1-1/+6
2018-02-27eel-stock-dialogs: avoid gtk_dialog_add_button with stock idsPablo Barciela1-2/+24
2018-02-21eel-editable-label.c: avoid gtk_image_menu_item_new_from_stockPablo Barciela1-7/+34
and add icon to "Select All"
2018-02-13fix backgrounds and emblems dialog content renderinglukefromdc1-0/+8
Fix https://github.com/mate-desktop/caja/issues/506 Redraw the contents once and exactly once at intial run of eel_wrap_table_draw to get them to show up immediately.
2018-02-09avoid deprecated GtkStockPablo Barciela2-4/+4
2018-01-31require GTK+ 3.22 and GLib 2.50monsta7-189/+3
2018-01-19Include local files with "" instead of <>Jan Niklas Hasse1-1/+1
2018-01-09remove +x attr from source filesmonsta1-0/+0
fallout from last commit
2018-01-08ui: don't use overlay-scrollbarsraveit651-0/+3
make it consistent with behaviour for caja-places-sidebar
2017-12-16WidthOfScreen and HeightOfScreen implementationPablo Barciela3-55/+13
This commit reverts: https://github.com/mate-desktop/caja/commit/4c130e22b98bbc1a85747adac3b582e45d34514e https://github.com/mate-desktop/caja/commit/ac12e6d16f4a51b3327d013781e72cfec17f3624 https://github.com/mate-desktop/caja/commit/17b3c0ca924ffcd4bd06fded98227eba626d4f0b https://github.com/mate-desktop/caja/commit/42c8d2c3373c25d6e321be6950997c0d7ce44279 And it applies an alternative to fix the deprecated functions: gdk_screen_get_width gdk_screen_get_height gdk_screen_width gdk_screen_height
generated by cgit v1.2.1 (git 2.18.0) at 2024-11-05 06:40:03 +0000