Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
more fixes for https://github.com/mate-desktop/caja/issues/1284
Pango 1.44 got the ability to automatically hyphenate on line breaks,
which is on by default, but can be set off by a new attribute.
As a result, we now hyphenate filenames, which is confusing, because
a filename may already include hyphens.
To restore the previous behavior, let's not insert hyphens when
breaking filenames in multiple lines.
Inspired by https://gitlab.gnome.org/GNOME/nautilus/commit/9738d85
|
|
|
|
|
|
|
|
Fixes https://github.com/mate-desktop/caja/commit/312394dfa42c07a3afa5089c6e3e5b9a1c1001ae#commitcomment-34152266
|
|
File's properties and caja's preferences windows
|
|
find . -regextype posix-extended -regex '.*\.(c|h|ac|txt|xml)' -exec sed --in-place 's/[[:space:]]\+$//' {} \+
|
|
Fixes cppcheck warning:
[eel/eel-canvas.c:3261] -> [eel/eel-canvas.c:3297]: (style) Local variable allocation shadows outer variable
|
|
Do not need to extend glib library, since it now incorporates these functions.
Extended date format modifiers are available on glib v2.56.
eel-glib-extensions.h/c:
GDate * eel_g_date_new_tm (struct tm *time_pieces);
char * eel_strdup_strftime (const char *format, struct tm *time_pieces);
gint64 eel_get_system_time (void);
Do not need to test the extensions in eel_self_check_glib_extensions (void).
eel-glib-extensions.c:
static void check_tm_to_g_date (time_t time)
static char * test_strftime (...)
Do not need to check if strftime implements extended date format modifiers on the system (available on glibc v2.27).
configure.ac
|
|
Fixes 'cppcheck' warnings:
[eel/eel-background.c:163]: (style) The scope of the variable 'intensity' can be reduced.
[eel/eel-background.c:163]: (style) The scope of the variable 'saturation' can be reduced.
[eel/eel-background.c:196]: (style) The scope of the variable 'end_color' can be reduced.
[eel/eel-canvas-rect-ellipse.c:600]: (style) The scope of the variable 'tmp' can be reduced.
[eel/eel-canvas-rect-ellipse.c:705]: (style) The scope of the variable 'width_pixels' can be reduced.
[eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_lt' can be reduced.
[eel/eel-canvas-rect-ellipse.c:706]: (style) The scope of the variable 'width_rb' can be reduced.
[eel/eel-canvas.c:1420]: (style) The scope of the variable 'child' can be reduced.
[eel/eel-canvas.c:1493]: (style) The scope of the variable 'i' can be reduced.
[eel/eel-canvas.c:1518]: (style) The scope of the variable 'i' can be reduced.
[eel/eel-canvas.c:1545]: (style) The scope of the variable 'i' can be reduced.
[eel/eel-canvas.c:1599]: (style) The scope of the variable 'child' can be reduced.
[eel/eel-canvas.c:2598]: (style) The scope of the variable 'cx' can be reduced.
[eel/eel-canvas.c:2598]: (style) The scope of the variable 'cy' can be reduced.
[eel/eel-debug.c:80]: (style) The scope of the variable 'f' can be reduced.
[eel/eel-editable-label.c:1493]: (style) The scope of the variable 'clip' can be reduced.
[eel/eel-editable-label.c:1571]: (style) The scope of the variable 'text' can be reduced.
[eel/eel-editable-label.c:2270]: (style) The scope of the variable 'anchor' can be reduced.
[eel/eel-editable-label.c:2270]: (style) The scope of the variable 'end' can be reduced.
[eel/eel-editable-label.c:3054]: (style) The scope of the variable 'menuitem' can be reduced.
[eel/eel-editable-label.c:3400]: (style) The scope of the variable 'index' can be reduced.
[eel/eel-gdk-pixbuf-extensions.c:85]: (style) The scope of the variable 'scale' can be reduced.
[eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_x1' can be reduced.
[eel/eel-gdk-pixbuf-extensions.c:283]: (style) The scope of the variable 's_y2' can be reduced.
[eel/eel-gdk-pixbuf-extensions.c:284]: (style) The scope of the variable 's_xfrac' can be reduced.
[eel/eel-glib-extensions.c:439]: (style) The scope of the variable 'compare_result' can be reduced.
[eel/eel-glib-extensions.c:561]: (style) The scope of the variable 'hash_table_to_free' can be reduced.
[eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixsrc' can be reduced.
[eel/eel-graphic-effects.c:74]: (style) The scope of the variable 'pixdest' can be reduced.
[eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixsrc' can be reduced.
[eel/eel-graphic-effects.c:137]: (style) The scope of the variable 'pixdest' can be reduced.
[eel/eel-graphic-effects.c:195]: (style) The scope of the variable 'pixsrc' can be reduced.
[eel/eel-graphic-effects.c:196]: (style) The scope of the variable 'pixdest' can be reduced.
[eel/eel-graphic-effects.c:245]: (style) The scope of the variable 'slab_width' can be reduced.
[eel/eel-graphic-effects.c:262]: (style) The scope of the variable 'slab_height' can be reduced.
[eel/eel-graphic-effects.c:282]: (style) The scope of the variable 'y' can be reduced.
[eel/eel-gtk-extensions.c:165]: (style) The scope of the variable 'screen' can be reduced.
[eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_width' can be reduced.
[eel/eel-gtk-extensions.c:167]: (style) The scope of the variable 'screen_height' can be reduced.
[eel/eel-gtk-extensions.c:168]: (style) The scope of the variable 'scale' can be reduced.
[eel/eel-labeled-image.c:1051]: (style) The scope of the variable 'x_alignment' can be reduced.
[eel/eel-labeled-image.c:1052]: (style) The scope of the variable 'y_alignment' can be reduced.
[eel/eel-labeled-image.c:1100]: (style) The scope of the variable 'x_alignment' can be reduced.
[eel/eel-labeled-image.c:1101]: (style) The scope of the variable 'y_alignment' can be reduced.
[eel/eel-mate-extensions.c:73]: (style) The scope of the variable 'quoted' can be reduced.
[eel/eel-stock-dialogs.c:409]: (style) The scope of the variable 'button_title' can be reduced.
[eel/eel-string.c:415]: (style) The scope of the variable 'i' can be reduced.
[eel/eel-string.c:542]: (style) The scope of the variable 'type' can be reduced.
[eel/eel-vfs-extensions.c:65]: (style) The scope of the variable 'valid_bytes' can be reduced.
[eel/eel-wrap-table.c:766]: (style) The scope of the variable 'hadj' can be reduced.
[eel/eel-wrap-table.c:766]: (style) The scope of the variable 'vadj' can be reduced.
|
|
|
|
Fixes cppcheck warnings:
[eel-string.c:681]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:682]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:683]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:684]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:697]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:698]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:699]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:700]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:709]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:710]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:714]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:720]: (error) va_list 'va' used before va_start() was called.
[eel-string.c:722]: (error) va_list 'va' used before va_start() was called.
|
|
Fixes 'flawfinder' warning:
(buffer) memcpy: Does not check for buffer overflows when copying to destination (CWE-120). Make sure destination can always hold the source data.
|
|
|
|
|
|
|
|
Fixes Clang static analyzer warning:
eel-string.c:319:13: warning: Memory copy function overflows destination buffer
memcpy (result_position, p, remaining_length);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
eel-string.c:325:9: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcpy (result_position, replacement, replacement_length);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
GNOME/nautilus@b4d200f
https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
|
|
GNOME/nautilus@7af24a8
Replace
GList * eel_g_object_list_copy (GList *list)
with
g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
|
|
Fixes Clang static analyzer warning:
eel-editable-label.c:2624:9: warning: 2nd function call argument is an uninitialized value
if (pango_layout_line_x_to_index (line,
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
GNOME/nautilus@61e2aff
Replace eel_g_str_list_copy(Glist *list)
with g_list_copy_deep (list, (GCopyFunc) g_strdup, NULL)
|
|
|
|
|
|
Fixes Clang static analyzer warning:
eel-canvas.c:3426:9: warning: Undefined or garbage value returned to caller
return item;
^~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
eel-gdk-pixbuf-extensions.c:403:29: warning: Division by zero
*dest++ = r / n_pixels;
~~^~~~~~~~~~
|
|
to avoid warnings with Clang Analyzer
|
|
|
|
Replace G_DEFINE_TYPE_WITH_CODE with G_DEFINE_TYPE_WITH_PRIVATE macro
|
|
With minimal changes to avoid deprecated g_type_class_add_private
|
|
'g_strconcat' needs to be freed
|
|
"menus-have-icons" set
|
|
|
|
Fix https://github.com/mate-desktop/caja/issues/996
|
|
drop "Input Methods"
|