Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
Fixes Clang static analyzer warnings:
caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error')
if (error->code != G_IO_ERROR_FAILED_HANDLED) {
^~~~~~~~~~~
caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
details = error->message;
^~~~~~~~~~~~~~
|
|
GNOME/nautilus@7af24a8
Replace
GList * eel_g_object_list_copy (GList *list)
with
g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
|
|
False positive warning with Clang static analyzer:
caja-file-operations.c:958:11: warning: Cast a region whose size is not a multiple of the destination type size
common = g_malloc0 (job_size);
^~~~~~~~~~~~~~~~~~~~
|
|
to avoid warnings with Clang Analyzer
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
the file.
|
|
Add an option to show a confirmation dialog when moving files to the
trash, like there is for deleting files directly or emptying the trash.
Closes #632.
|
|
Do not send "it is not safe to remove the drive" notifcation on unmount of internal drive or other non-ejectable device. Also stop incorrect notification on cancelled eject operation (as when mounted by another user and not authorized to eject).
|
|
Defaults to TRUE
|
|
We no longer need to use any GtkApplication features for this so enable it in libunique builds too. Tested with and without libunique in GTK 3.22
|
|
The desktop icon eject code required a function in libcaja-private so we no longer need it in caja-application.c
|
|
Show desktop notifications for ejecting a drive from the desktop as well.The code in caja-file-operations won't show notifications from the sidebar so that code is still needed too.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Also, threads area always enabled, so we can remove the
G_THREADS_ENABLED conditionals.
Require GLib 2.31 for this.
taken from:
https://git.gnome.org/browse/nautilus/commit/?h=gnome-3-4&id=0594aa1
Note, this fixes a Wimplicit-function-declaration warning
in caja-search-engine-simple
|
|
Closes https://github.com/mate-desktop/caja/pull/372
|
|
|
|
CppCheck detected a few 'always false' expressions in caja.
First two definitely appeareed due to copy-paste (mime-types
comparison). It would be nice to move x_content_type's and corresponding
greetings to some table (array of structs), wouldn't it?
The last one looks like copy-paste problem too. There were two identical
blocks of code in move_file_prepare() checking conflict type. BTW, there
is exactly the same code in the same file inside copy_move_file().
According to DRY, it would be nice to move this code to its own
function.
|
|
Contains also a typo fix for the previous commit
Closes #203
https://github.com/mate-desktop/caja/issues/203
|
|
Bump minimum glib version accordingly
|
|
GCC 4.6 introduced a new warning about variables declared and initialized,
but not really used in the function body. Remove all of these occurrences
to build cleanly.
http://git.gnome.org/browse/nautilus/commit/?id=d4230de8667764e02dbb966b5d806ff78ced2fd5
|
|
Also fixes a double-free regression in lc-p/caja-query from 7a42b9b0
|
|
Was: general: use g_list_free_full() instead of eel functions
http://git.gnome.org/browse/nautilus/commit/?id=5e669515fd7f760382e6b7aa1449734a35a2d7f4
.
Instead of g_list_free_full(), we use g_list_foreach and g_list_free() to avoid
unnecessary glib dependency bump to 2.28
|
|
This covers 4 commits:
file-operations: use GtkMessageDialog
http://git.gnome.org/browse/nautilus/commit/?id=51ec5861ca0697e802e8c003053211ac12f2fd54
mime-actions: use GtkMessageDialog
http://git.gnome.org/browse/nautilus/commit/?id=7a3dcdd4bf667aac271be74988770e18575a7df2
tree-view: don't include eel-alert-dialog.h
http://git.gnome.org/browse/nautilus/commit/?id=930af7f3058eed256a42c0c1558c7307bb93f411
[eel] use GtkMessageDialog for stock dialogs
http://git.gnome.org/browse/nautilus/commit/?id=82c5b6c0d82ebd8a705d542fcc9aa58e6e9b0da4
|
|
http://git.gnome.org/browse/nautilus/commit/?id=f080b86daeb571def4c092e1524e9adfc7700699
|
|
|
|
|
|
|
|
|