Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixes https://github.com/mate-desktop/caja/issues/1183
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
Fixed make distcheck, see #1129
|
|
|
|
Changed CajaIconCanvasItem, CajaTrashMonitor and CajaUndoStackManager
|
|
Changed CajaFileConflictDialog and CajaFile
|
|
Changed CajaDesktopLink, CajaDirectoryAsync and CajaDirectory
|
|
Changed CajaClipboardMonitor, CajaColumnChooser and CajaDesktopIconFile
|
|
Remove unused variables, avoid uninitialized variable warnings, and indent code.
|
|
|
|
Thanks for Leslie Zhai's patch.
|
|
An example of when the MIME type might change: a file is initially created
with 0 bytes of content, but more data is added later. Empty files are always
detected as plain text, but the file might not be empty anymore when the user
opens it.
This commit affects the behavior when double-clicking a file and when right-
clicking on it too.
|
|
Fixes https://github.com/mate-desktop/caja/issues/1099
|
|
|
|
|
|
|
|
|
|
|
|
- remove the "Working..." notification
- show the "Process completed" notification only if the progress window is inactive
|
|
org.mate.caja.preferences.show-notifications
Closes https://github.com/mate-desktop/caja/issues/1093
|
|
'g_strconcat' needs to be freed
|
|
'g_strconcat' needs to be freed
|
|
Fixed running caja_self_check_directory failed.
|
|
Don't treat remote filesystems differently when unmounting
|
|
We crash in g_hash_table_lookup_extended if the file's symlink_name is
set but the file is not a symlink, since the hash function (g_str_hash)
does not allow NULL values but target_uri is NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=711583
Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/c2a5e052
|
|
Fix https://github.com/mate-desktop/caja/issues/1066 "Caja caches folders from usb drives/disk"
Nowadays, we rely on G_FILE_MONITOR_EVENT_UNMOUNTED to be emitted when a
mount disappears, since we already monitor the directory, in order to
switch the view to a different location.
Since non-native mounts very likely won't have file monitoring though,
we're not going to receive such events in that case, and fail to
redirect the view as a consequence.
This patch fixes it by listening to the mount-removed signal on
GVolumeMonitor when a monitor is requested for a non-native mount, and
emulating a file removal in that case.
Backport Nautilus commit gitlab.gnome.org/GNOME/nautilus/commit/3891241ba760c59d284b7579dbd340651c8d4d29
note that caja_get_mounted_mount_for_root had to be added, while the equivalent Nautilus function was from a prior commit
|
|
The caja_icon_info_lookup method was potentially doing multiple
icon lookups for a single icon, as well as triggering an additional
fallback lookup when returning an empty (no pixbuf) CajaIconInfo
to CajaFile.
This streamlines and simplifies the lookup process. The hash table
lookup always occurs first, before any Gtk icon cache lookup is made
(these are expensive, according to perf analysis,) and a returned
icon info will *always* be added to a hash table, potentially already
containing a fallback icon.
GIcons stringify well enough to use the strings exclusively for hash
keys. This eliminates the extra cost of looking up filenames from the
Gtk icon cache.
Ported from
github.com/linuxmint/nemo/commit/98843e26b48cd3526cacfe90cfa4ba201d1f3aee
where this benchmark resulted for Nemo:
.# sync; echo 3 > /proc/sys/vm/drop_caches
mtwebster:~/bin/nemo[master]> NEMO_BENCHMARK_LOADING=1 nemo /usr/bin
with:
Nemo startup time: 2.011817 seconds
Folder load time: 1.158854 seconds
Idle...Folder load time: 1.226699 seconds
without:
Nemo startup time: 2.464361 seconds
Folder load time: 1.591494 seconds
Idle...Folder load time: 1.692273 seconds
|
|
If true the gsettings key "ctrl-tab-switch-tabs" into "org.mate.caja.preferences"
Closes https://github.com/mate-desktop/caja/issues/768
|
|
Prevent segfault on g_list_find in directory_ready_callback by catching the NULL case
|
|
Remove two functions now unused after github.com/mate-desktop/caja/commit/191aa3992171c84134f0359a960e5bebc7bfeca4 "libcaja-private: remove redundant prefs application to hash table "
|
|
These preferences are all applied elsewhere and all work without this. Removing it stops the g_hash_table_foreach warnings with GTK 3.23.0
|
|
The string returned by eel_bg_get_desktop_color() needs to be freed by
the caller, which wasn't happening before.
Commit b9cf3667 fixed the case where this function was being called
repeatedly, triggering this leak and causing it to rapidly fill system
memory.
|
|
|
|
|
|
|
|
Fixes https://github.com/mate-desktop/caja/pull/1001#issuecomment-394072477
|
|
Fixes https://github.com/mate-desktop/caja/pull/962#issuecomment-389114129
|
|
|
|
|
|
follow-up to ddf6f38db4e842abecd4f2ee77012050822b3775
|
|
Replace deprecated gtk_menu_popup in eel-editable-label,caja-dnd, emblem-sidebar,caja-side-pane, fm-tree-view, caja-navigation-window-pane, and caja-zoom-control
|
|
replace
gdk_error_trap_push
gdk_error_trap_pop_ignored
|
|
fixes this warning:
caja-undostack-manager.c: In function 'retrieve_files_to_restore':
caja-undostack-manager.c:1967:38: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses]
if (!(g_hash_table_size (trashed)) > 0) {
^
caja-undostack-manager.c:1967:7: note: add parentheses around left hand side expression to silence this warning
if (!(g_hash_table_size (trashed)) > 0) {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
( )
|
|
|
|
When the icon container is repopulated (e.g. when using back/forward)
finish_adding_new_icons is called leading to an accessible children-
changed event flood. We can distinguish these unwanted notifications
from desired notifications by comparing the number of new icons to add
with the size of the container's icon set.
|
|
Accessible children-changed events should only be emitted when a user-
triggered action (creation of file, copying an item) causes an item to
be added.
Set container->details->is_loading (which does not seem to be used
anywhere) in caja_icon_container_request_update_all because if the
entire container is being updated, children-changed events should not
be emitted for each updated icon.
|
|
caja_icon_canvas_item_set_property was emitting accessible-name-change
signals whenever the PROP_EDITABLE_TEXT was being set for an icon. This
method is called by caja_icon_container_request_update_all when the icon
view is first loaded. Thus irrelevant events are being emitted (the name
of each icon didn't change, as far as the user is concerned). Furthermore,
this floods assistive technologies any time the user opens a folder with
a large number of files.
Moving the notification out of caja_icon_canvas_item_set_property and
into end_renaming_mode (where ICON_TEXT_CHANGED is also emitted) solves
the problem of floods of irrelevant notifications while still emitting
the signal when the name actually changes.
|