summaryrefslogtreecommitdiff
path: root/libcaja-private
AgeCommit message (Collapse)AuthorFilesLines
2020-03-06fix runtime warning from newly unused codelukefromdc1-10/+1
Remove now unused confirm_delete property Fix warning "caja-undostack-manager.c:323: invalid property id 2 for "confirm-delete" of type 'GParamBoolean' in 'CajaUndoStackManager' " caused by newly unused property
2020-03-04Confirm before deleting during an undo operationlukefromdc1-24/+6
Unless user turns 'Ask before emptying trash or deleting files" off. Remove special case direct delete code that broke this behavior Also remove now unused priv->confirm_delete As we no longer use unique code directly deleting files that used it
2020-02-01Fix build using gcc 10 -fno-common flagrbuj2-12/+25
2020-01-10Make device ejection notifications translatableJonathan Michalon1-2/+2
2019-12-15libcaja-private/caja-file: redundant conditionrbuj1-4/+3
'!A || (A && B)' is equivalent to '!A || B'
2019-11-30avoid redundant redeclarationsPablo Barciela10-34/+9
2019-11-22canvas-item: Don't hyphenate filenamesraveit651-0/+22
fixes https://github.com/mate-desktop/caja/issues/1284 Pango 1.44 got the ability to automatically hyphenate on line breaks, which is on by default, but can be set off by a new attribute. As a result, we now hyphenate filenames, which is confusing, because a filename may already include hyphens. To restore the previous behavior, let's not insert hyphens when breaking filenames in multiple lines. Inspired by https://gitlab.gnome.org/GNOME/nautilus/commit/9738d85
2019-09-28caja-extensions: allows the translation of copyrightrbuj1-3/+10
2019-08-26Set FmWidgetView is single view.Wu Xiaotian2-2/+10
2019-08-19Remove comments that are not written to translators from pot filerbuj3-34/+34
2019-08-18caja-progress-info: use NotifyNotification instead of GNotificationPablo Barciela1-14/+12
Fixes https://github.com/mate-desktop/caja/issues/1285
2019-08-15Copy file and keep timestamps of original file including remotesrbuj1-1/+8
The timestamps are reset to the current time, even if the source & target folders support these GFileInfo attributes. Closes #1226
2019-08-02Support querying files by contained textSlava Aseev3-1/+142
ODF files also supported via odt2txt
2019-07-27use show icons option in views tabWu Xiaotian2-5/+5
2019-07-27Add preference option to hide icons in list view.Wu Xiaotian2-0/+6
2019-07-24add git.mk to generate .gitignoreWu Xiaotian1-0/+2
2019-07-10Replace gdkpixbuf with cairo_surfaces in a few more placesVictor Kareh2-26/+0
2019-07-05Render file-conflict icons as cairo_surface vectorsVictor Kareh3-42/+68
2019-07-05file-conflict-dialog: don't scale icons twice on hidpi monitorslukefromdc1-4/+4
Hardcode scale factor to 1 in caja_file_get_icon_pixbuf functions in caja-file-conflict as these icons are already getting scaled elsewhere. Otherwise they get scaled twice and the whole dialog is ballooned oversize on hidpi *Based on similar change made in Nautilus as a small part of fd01842f996b7d07baf2aafb0f68308fc5ed2055 "file-conflict-dialog: separate file logic from UI management " which was a more general refactoring of the file conflict dialog and split out the frontend and backend code.
2019-07-01hidpi: ensure all icons are properly scaledlukefromdc1-2/+2
2019-07-01migrate intltool to gettextWu Xiaotian1-2/+0
2019-06-30desktop: Always draw the items label frameColomban Wendling1-12/+16
Draw the frame under the items label even when not selected and not in prelight state, so that it is possible to theme it in the other states. However we still don't draw it when editing, because there is the editing widget frame already and drawing the label's one might slightly overflow the editing widget's borders and lead to slightly ugly results. Being able to draw a background is especially useful for accessibility purposes (e.g. a high contrast theme would typically make sure there is a background with enough contrast), but might be useful to all as desktop backgrounds are often not uniform at all. By default this is drawn transparent on the non-selected and non-prelight states (no change in default appearance then), but allows the user to customize it with a background if need be. Unfortunately for the moment this cannot be altered by theme, so the user will have to modify the GTK custom user CSS directly, but it still is better than nothing and can hopefully be solved better later.
2019-06-28Fix cppcheck warningsPablo Barciela2-22/+22
appeared since the silence of deprecated gtkaction warnings
2019-06-25caja-ui-utilities: suppress GtkAction warningsraveit651-0/+12
2019-06-25caja-clipboard: suppress GtkAction warningsraveit651-0/+10
2019-06-18Remove trailing whitespacesrbuj14-59/+59
find . -regextype posix-extended -regex '.*\.(c|h|ac|txt|xml)' -exec sed --in-place 's/[[:space:]]\+$//' {} \+
2019-06-15caja-open-with-dialog: cppcheck: Redundant conditionPablo Barciela1-2/+1
Fixes cppcheck warning: [libcaja-private/caja-open-with-dialog.c:265]: (style) Redundant condition: !dialog->details->add_mode. 'A || (!A && B)' is equivalent to 'A || B'
2019-06-11Change URL prefixes from http to httpsrbuj3-3/+3
2019-06-09caja-progress-info: add tooltips to file transfer dialogPablo Barciela1-0/+4
Fixes https://github.com/mate-desktop/caja/issues/845
2019-06-09Add accessible names for buttons in file transfer operations dialogLuke Yelavich1-0/+4
2019-05-06libcaja-private: reduce the scope of some variablesPablo Barciela44-476/+794
2019-05-04eel: remove date & time functionsrbuj4-29/+27
Do not need to extend glib library, since it now incorporates these functions. Extended date format modifiers are available on glib v2.56. eel-glib-extensions.h/c: GDate * eel_g_date_new_tm (struct tm *time_pieces); char * eel_strdup_strftime (const char *format, struct tm *time_pieces); gint64 eel_get_system_time (void); Do not need to test the extensions in eel_self_check_glib_extensions (void). eel-glib-extensions.c: static void check_tm_to_g_date (time_t time) static char * test_strftime (...) Do not need to check if strftime implements extended date format modifiers on the system (available on glibc v2.27). configure.ac
2019-04-14caja-file-utilities: Fix cast from non-struct type to struct typePablo Barciela1-1/+1
Fixes Clang static analyzer warning: caja-file-utilities.c:283:12: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption return (XdgDirEntry *)g_array_free (array, FALSE); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-04-12local #include files who are libraries inside <> instead ""Pablo Barciela55-141/+143
2019-04-12eel: remove eel_g_object_list_refrbuj1-1/+1
2019-04-10drop functions defined but not usedPablo Barciela1-9/+0
2019-04-10local #include files inside "" instead <>Pablo Barciela87-381/+450
2019-04-10caja-icon-canvas-item: avoid 'cppcheck' warningPablo Barciela1-14/+13
Fixes 'cppcheck' warning: [libcaja-private/caja-icon-canvas-item.c:850]: (error) Uninitialized variable: real_text_height
2019-04-10caja-file: avoid shifting signed 32-bit value by 31 bitsPablo Barciela1-1/+1
Fixes cppcheck warnings: [libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour [libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
2019-04-08caja-icon-canvas-item: initialize variable 'scale'Pablo Barciela1-1/+1
Fixes cppcheck warning: [libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
2019-04-05caja-file-operations: make sure 'error' isn't NULLPablo Barciela1-2/+2
Fixes Clang static analyzer warnings: caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error') if (error->code != G_IO_ERROR_FAILED_HANDLED) { ^~~~~~~~~~~ caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') details = error->message; ^~~~~~~~~~~~~~
2019-04-03caja-open-with-dialog: make sure there is error before showing itPablo Barciela1-2/+5
Fixes Clang static analyzer warning: caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error') message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message); ^~~~~~~~~~~~~~
2019-03-30caja-progress-info: make sure argument is initializedPablo Barciela1-3/+3
Fixes Clang static analyzer warning: caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value g_notification_set_body (notification, _("Process completed")); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-29eel: replace eel_ref_str with GRefStringrbuj5-95/+93
GNOME/nautilus@b4d200f https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
2019-03-29eel: remove g_object_list_copyrbuj2-6/+6
GNOME/nautilus@7af24a8 Replace GList * eel_g_object_list_copy (GList *list) with g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
2019-03-24caja-file: Fix incomplete file replacement dialogPablo Barciela1-9/+5
Fixes https://github.com/mate-desktop/caja/issues/1183
2019-03-24caja-autorun: avoid NULL in 'memcpy'Pablo Barciela1-1/+4
Fixes Clang static analyzer warning: caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter memcpy (r, v, len * sizeof (char *)); ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
2019-03-22caja-file: Fix: true and false branches are identicalPablo Barciela1-2/+0
Fixes Clang static analyzer warning: caja-file.c:4858:9: warning: true and false branches are identical } else if (file_date_age < 7) { ^
2019-03-22caja-file-operations: add comment with false positive warning:Pablo Barciela1-0/+8
False positive warning with Clang static analyzer: caja-file-operations.c:958:11: warning: Cast a region whose size is not a multiple of the destination type size common = g_malloc0 (job_size); ^~~~~~~~~~~~~~~~~~~~
2019-03-07eel: remove g_str_list_copyrbuj3-7/+7
GNOME/nautilus@61e2aff Replace eel_g_str_list_copy(Glist *list) with g_list_copy_deep (list, (GCopyFunc) g_strdup, NULL)