Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
|
|
|
|
|
|
Hardcode scale factor to 1 in caja_file_get_icon_pixbuf functions in caja-file-conflict as these icons are already getting scaled elsewhere. Otherwise they get scaled twice and the whole dialog is ballooned oversize on hidpi
*Based on similar change made in Nautilus as a small part of fd01842f996b7d07baf2aafb0f68308fc5ed2055 "file-conflict-dialog: separate file logic from UI management " which was a more general refactoring of the file conflict dialog and split out the frontend and backend code.
|
|
|
|
|
|
Draw the frame under the items label even when not selected and not in
prelight state, so that it is possible to theme it in the other states.
However we still don't draw it when editing, because there is the
editing widget frame already and drawing the label's one might slightly
overflow the editing widget's borders and lead to slightly ugly
results.
Being able to draw a background is especially useful for accessibility
purposes (e.g. a high contrast theme would typically make sure there is
a background with enough contrast), but might be useful to all as
desktop backgrounds are often not uniform at all.
By default this is drawn transparent on the non-selected and
non-prelight states (no change in default appearance then), but allows
the user to customize it with a background if need be.
Unfortunately for the moment this cannot be altered by theme, so the
user will have to modify the GTK custom user CSS directly, but it still
is better than nothing and can hopefully be solved better later.
|
|
appeared since the silence of deprecated gtkaction warnings
|
|
|
|
|
|
find . -regextype posix-extended -regex '.*\.(c|h|ac|txt|xml)' -exec sed --in-place 's/[[:space:]]\+$//' {} \+
|
|
Fixes cppcheck warning:
[libcaja-private/caja-open-with-dialog.c:265]: (style) Redundant condition: !dialog->details->add_mode. 'A || (!A && B)' is equivalent to 'A || B'
|
|
|
|
Fixes https://github.com/mate-desktop/caja/issues/845
|
|
|
|
|
|
Do not need to extend glib library, since it now incorporates these functions.
Extended date format modifiers are available on glib v2.56.
eel-glib-extensions.h/c:
GDate * eel_g_date_new_tm (struct tm *time_pieces);
char * eel_strdup_strftime (const char *format, struct tm *time_pieces);
gint64 eel_get_system_time (void);
Do not need to test the extensions in eel_self_check_glib_extensions (void).
eel-glib-extensions.c:
static void check_tm_to_g_date (time_t time)
static char * test_strftime (...)
Do not need to check if strftime implements extended date format modifiers on the system (available on glibc v2.27).
configure.ac
|
|
Fixes Clang static analyzer warning:
caja-file-utilities.c:283:12: warning: Casting a non-structure type to a structure type and accessing a field can lead to memory access errors or data corruption
return (XdgDirEntry *)g_array_free (array, FALSE);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
|
|
|
|
|
|
Fixes 'cppcheck' warning:
[libcaja-private/caja-icon-canvas-item.c:850]: (error) Uninitialized variable: real_text_height
|
|
Fixes cppcheck warnings:
[libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
|
|
Fixes cppcheck warning:
[libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
|
|
Fixes Clang static analyzer warnings:
caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error')
if (error->code != G_IO_ERROR_FAILED_HANDLED) {
^~~~~~~~~~~
caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
details = error->message;
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message);
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value
g_notification_set_body (notification, _("Process completed"));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
GNOME/nautilus@b4d200f
https://developer.gnome.org/glib/stable/glib-Reference-counted-strings.html
|
|
GNOME/nautilus@7af24a8
Replace
GList * eel_g_object_list_copy (GList *list)
with
g_list_copy_deep (list, (GCopyFunc) g_object_ref, NULL)
|
|
Fixes https://github.com/mate-desktop/caja/issues/1183
|
|
Fixes Clang static analyzer warning:
caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcpy (r, v, len * sizeof (char *));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-file.c:4858:9: warning: true and false branches are identical
} else if (file_date_age < 7) {
^
|
|
False positive warning with Clang static analyzer:
caja-file-operations.c:958:11: warning: Cast a region whose size is not a multiple of the destination type size
common = g_malloc0 (job_size);
^~~~~~~~~~~~~~~~~~~~
|
|
GNOME/nautilus@61e2aff
Replace eel_g_str_list_copy(Glist *list)
with g_list_copy_deep (list, (GCopyFunc) g_strdup, NULL)
|
|
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
|
|
Fixed make distcheck, see #1129
|
|
|
|
Changed CajaIconCanvasItem, CajaTrashMonitor and CajaUndoStackManager
|
|
Changed CajaFileConflictDialog and CajaFile
|
|
Changed CajaDesktopLink, CajaDirectoryAsync and CajaDirectory
|
|
Changed CajaClipboardMonitor, CajaColumnChooser and CajaDesktopIconFile
|
|
Remove unused variables, avoid uninitialized variable warnings, and indent code.
|
|
|