summaryrefslogtreecommitdiff
path: root/libcaja-private
AgeCommit message (Collapse)AuthorFilesLines
2019-03-07avoid variables set but not usedPablo Barciela5-13/+2
2019-03-06caja-file: Fix use of memory after it is freedPablo Barciela1-7/+13
to avoid warning with Clang Analyzer
2019-03-05caja-icon-container: Fix use of memory after it is freedPablo Barciela1-2/+2
to avoid warning with Clang Analyzer
2019-03-04caja-tree-view-drag-dest: Fix memory leakPablo Barciela1-0/+1
to avoid warning with Clang Analyzer
2019-03-04[Security] Use 'g_strlcpy' instead of 'strcpy'Pablo Barciela1-3/+3
to avoid warnings with Clang Analyzer
2019-03-04drop unused variablesPablo Barciela3-4/+0
2019-02-06Add --disable-self-check for configureWu Xiaotian1-5/+1
Fixed make distcheck, see #1129
2019-02-02Fix incompatible pointer typesVictor Kareh1-2/+2
2019-01-31Avoid deprecated g_type_class_add_private under libcaja-privateWu Xiaotian5-45/+29
Changed CajaIconCanvasItem, CajaTrashMonitor and CajaUndoStackManager
2019-01-31Avoid deprecated g_type_class_add_private under libcaja-privateWu Xiaotian6-30/+27
Changed CajaFileConflictDialog and CajaFile
2019-01-31Avoid deprecated g_type_class_add_private under libcaja-privateWu Xiaotian5-63/+76
Changed CajaDesktopLink, CajaDirectoryAsync and CajaDirectory
2019-01-31Avoid deprecated g_type_class_add_private under libcaja-privateWu Xiaotian6-27/+15
Changed CajaClipboardMonitor, CajaColumnChooser and CajaDesktopIconFile
2019-01-29Fix compile warningWu Xiaotian2-3/+1
Remove unused variables, avoid uninitialized variable warnings, and indent code.
2019-01-28Fixed the value of 6 month and 1 year.Wu Xiaotian3-21/+18
2019-01-28Support querying files by modification time and sizeWu Xiaotian3-18/+91
Thanks for Leslie Zhai's patch.
2019-01-03[libcaja-private] Re-check file MIME type before picking an application.Max Eliaser3-0/+30
An example of when the MIME type might change: a file is initially created with 0 bytes of content, but more data is added later. Empty files are always detected as plain text, but the file might not be empty anymore when the user opens it. This commit affects the behavior when double-clicking a file and when right- clicking on it too.
2018-12-27Fix: weird item in bookmarks if the folder was removedPablo Barciela1-2/+7
Fixes https://github.com/mate-desktop/caja/issues/1099
2018-12-27Minor code-quality enhancementsSargastic2-6/+7
2018-12-27Forgot to initialize is_backup fieldSargastic1-0/+1
2018-12-27Remove useless comments, correct description stringSargastic1-1/+1
2018-12-27Skip hidden files only, not backupsSargastic1-3/+1
2018-12-27Add independent show/hide backup filesSargastic11-14/+83
2018-12-27caja-progress-info: new behavior with notifications:Pablo Barciela1-10/+3
- remove the "Working..." notification - show the "Process completed" notification only if the progress window is inactive
2018-12-27caja-progress-info: show notifications with the gsettings key:Pablo Barciela2-8/+22
org.mate.caja.preferences.show-notifications Closes https://github.com/mate-desktop/caja/issues/1093
2018-12-01caja-bookmark: Fix memory leakPablo Barciela1-1/+4
'g_strconcat' needs to be freed
2018-12-01caja-desktop-link-monitor: Fix memory leakPablo Barciela1-4/+5
'g_strconcat' needs to be freed
2018-11-17GSettings should init beforce use it.yetist1-0/+1
Fixed running caja_self_check_directory failed.
2018-11-02monitor: fix crash on unmounting remote filesystemslukefromdc1-2/+2
Don't treat remote filesystems differently when unmounting
2018-11-02CajaFile: fix crash in modify_link_hash_tableMichael Catanzaro1-1/+1
We crash in g_hash_table_lookup_extended if the file's symlink_name is set but the file is not a symlink, since the hash function (g_str_hash) does not allow NULL values but target_uri is NULL. https://bugzilla.gnome.org/show_bug.cgi?id=711583 Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/c2a5e052
2018-10-20monitor: watch for removal of non-native mounts on GVolumeMonitorlukefromdc3-10/+96
Fix https://github.com/mate-desktop/caja/issues/1066 "Caja caches folders from usb drives/disk" Nowadays, we rely on G_FILE_MONITOR_EVENT_UNMOUNTED to be emitted when a mount disappears, since we already monitor the directory, in order to switch the view to a different location. Since non-native mounts very likely won't have file monitoring though, we're not going to receive such events in that case, and fail to redirect the view as a consequence. This patch fixes it by listening to the mount-removed signal on GVolumeMonitor when a monitor is requested for a non-native mount, and emulating a file removal in that case. Backport Nautilus commit gitlab.gnome.org/GNOME/nautilus/commit/3891241ba760c59d284b7579dbd340651c8d4d29 note that caja_get_mounted_mount_for_root had to be added, while the equivalent Nautilus function was from a prior commit
2018-10-03Caja-icon-info: Optimize icon lookups by GIcon.lukefromdc2-149/+74
The caja_icon_info_lookup method was potentially doing multiple icon lookups for a single icon, as well as triggering an additional fallback lookup when returning an empty (no pixbuf) CajaIconInfo to CajaFile. This streamlines and simplifies the lookup process. The hash table lookup always occurs first, before any Gtk icon cache lookup is made (these are expensive, according to perf analysis,) and a returned icon info will *always* be added to a hash table, potentially already containing a fallback icon. GIcons stringify well enough to use the strings exclusively for hash keys. This eliminates the extra cost of looking up filenames from the Gtk icon cache. Ported from github.com/linuxmint/nemo/commit/98843e26b48cd3526cacfe90cfa4ba201d1f3aee where this benchmark resulted for Nemo: .# sync; echo 3 > /proc/sys/vm/drop_caches mtwebster:~/bin/nemo[master]> NEMO_BENCHMARK_LOADING=1 nemo /usr/bin with: Nemo startup time: 2.011817 seconds Folder load time: 1.158854 seconds Idle...Folder load time: 1.226699 seconds without: Nemo startup time: 2.464361 seconds Folder load time: 1.591494 seconds Idle...Folder load time: 1.692273 seconds
2018-08-01add the ability to switch tabs using [ctrl+tab] and [ctrl+shift+tab]Pablo Barciela1-0/+5
If true the gsettings key "ctrl-tab-switch-tabs" into "org.mate.caja.preferences" Closes https://github.com/mate-desktop/caja/issues/768
2018-07-15caja-desktop-directory: stop segfaults in directory_ready_callbacklukefromdc1-0/+4
Prevent segfault on g_list_find in directory_ready_callback by catching the NULL case
2018-07-12caja-directory.c: fix build warninglukefromdc1-31/+0
Remove two functions now unused after github.com/mate-desktop/caja/commit/191aa3992171c84134f0359a960e5bebc7bfeca4 "libcaja-private: remove redundant prefs application to hash table "
2018-07-11libcaja-private: remove redundant prefs application to hash tablelukefromdc1-47/+0
These preferences are all applied elsewhere and all work without this. Removing it stops the g_hash_table_foreach warnings with GTK 3.23.0
2018-07-11[desktop-bg] Fix memory leak during background change eventsLars R. Damerow1-2/+5
The string returned by eel_bg_get_desktop_color() needs to be freed by the caller, which wasn't happening before. Commit b9cf3667 fixed the case where this function was being called repeatedly, triggering this leak and causing it to rapidly fill system memory.
2018-06-07caja-progress-info.c: show notifications in begin/end of progressPablo Barciela1-4/+18
2018-06-07caja-progress-info.c: avoid deprecated 'gtk_status_icon_get_visible'Pablo Barciela1-2/+5
2018-06-04avoid deprecated 'gtk_window_set_wmclass'Pablo Barciela2-4/+2
2018-06-02caja-bookmark.c: drop unused variablePablo Barciela1-1/+0
Fixes https://github.com/mate-desktop/caja/pull/1001#issuecomment-394072477
2018-05-23caja-bookmark.c: Fix icons in bookmarksPablo Barciela1-16/+10
Fixes https://github.com/mate-desktop/caja/pull/962#issuecomment-389114129
2018-05-20icon-container: avoid deprecated 'gtk_style_context_get_border_color'Pablo Barciela1-2/+7
2018-05-18avoid deprecated 'gtk_dialog_get_action_area'Pablo Barciela1-5/+6
2018-05-16use NULL instead of uninitialized variablemonsta1-4/+2
follow-up to ddf6f38db4e842abecd4f2ee77012050822b3775
2018-05-07Replace deprecated gtk_menu_popupraveit651-4/+4
Replace deprecated gtk_menu_popup in eel-editable-label,caja-dnd, emblem-sidebar,caja-side-pane, fm-tree-view, caja-navigation-window-pane, and caja-zoom-control
2018-05-07libcaja-private: replace deprecated gdk_error_trap functionsraveit651-4/+6
replace gdk_error_trap_push gdk_error_trap_pop_ignored
2018-05-07libcaja-private: fix -Wlogical-not-parentheses build warningraveit651-1/+1
fixes this warning: caja-undostack-manager.c: In function 'retrieve_files_to_restore': caja-undostack-manager.c:1967:38: warning: logical not is only applied to the left hand side of comparison [-Wlogical-not-parentheses] if (!(g_hash_table_size (trashed)) > 0) { ^ caja-undostack-manager.c:1967:7: note: add parentheses around left hand side expression to silence this warning if (!(g_hash_table_size (trashed)) > 0) { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ( )
2018-05-05avoid deprecated 'gtk_style_context_get_background_color'Pablo Barciela2-3/+17
2018-05-03Eliminate accessible children-changed event flood on container repopulationJoanmarie Diggs2-2/+5
When the icon container is repopulated (e.g. when using back/forward) finish_adding_new_icons is called leading to an accessible children- changed event flood. We can distinguish these unwanted notifications from desired notifications by comparing the number of new icons to add with the size of the container's icon set.
2018-04-24Eliminate accessible children-changed event flood during update allJoanmarie Diggs1-0/+6
Accessible children-changed events should only be emitted when a user- triggered action (creation of file, copying an item) causes an item to be added. Set container->details->is_loading (which does not seem to be used anywhere) in caja_icon_container_request_update_all because if the entire container is being updated, children-changed events should not be emitted for each updated icon.
generated by cgit v1.2.1 (git 2.18.0) at 2024-11-10 05:09:05 +0000