summaryrefslogtreecommitdiff
path: root/libcaja-private
AgeCommit message (Collapse)AuthorFilesLines
2022-06-08Document and fix default-sort-order preferenceGordon Norman Squash1-6/+33
This patch resolves three related issues: The first issue was that the GSettings schema for Caja did not include an entry to sort by the "btime", or creation date, of files. If the user chose such an option in the Caja Preferences, GSettings would produce a warning (often out-of-sight, as it was usually redirected into the user's .xsession-errors file), and Caja would not actually change the default sort-order of files. This patch adds the btime as a valid setting in the schema. The second issue was that. because of the above (an entry in the settings schema was missing), some of the alternative sort orders listed in the schema (everything after and including "atime") were not assigned the same numbers as the sort orders listed elsewhere in the Caja source code. Specifically, in icon- and compact-views, if the default sort-order was "emblems", the observed / actual sort-order would be the entry before "emblems", namely "atime" -- so instead of sorting by the names of associated emblems, Caja would sort by each file's access time. An array in the code for the list-view also was missing many values and included some values out of order, so the default sort-order setting affected directories viewed in list-view mode seemingly randomly. The former is taken care of using the fix described in the above paragraph; the latter is fixed in this patch by adding / reorganizing the array for the list-view sort-orders appropriately. The third issue (admittedly, a lesser issue) was that the documentation for the default-sort-order setting was lacking -- it at least did not list all the possible values that the setting could accept. In this patch, I resolve this issue by listing all values in the setting's description, and also go into more detail about what each value does. (However, perhaps I included a little too much detail. It'll only benefit [supposed power users who may already know this stuff] who use GSettings or DConf directly, and it'll certainly be a headache for translators. I'll admit that.)
2022-06-08caja-file-conflict-dialog: Move to automatic signal disconnectionColomban Wendling1-20/+11
Instead of manually keeping tabs on the signals so we can disconnect them before the data parameter gets destroyed, let GObject automatically track lifetime of the data, which it can do as that data is a GObject itself. This does not change behavior in the normal case, but makes sure the callback simply cannot get called with invalid/freed parameters, even if we did screw anything up (which we used to). This actually would have solved #1630 as well with using the target widgets as data parameters as the signal would have been disconnected as soon as the widget got destroyed, no matter whether we got finalized ourselves or not. The signal IDs were also use as guards to whether the monitor was set up for the related files, but we can just as well use the state of the file list ready handle which should only be NULL when we actually have monitors set up. Even if it wasn't the case, worse case scenario would be removing a non-existent monitor, which is perfectly OK anyway.
2022-06-08caja-file-conflict-dialog: Properly release references on dispose()Colomban Wendling1-6/+19
Fixes #1630.
2022-06-08caja-file-conflict-dialog: update the icons oncerbuj1-16/+9
2022-06-01Properly initialize IconKey::scaleColomban Wendling1-0/+1
This value is used to look up icons in the cache, but somehow was not properly initialized.
2022-03-23caja-bookmark: Fix build warning -Wlogical-not-parenthesesrbuj1-1/+1
2022-03-22caja-bookmark: fix memory leakrbuj1-0/+4
2022-03-22caja-bookmark: drop create_image_cairo_for_bookmarkrbuj1-24/+10
2022-02-09Fix implicit conversion changes signedness: 'gboolean' to 'guint'rbuj5-48/+48
2022-02-09Fix some -Wsign-compare warningsrbuj5-30/+27
2022-02-09caja-file-operations: overlapping comparisons always evaluate to truerbuj1-1/+1
2021-12-31caja-module: fix memory leakrbuj1-1/+4
2021-12-19caja-mime-actions: fix memory leakrbuj1-2/+9
2021-11-20Remove whitespaces before #define, #if, and #endifrbuj1-10/+10
2021-11-20Use a blank line at mostrbuj75-331/+0
2021-11-11caja-file: Remove unreachable coderbuj1-1/+0
2021-11-08caja-dnd: wrong type field in printf format stringrbuj1-1/+1
2021-10-11Fix Caja does not show icons of application launchersmouse1-1/+1
in /usr/share/applications and asks user for confirmation on launch of desktop-files here
2021-06-18Update copyright to 2021raveit658-2/+8
2021-05-19caja-directory.c: Fix memory leak.Michael Webster1-1/+1
When creating a new file (using a template, for instance), file-> details->is_added could potentially be FALSE, and cause this file to not be finalized along with other files if the view directory is destroyed. This can cause issues when re-entering that directory, with the file being in an undefined state, and could prevent the view from fully loading the location (this is identical behavior to that described in https://github.com/mate-desktop/python-caja/pull/64. To reproduce: - Create an svg file and save in ~/Templates. - Right-click, Create document-> svg file, name it whatever. - Navigate out of the folder. - Modify the file in a visible manner. - Re-enter the folder, note that it never finishes loading. Ref: https://github.com/linuxmint/nemo/issues/2736
2021-04-20Add creation time supportrbuj6-3/+54
2021-04-13icon view: Add a directory setting to block moving iconsColomban Wendling5-1/+24
This is mostly useful on the desktop (which is the main user of the free-placement icon view) to be able to lock the layout and avoid unintentionally moving icons around. Especially useful for less computer-literate users.
2021-04-02Improved filesystem check on dndrobertxgray3-14/+66
2021-03-11keep one .desktop suffix on desktop file renamingKonstantin Unruh1-1/+4
2021-02-25Fix warnings about xmlChar castrbuj1-5/+10
2021-02-24caja-customization-data: keep the key of the hash table if existsrbuj1-1/+1
2021-02-24caja-customization-data: Do not build the path to the browser.xml filerbuj1-27/+18
2021-02-21caja-directory-async: drop istr_set_insert, use g_hash_table_add insteadrbuj1-19/+7
2021-02-07build: allow users to disable gettext support (--disable-nls)rbuj2-0/+4
2021-01-15Remove warning -Wtype-limitsrbuj1-1/+1
2020-12-11caja-file-operations: Let user mark trusted launcherrbuj1-0/+7
2020-12-11caja-directory-async: trust marked launchersrbuj3-0/+11
gio set PATH "metadata::caja-trusted-launcher" true
2020-12-11caja-directory-async: trust also launchers from user desktoprbuj3-8/+31
2020-12-11caja-directory-async: trust only system launchersrbuj1-6/+1
2020-11-29caja-icon-container: warning -Wold-style-declarationrbuj1-1/+1
2020-11-28file-operations: don't attempt to move into the source direricek1111-8/+8
2020-11-24Remove the use of the gettimeofday functionrbuj1-4/+23
2020-11-11Remove unused macrosPablo Barciela7-33/+0
2020-11-11Fix i18n in backgrounds and emblems dialogrbuj1-2/+2
2020-09-05fm-directory-view: Error message when a link could not be createdrbuj2-3/+5
2020-08-28eel-editable-label: Consecutive break/return statements are unnecessaryrbuj1-2/+2
2020-08-04Remove trailing spaces/tabsrbuj1-1/+1
find . \( -name '*.h' -o -name '*.c' \) -exec sed -i 's/\t*$//' {} \; find . \( -name '*.h' -o -name '*.c' \) -exec sed -i 's/[[:space:]]*$//' {} \;
2020-07-27caja-dnd: Create links by default on dnd from Web Browsersrbuj1-7/+15
2020-07-25Add a "Bookmarks" sidebar to CajaGordon N. Squash1-0/+2
Added a "Bookmarks" sidebar to Caja which displays a list of the user's own bookmarks. Single-clicking any bookmark in the list directs Caja to that bookmark; middle-clicking on the bookmark directs Caja to open the bookmark in a new tab.
2020-07-21Guard block is missingrbuj5-0/+30
2020-05-24caja-file: remove warning GTimeVal is deprecatedrbuj1-1/+13
2020-05-15mate-submodules: use git submodule for libeggWu Xiaotian1-1/+1
2020-04-13Fix -Wmissing-prototypes build warningsPablo Barciela1-1/+1
2020-04-12Remove warnings about function declaration isn’t a prototyperbuj2-7/+7
2020-04-04use MATE_COMPILE_WARNINGS from mate-commonraveit651-1/+1