Age | Commit message (Collapse) | Author | Files | Lines |
|
|
|
The timestamps are reset to the current time, even if the source &
target folders support these GFileInfo attributes.
Closes #1226
|
|
|
|
fixes https://github.com/mate-desktop/caja/issues/1284
Pango 1.44 got the ability to automatically hyphenate on line breaks,
which is on by default, but can be set off by a new attribute.
As a result, we now hyphenate filenames, which is confusing, because
a filename may already include hyphens.
To restore the previous behavior, let's not insert hyphens when
breaking filenames in multiple lines.
Inspired by https://gitlab.gnome.org/GNOME/nautilus/commit/9738d85
|
|
Fixes https://github.com/mate-desktop/caja/issues/1285
|
|
|
|
Fixes cppcheck warnings:
[libcaja-private/caja-file.c:288]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:334]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:386]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
[libcaja-private/caja-file.c:3789]: (error) Shifting signed 32-bit value by 31 bits is undefined behaviour
|
|
Fixes cppcheck warning:
[libcaja-private/caja-icon-canvas-item.c:517]: (error) Uninitialized variable: scale
|
|
Fixes Clang static analyzer warnings:
caja-file-operations.c:2165:7: warning: Access to field 'code' results in a dereference of a null pointer (loaded from variable 'error')
if (error->code != G_IO_ERROR_FAILED_HANDLED) {
^~~~~~~~~~~
caja-file-operations.c:5448:14: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
details = error->message;
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-open-with-dialog.c:252:100: warning: Access to field 'message' results in a dereference of a null pointer (loaded from variable 'error')
message = g_strdup_printf (_("Could not add application to the application database: %s"), error->message);
^~~~~~~~~~~~~~
|
|
Fixes Clang static analyzer warning:
caja-autorun.c:139:5: warning: Null pointer passed as an argument to a 'nonnull' parameter
memcpy (r, v, len * sizeof (char *));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
|
|
Hardcode scale factor to 1 in caja_file_get_icon_pixbuf functions in caja-file-conflict as these icons are already getting scaled elsewhere. Otherwise they get scaled twice and the whole dialog is ballooned oversize on hidpi
*Based on similar change made in Nautilus as a small part of fd01842f996b7d07baf2aafb0f68308fc5ed2055 "file-conflict-dialog: separate file logic from UI management " which was a more general refactoring of the file conflict dialog and split out the frontend and backend code.
|
|
|
|
Fixes Clang static analyzer warning:
caja-progress-info.c:626:17: warning: 1st function call argument is an uninitialized value
g_notification_set_body (notification, _("Process completed"));
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
|
|
Fixes https://github.com/mate-desktop/caja/issues/1183
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warning with Clang Analyzer
|
|
to avoid warnings with Clang Analyzer
|
|
Fixed make distcheck, see #1129
|
|
|
|
Changed CajaIconCanvasItem, CajaTrashMonitor and CajaUndoStackManager
|
|
Changed CajaFileConflictDialog and CajaFile
|
|
Changed CajaDesktopLink, CajaDirectoryAsync and CajaDirectory
|
|
Changed CajaClipboardMonitor, CajaColumnChooser and CajaDesktopIconFile
|
|
Remove unused variables, avoid uninitialized variable warnings, and indent code.
|
|
|
|
Thanks for Leslie Zhai's patch.
|
|
An example of when the MIME type might change: a file is initially created
with 0 bytes of content, but more data is added later. Empty files are always
detected as plain text, but the file might not be empty anymore when the user
opens it.
This commit affects the behavior when double-clicking a file and when right-
clicking on it too.
|
|
Fixes https://github.com/mate-desktop/caja/issues/1099
|
|
|
|
|
|
|
|
|
|
|
|
- remove the "Working..." notification
- show the "Process completed" notification only if the progress window is inactive
|
|
org.mate.caja.preferences.show-notifications
Closes https://github.com/mate-desktop/caja/issues/1093
|
|
'g_strconcat' needs to be freed
|
|
'g_strconcat' needs to be freed
|
|
Fixed running caja_self_check_directory failed.
|
|
Don't treat remote filesystems differently when unmounting
|
|
We crash in g_hash_table_lookup_extended if the file's symlink_name is
set but the file is not a symlink, since the hash function (g_str_hash)
does not allow NULL values but target_uri is NULL.
https://bugzilla.gnome.org/show_bug.cgi?id=711583
Adapted from https://gitlab.gnome.org/GNOME/nautilus/commit/c2a5e052
|
|
Fix https://github.com/mate-desktop/caja/issues/1066 "Caja caches folders from usb drives/disk"
Nowadays, we rely on G_FILE_MONITOR_EVENT_UNMOUNTED to be emitted when a
mount disappears, since we already monitor the directory, in order to
switch the view to a different location.
Since non-native mounts very likely won't have file monitoring though,
we're not going to receive such events in that case, and fail to
redirect the view as a consequence.
This patch fixes it by listening to the mount-removed signal on
GVolumeMonitor when a monitor is requested for a non-native mount, and
emulating a file removal in that case.
Backport Nautilus commit gitlab.gnome.org/GNOME/nautilus/commit/3891241ba760c59d284b7579dbd340651c8d4d29
note that caja_get_mounted_mount_for_root had to be added, while the equivalent Nautilus function was from a prior commit
|
|
The caja_icon_info_lookup method was potentially doing multiple
icon lookups for a single icon, as well as triggering an additional
fallback lookup when returning an empty (no pixbuf) CajaIconInfo
to CajaFile.
This streamlines and simplifies the lookup process. The hash table
lookup always occurs first, before any Gtk icon cache lookup is made
(these are expensive, according to perf analysis,) and a returned
icon info will *always* be added to a hash table, potentially already
containing a fallback icon.
GIcons stringify well enough to use the strings exclusively for hash
keys. This eliminates the extra cost of looking up filenames from the
Gtk icon cache.
Ported from
github.com/linuxmint/nemo/commit/98843e26b48cd3526cacfe90cfa4ba201d1f3aee
where this benchmark resulted for Nemo:
.# sync; echo 3 > /proc/sys/vm/drop_caches
mtwebster:~/bin/nemo[master]> NEMO_BENCHMARK_LOADING=1 nemo /usr/bin
with:
Nemo startup time: 2.011817 seconds
Folder load time: 1.158854 seconds
Idle...Folder load time: 1.226699 seconds
without:
Nemo startup time: 2.464361 seconds
Folder load time: 1.591494 seconds
Idle...Folder load time: 1.692273 seconds
|
|
If true the gsettings key "ctrl-tab-switch-tabs" into "org.mate.caja.preferences"
Closes https://github.com/mate-desktop/caja/issues/768
|
|
Prevent segfault on g_list_find in directory_ready_callback by catching the NULL case
|
|
Remove two functions now unused after github.com/mate-desktop/caja/commit/191aa3992171c84134f0359a960e5bebc7bfeca4 "libcaja-private: remove redundant prefs application to hash table "
|
|
These preferences are all applied elsewhere and all work without this. Removing it stops the g_hash_table_foreach warnings with GTK 3.23.0
|
|
The string returned by eel_bg_get_desktop_color() needs to be freed by
the caller, which wasn't happening before.
Commit b9cf3667 fixed the case where this function was being called
repeatedly, triggering this leak and causing it to rapidly fill system
memory.
|